[GH-ISSUE #672] Procedure execution empty param not exported but required for import #6246

New Issue

GiteaMirror · 2026-04-24T19:23:28-05:00

GiteaMirror commented

2026-04-24 19:23:28 -05:00

Originally created by @satwell on GitHub (Jul 21, 2025).
Original GitHub issue: https://github.com/moghtech/komodo/issues/672

I found a case where the TOML for a procedure exported by the UI cannot be loaded by resource sync. This happens when the executions params are left empty by default. Additionally, checking the resource into git and letting the webhook trigger a resource sync causes the "Run Sync" to run forever.

Steps to reproduce:

Create a basic procedure with a single stage and single execution like Batch Pull Stack. Do not change the value for "Target". Save. Run manually to verify that it works.
Click on the "Toml" button at the top right to see the resource serialized as TOML. This gives me:

[[procedure]]
name = "pull-all"

[[procedure.config.stage]]
name = "Stage 1"
enabled = true
executions = [
  { execution.type = "BatchPullStack", enabled = true }
]

Manually add this resource definition to a git repo that Komodo syncs resources from, and use an "Execute Sync" webhook to sync it.

Run Sync never completes, the last stage shown is "Read remote resources" with stderr INFO: reading resources from "/repo-cache/.... The Komodo Core container log shows this warning: 2025-07-21T13:56:12.808745Z WARN ResourceSyncWebhook{id="687ceee563b4bbc54dbb1d60"}: core::listener::router: Failed at running webhook for resource sync 687ceee563b4bbc54dbb1d60 | Found file errors. Cannot execute sync.

After restarting Komodo Core, the Info tab shows this error:

ERROR: failed to read resources from "/repo-cache/..."

TRACE:
	1: failed to parse resource file contents
	2: TOML parse error at line 85, column 5
   |
85 |   { execution.type = "BatchPullStack", enabled = true }
   |     ^^^^^^^^^
missing field `params`

If I add execution.params.pattern = "" to the execution in that procedure, the sync works. Although it's still missing in the Toml exported on the Procedures page.

Originally created by @satwell on GitHub (Jul 21, 2025). Original GitHub issue: https://github.com/moghtech/komodo/issues/672 I found a case where the TOML for a procedure exported by the UI cannot be loaded by resource sync. This happens when the executions params are left empty by default. Additionally, checking the resource into git and letting the webhook trigger a resource sync causes the "Run Sync" to run forever. Steps to reproduce: 1. Create a basic procedure with a single stage and single execution like Batch Pull Stack. Do not change the value for "Target". Save. Run manually to verify that it works. 2. Click on the "Toml" button at the top right to see the resource serialized as TOML. This gives me: ```toml [[procedure]] name = "pull-all" [[procedure.config.stage]] name = "Stage 1" enabled = true executions = [ { execution.type = "BatchPullStack", enabled = true } ] ``` 3. Manually add this resource definition to a git repo that Komodo syncs resources from, and use an "Execute Sync" webhook to sync it. Run Sync never completes, the last stage shown is "Read remote resources" with stderr `INFO: reading resources from "/repo-cache/...`. The Komodo Core container log shows this warning: `2025-07-21T13:56:12.808745Z WARN ResourceSyncWebhook{id="687ceee563b4bbc54dbb1d60"}: core::listener::router: Failed at running webhook for resource sync 687ceee563b4bbc54dbb1d60 | Found file errors. Cannot execute sync.` After restarting Komodo Core, the Info tab shows this error: ``` ERROR: failed to read resources from "/repo-cache/..." TRACE: 1: failed to parse resource file contents 2: TOML parse error at line 85, column 5 | 85 | { execution.type = "BatchPullStack", enabled = true } | ^^^^^^^^^ missing field `params` ``` If I add `execution.params.pattern = ""` to the execution in that procedure, the sync works. Although it's still missing in the Toml exported on the Procedures page.

GiteaMirror added the bug label 2026-04-24 19:23:28 -05:00

GiteaMirror commented

2026-04-24 19:23:30 -05:00

@mbecker20 commented on GitHub (Aug 30, 2025):

Should be fixed in 1.19.0 release.
Edit: nvm its not i was thinking of a similar issue

@mbecker20 commented on GitHub (Aug 30, 2025): Should be fixed in 1.19.0 release. Edit: nvm its not i was thinking of a similar issue

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#6246