[PR #1171] [CLOSED] fix: improve error message when git is not installed on periphery #5716

New Issue

GiteaMirror · 2026-04-22T00:49:36-05:00

GiteaMirror commented

2026-04-22 00:49:36 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/1171
Author: @litlmike
Created: 2/8/2026
Status: ❌ Closed

Base: main ← Head: fix-issue-797

📝 Commits (1)

0497939 fix: improve error message when git is not installed

📊 Changes

1 file changed (+50 additions, -9 deletions)

View changed files

📝 bin/periphery/src/api/compose.rs (+50 -9)

📄 Description

Fixes #797

Problem

When git is not installed on a periphery machine, stack operations fail with a misleading error:

Failed to validate run directory on host after stack write (canonicalize error): 
No such file or directory (os error 2)

This points users toward path/directory issues when the real cause is that git isn't installed, so the repo clone fails silently.

Solution

Early return on write failures — if the stack write (which includes git clone) produces errors, return those logs immediately instead of proceeding to canonicalize a non-existent directory
Descriptive error messages — the canonicalize error now includes the actual path and suggests checking that git is installed
Applied consistently across ComposePull, ComposeUp, and ComposeRun handlers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/1171 **Author:** [@litlmike](https://github.com/litlmike) **Created:** 2/8/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-issue-797` --- ### 📝 Commits (1) - [`0497939`](https://github.com/moghtech/komodo/commit/049793930047f8e35aa8df6df5d5fef9b2e7d8fb) fix: improve error message when git is not installed ### 📊 Changes **1 file changed** (+50 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `bin/periphery/src/api/compose.rs` (+50 -9) </details> ### 📄 Description Fixes #797 ## Problem When git is not installed on a periphery machine, stack operations fail with a misleading error: ``` Failed to validate run directory on host after stack write (canonicalize error): No such file or directory (os error 2) ``` This points users toward path/directory issues when the real cause is that git isn't installed, so the repo clone fails silently. ## Solution 1. **Early return on write failures** — if the stack write (which includes git clone) produces errors, return those logs immediately instead of proceeding to canonicalize a non-existent directory 2. **Descriptive error messages** — the canonicalize error now includes the actual path and suggests checking that git is installed 3. Applied consistently across `ComposePull`, `ComposeUp`, and `ComposeRun` handlers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-22 00:49:36 -05:00

GiteaMirror closed this issue

2026-04-22 00:49:37 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#5716