[PR #1124] [MERGED] feat: add compose_cmd_wrapper_include for selective command wrapping #5686

New Issue

GiteaMirror · 2026-04-22T00:48:40-05:00

GiteaMirror commented

2026-04-22 00:48:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/1124
Author: @ChanningHe
Created: 1/28/2026
Status: ✅ Merged
Merged: 3/23/2026
Merged by: @mbecker20

Base: 2.0.0 ← Head: feat/compose-cmd-wrapper-include

📝 Commits (2)

35e6e51 feat: add compose_cmd_wrapper_include for selective command wrapping
996bc18 Merge branch '2.0.0' into feat/compose-cmd-wrapper-include

📊 Changes

6 files changed (+350 additions, -65 deletions)

View changed files

📝 bin/periphery/src/api/compose.rs (+208 -36)
📝 bin/periphery/src/api/swarm/stack.rs (+67 -12)
📝 client/core/rs/src/entities/stack.rs (+21 -0)
📝 client/core/ts/src/types.ts (+8 -0)
📝 ui/public/client/types.d.ts (+8 -0)
📝 ui/src/resources/stack/config/index.tsx (+38 -17)

📄 Description

Summary

Previously, compose_cmd_wrapper only wrapped 'docker compose up'. This caused
issues when using sops or similar tools that need to wrap other commands like
'config' - the placeholder in additional_env_files would fail before the
wrapper was applied.

Add compose_cmd_wrapper_include configuration to control which docker compose subcommands are wrapped
Support wrapping
- Compose: config, build, pull, up, run
- Stack: config, deploy
Fix wrapper placeholder text not displaying in MonacoEditor.

Config

[[stack]]
name = "test"
# ...
additional_env_files = [{ path = "{}", track = false }]
compose_cmd_wrapper = "sops exec-file --no-fifo encrypted.env '[[COMPOSE_COMMAND]]'"
compose_cmd_wrapper_include = ["config", "pull", "up"]

Frontend Screenshots

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/1124 **Author:** [@ChanningHe](https://github.com/ChanningHe) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 3/23/2026 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `2.0.0` ← **Head:** `feat/compose-cmd-wrapper-include` --- ### 📝 Commits (2) - [`35e6e51`](https://github.com/moghtech/komodo/commit/35e6e510d50cff492d818b10eab9a31cadcdb58c) feat: add compose_cmd_wrapper_include for selective command wrapping - [`996bc18`](https://github.com/moghtech/komodo/commit/996bc18c44ae870696a6dfeec165a52f103ae256) Merge branch '2.0.0' into feat/compose-cmd-wrapper-include ### 📊 Changes **6 files changed** (+350 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `bin/periphery/src/api/compose.rs` (+208 -36) 📝 `bin/periphery/src/api/swarm/stack.rs` (+67 -12) 📝 `client/core/rs/src/entities/stack.rs` (+21 -0) 📝 `client/core/ts/src/types.ts` (+8 -0) 📝 `ui/public/client/types.d.ts` (+8 -0) 📝 `ui/src/resources/stack/config/index.tsx` (+38 -17) </details> ### 📄 Description ## Summary Previously, compose_cmd_wrapper only wrapped 'docker compose up'. This caused issues when using sops or similar tools that need to wrap other commands like 'config' - the placeholder in additional_env_files would fail before the wrapper was applied. - Add `compose_cmd_wrapper_include` configuration to control which docker compose subcommands are wrapped - Support wrapping - **Compose**: `config`, `build`, `pull`, `up`, `run` - **Stack**: `config`, `deploy` - Fix wrapper placeholder text not displaying in MonacoEditor. ## Config ``` Toml [[stack]] name = "test" # ... additional_env_files = [{ path = "{}", track = false }] compose_cmd_wrapper = "sops exec-file --no-fifo encrypted.env '[[COMPOSE_COMMAND]]'" compose_cmd_wrapper_include = ["config", "pull", "up"] ``` ## Frontend Screenshots ![wp](https://github.com/user-attachments/assets/19cbf916-244a-4f58-a0bf-636ffa782645) ![wp-stack](https://github.com/user-attachments/assets/e4514b04-b17a-4165-b2a8-baf2e45152a6) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-22 00:48:40 -05:00

GiteaMirror closed this issue

2026-04-22 00:48:41 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#5686