[PR #1116] [MERGED] check binary URL #5683

New Issue

GiteaMirror · 2026-04-22T00:48:35-05:00

GiteaMirror commented

2026-04-22 00:48:35 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/1116
Author: @andreasbrett
Created: 1/23/2026
Status: ✅ Merged
Merged: 3/23/2026
Merged by: @mbecker20

Base: 2.0.0 ← Head: patch-1

📝 Commits (1)

5103696 check binary URL

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 scripts/setup-periphery.py (+7 -1)

📄 Description

The periphery setup script doesn't check if the provided version tag is valid and downloads/outputs a mere Not found to the periphery binary file.

I had a typo in my provided version arg and it took me a while to figure out why the service did not run as the script didn't error out.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/1116 **Author:** [@andreasbrett](https://github.com/andreasbrett) **Created:** 1/23/2026 **Status:** ✅ Merged **Merged:** 3/23/2026 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `2.0.0` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`5103696`](https://github.com/moghtech/komodo/commit/51036960105debda3b85a9d9910573a852a3d526) check binary URL ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `scripts/setup-periphery.py` (+7 -1) </details> ### 📄 Description The periphery setup script doesn't check if the provided version tag is valid and downloads/outputs a mere `Not found` to the periphery binary file. I had a typo in my provided version arg and it took me a while to figure out why the service did not run as the script didn't error out. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-22 00:48:35 -05:00

GiteaMirror closed this issue

2026-04-22 00:48:36 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#5683