[PR #1326] Use build.get_image_tags for deployments from builds #4590

New Issue

GiteaMirror · 2026-04-19T14:13:21-05:00

GiteaMirror commented

2026-04-19 14:13:21 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/1326
Author: @4ndv
Created: 4/4/2026
Status: 🔄 Open

Base: main ← Head: build-deployments-use-get-image-tags

📝 Commits (1)

7cffd7f Use build.get_image_tags for deployments from builds

📊 Changes

2 files changed (+31 additions, -36 deletions)

View changed files

📝 bin/core/src/api/execute/deployment.rs (+23 -28)
📝 client/core/rs/src/entities/build.rs (+8 -8)

📄 Description

Reuse build.get_image_tags() for building image tag for deployments
Reorder stuff in get_image_tags for preserving current deployment behavior (to prefer full version tags). It's currently only used for running builds, and builder doesn't really care about the order
Fallback to :latest for both builds and deployments if no other tags were added to not fail when all of the tagging options are disabled

Tried my best to test all the combinations, but I'm not very familiar with the codebase and may miss some things

Fixes #1325

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/1326 **Author:** [@4ndv](https://github.com/4ndv) **Created:** 4/4/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `build-deployments-use-get-image-tags` --- ### 📝 Commits (1) - [`7cffd7f`](https://github.com/moghtech/komodo/commit/7cffd7fb3c994b1c09e21eddde5bac839ede1176) Use `build.get_image_tags` for deployments from builds ### 📊 Changes **2 files changed** (+31 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `bin/core/src/api/execute/deployment.rs` (+23 -28) 📝 `client/core/rs/src/entities/build.rs` (+8 -8) </details> ### 📄 Description - Reuse `build.get_image_tags()` for building image tag for deployments - Reorder stuff in `get_image_tags` for preserving current deployment behavior (to prefer full version tags). It's currently only used for running builds, and builder doesn't really care about the order - Fallback to `:latest` for both builds and deployments if no other tags were added to not fail when all of the tagging options are disabled Tried my best to test all the combinations, but I'm not very familiar with the codebase and may miss some things Fixes #1325 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-19 14:13:21 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#4590

[PR #1326] Use build.get_image_tags for deployments from builds #4590

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #1326] Use `build.get_image_tags` for deployments from builds #4590