github-starred/komodo
2
0
Fork 1
mirror of https://github.com/moghtech/komodo.git synced 2026-07-16 01:59:56 -05:00
Code Issues 12.0k Packages Projects Releases 104 Wiki Activity

[PR #1287] [MERGED] fix missing nullish check when selecting stack #4584

New Issue
Closed
opened 2026-04-19 14:13:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 14:13:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/1287
Author: @ericls
Created: 3/28/2026
Status: ✅ Merged
Merged: 4/1/2026
Merged by: @mbecker20

Base: 2.1.0 ← Head: shen/fix-creating-terminal-for-stack-when-no-stack

📝 Commits (1)

  • fd5738c fix missing nullish check when selecting stack

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 ui/src/components/stack-service-selector.tsx (+1 -1)

📄 Description

Ran into a crash when creating terminal when I select type "stack" while I have 0 stacks configured.

Page crashes with following error:
Screenshot 2026-03-27 at 23 33 31

Looked at the code and looks like a simple case of missing null check.

Side note: Should we enable frontend source map in the builds?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/1287 **Author:** [@ericls](https://github.com/ericls) **Created:** 3/28/2026 **Status:** ✅ Merged **Merged:** 4/1/2026 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `2.1.0` ← **Head:** `shen/fix-creating-terminal-for-stack-when-no-stack` --- ### 📝 Commits (1) - [`fd5738c`](https://github.com/moghtech/komodo/commit/fd5738c15458312f39a4ac045ee1c70695230521) fix missing nullish check when selecting stack ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ui/src/components/stack-service-selector.tsx` (+1 -1) </details> ### 📄 Description Ran into a crash when creating terminal when I select type "stack" while I have 0 stacks configured. Page crashes with following error: <img width="627" height="790" alt="Screenshot 2026-03-27 at 23 33 31" src="https://github.com/user-attachments/assets/2dcb4db3-eb73-4c17-90b8-8c920585994f" /> Looked at the code and looks like a simple case of missing null check. Side note: Should we enable frontend source map in the builds? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 14:13:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
1.19.0
1.19.1
1.19.2
1.19.3
1.19.4
2.0.0
bug
documentation
done
enhancement
help wanted
info
pull-request
Mirrored from GitHub Pull Request
 question
security
seen 👀
setup
thinking 🤔
ui
v2
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/komodo#4584
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?