[PR #1265] let user specify if they want command to be run in shell-mode #4577

New Issue

GiteaMirror · 2026-04-19T14:12:45-05:00

GiteaMirror commented

2026-04-19 14:12:45 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/1265
Author: @ericls
Created: 3/24/2026
Status: 🔄 Open

Base: main ← Head: shen/handle-multi-line-command-v2

📝 Commits (2)

afbbc08 allow users to add commands as shell-mode
5c45b3c revert package.json yarn auto-change

📊 Changes

7 files changed (+33 additions, -10 deletions)

View changed files

📝 bin/periphery/src/api/build/mod.rs (+1 -1)
📝 bin/periphery/src/api/compose.rs (+2 -2)
📝 bin/periphery/src/helpers.rs (+2 -2)
📝 client/core/rs/src/entities/mod.rs (+2 -0)
📝 client/core/ts/src/types.ts (+1 -0)
📝 ui/public/client/types.d.ts (+1 -0)
📝 ui/src/components/config/system-command.tsx (+24 -5)

📄 Description

This is a follow up to https://github.com/moghtech/komodo/pull/1217 in v2.

In v2, things are easier because there's an explicit shell-mode. This makes this change easier to implement and won't cause backwards incompitable changes for existing configs.

Makes something like the following possible:

Without this option, scripts like this would fail for reason like:

bash: This: command not found

Would improve #808

closes #1217

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/1265 **Author:** [@ericls](https://github.com/ericls) **Created:** 3/24/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `shen/handle-multi-line-command-v2` --- ### 📝 Commits (2) - [`afbbc08`](https://github.com/moghtech/komodo/commit/afbbc0829ecac4bdfc61319ab5af99a75bcf3157) allow users to add commands as shell-mode - [`5c45b3c`](https://github.com/moghtech/komodo/commit/5c45b3c110ae6c1ac9555c34e9c604fe6694b3f0) revert package.json yarn auto-change ### 📊 Changes **7 files changed** (+33 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `bin/periphery/src/api/build/mod.rs` (+1 -1) 📝 `bin/periphery/src/api/compose.rs` (+2 -2) 📝 `bin/periphery/src/helpers.rs` (+2 -2) 📝 `client/core/rs/src/entities/mod.rs` (+2 -0) 📝 `client/core/ts/src/types.ts` (+1 -0) 📝 `ui/public/client/types.d.ts` (+1 -0) 📝 `ui/src/components/config/system-command.tsx` (+24 -5) </details> ### 📄 Description This is a follow up to https://github.com/moghtech/komodo/pull/1217 in v2. In v2, things are easier because there's an explicit shell-mode. This makes this change easier to implement and won't cause backwards incompitable changes for existing configs. Makes something like the following possible: <img width="462" height="402" alt="Screenshot 2026-03-24 at 19 30 41" src="https://github.com/user-attachments/assets/e759bc33-28d8-4eb8-af6d-fd78b8dc861a" /> Without this option, scripts like this would fail for reason like: ``` bash: This: command not found ``` Would improve #808 closes #1217 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-19 14:12:46 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#4577