ℹ️ what is unclear to me is the expected/wanted behaviour in case of the post_deploy fails (we could say the deployment was ok since compose up ran fine, but we can also fail the whole action)
Settings
No failure
Failure
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/moghtech/komodo/pull/288
**Author:** [@unsync](https://github.com/unsync)
**Created:** 2/3/2025
**Status:** ✅ Merged
**Merged:** 2/8/2025
**Merged by:** [@mbecker20](https://github.com/mbecker20)
**Base:** `1.17.0` ← **Head:** `feature/postDeployCommand`
---
### 📝 Commits (2)
- [`faccffb`](https://github.com/moghtech/komodo/commit/faccffbae342ccc10ec79974c7490e7ced29358f) feature: add post_deploy command
- [`e965e96`](https://github.com/moghtech/komodo/commit/e965e960b5740cbd24cc497b56f76bdd9a75177e) review: do not run post_deploy if deploy failed
### 📊 Changes
**6 files changed** (+231 additions, -144 deletions)
<details>
<summary>View changed files</summary>
📝 `bin/core/src/api/execute/stack.rs` (+7 -0)
📝 `bin/periphery/src/compose.rs` (+57 -1)
📝 `client/core/rs/src/entities/stack.rs` (+6 -0)
📝 `client/core/ts/src/types.ts` (+135 -133)
📝 `frontend/public/client/types.d.ts` (+12 -10)
📝 `frontend/src/components/resources/stack/config.tsx` (+14 -0)
</details>
### 📄 Description
This PR adds a post_deploy command, similar to the pre_deploy.
### Context
i needed to test a use-case for this, the issue that gave me the idea is here : https://github.com/moghtech/komodo/issues/227
### Questions
ℹ️ what is unclear to me is the expected/wanted behaviour in case of the post_deploy fails (we could say the deployment was ok since compose up ran fine, but we can also fail the whole action)
### Settings
<img width="473" alt="Screenshot 2025-02-03 at 15 41 20" src="https://github.com/user-attachments/assets/afa5ba00-7000-4487-8cd6-f062826b9e24" />
### No failure
<img width="683" alt="Screenshot 2025-02-03 at 15 41 43" src="https://github.com/user-attachments/assets/10770031-615b-4b6c-84fc-b3d93b1bff30" />
### Failure
<img width="777" alt="Screenshot 2025-02-03 at 15 41 35" src="https://github.com/user-attachments/assets/592490f1-82df-4cfb-a147-913c5ce6b8b2" />
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/moghtech/komodo/pull/288
Author: @unsync
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/8/2025
Merged by: @mbecker20
Base:
1.17.0← Head:feature/postDeployCommand📝 Commits (2)
faccffbfeature: add post_deploy commande965e96review: do not run post_deploy if deploy failed📊 Changes
6 files changed (+231 additions, -144 deletions)
View changed files
📝
bin/core/src/api/execute/stack.rs(+7 -0)📝
bin/periphery/src/compose.rs(+57 -1)📝
client/core/rs/src/entities/stack.rs(+6 -0)📝
client/core/ts/src/types.ts(+135 -133)📝
frontend/public/client/types.d.ts(+12 -10)📝
frontend/src/components/resources/stack/config.tsx(+14 -0)📄 Description
This PR adds a post_deploy command, similar to the pre_deploy.
Context
i needed to test a use-case for this, the issue that gave me the idea is here : https://github.com/moghtech/komodo/issues/227
Questions
ℹ️ what is unclear to me is the expected/wanted behaviour in case of the post_deploy fails (we could say the deployment was ok since compose up ran fine, but we can also fail the whole action)
Settings
No failure
Failure
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.