[PR #1186] [CLOSED] fix: include main .env file in stack Info GUI when environment is configured #2991

New Issue

GiteaMirror · 2026-04-11T10:42:33-05:00

GiteaMirror commented

2026-04-11 10:42:33 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/1186
Author: @litlmike
Created: 2/8/2026
Status: ❌ Closed

Base: main ← Head: fix-issue-990

📝 Commits (1)

4952489 fix: include main .env file in stack info when environment is configured

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 client/core/rs/src/entities/stack.rs (+10 -0)

📄 Description

Problem

When a stack has environment variables defined in its configuration, Komodo generates a .env file (at the path specified by env_file_path, defaulting to .env). However, this file was not displayed in the Stack Info GUI unless the user redundantly added it to "Additional Env Files".

Root Cause

The all_file_paths() and all_file_dependencies() methods on Stack included compose files, additional env files, and config files — but not the main env_file_path that gets generated from the environment configuration.

Fix

When environment is non-empty, automatically include env_file_path in both all_file_paths() and all_file_dependencies(). This uses IndexSet so duplicates are handled if the path already appears elsewhere.

Fixes #990

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/1186 **Author:** [@litlmike](https://github.com/litlmike) **Created:** 2/8/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-issue-990` --- ### 📝 Commits (1) - [`4952489`](https://github.com/moghtech/komodo/commit/4952489866ba98b283945bfa0e781c4ddc28f420) fix: include main .env file in stack info when environment is configured ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client/core/rs/src/entities/stack.rs` (+10 -0) </details> ### 📄 Description ## Problem When a stack has environment variables defined in its configuration, Komodo generates a `.env` file (at the path specified by `env_file_path`, defaulting to `.env`). However, this file was not displayed in the Stack Info GUI unless the user redundantly added it to "Additional Env Files". ## Root Cause The `all_file_paths()` and `all_file_dependencies()` methods on `Stack` included compose files, additional env files, and config files — but not the main `env_file_path` that gets generated from the `environment` configuration. ## Fix When `environment` is non-empty, automatically include `env_file_path` in both `all_file_paths()` and `all_file_dependencies()`. This uses `IndexSet` so duplicates are handled if the path already appears elsewhere. Fixes #990 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-11 10:42:33 -05:00

GiteaMirror closed this issue

2026-04-11 10:42:33 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#2991