[PR #1486] [MERGED] Send keepalive pings on user websockets to survive idle proxy timeouts #24827

New Issue

GiteaMirror · 2026-06-20T14:35:56-05:00

GiteaMirror commented

2026-06-20 14:35:56 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/1486
Author: @Dougley
Created: 6/18/2026
Status: ✅ Merged
Merged: 6/20/2026
Merged by: @mbecker20

Base: 2.3.0 ← Head: ws-keepalive-pings

📝 Commits (1)

6275d32 send keepalive pings on user websockets to survive idle proxy timeouts

📊 Changes

3 files changed (+31 additions, -2 deletions)

View changed files

📝 bin/core/src/api/ws/mod.rs (+3 -0)
📝 bin/core/src/api/ws/terminal.rs (+17 -1)
📝 bin/core/src/api/ws/update.rs (+11 -1)

📄 Description

Cloudflare closes TCP sockets that go quiet, and our two user-facing sockets /ws/update and /ws/terminal, send nothing while idle. The socket sits there until the proxy reaps it and the UI falls back to its reconnect loop.

This PR makes the server send a WebSocket Ping every 30s on both endpoints.

(Core<->Periphery connections already ping every 5s. This only touches the two browser-facing endpoints.)

Files

bin/core/src/api/ws/mod.rs - shared WS_KEEP_ALIVE_INTERVAL (30s)
bin/core/src/api/ws/update.rs - ping in the update send loop
bin/core/src/api/ws/terminal.rs - ping in the terminal forward loop

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/1486 **Author:** [@Dougley](https://github.com/Dougley) **Created:** 6/18/2026 **Status:** ✅ Merged **Merged:** 6/20/2026 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `2.3.0` ← **Head:** `ws-keepalive-pings` --- ### 📝 Commits (1) - [`6275d32`](https://github.com/moghtech/komodo/commit/6275d32293a7211a6f0d4088a336fa7111370bff) send keepalive pings on user websockets to survive idle proxy timeouts ### 📊 Changes **3 files changed** (+31 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bin/core/src/api/ws/mod.rs` (+3 -0) 📝 `bin/core/src/api/ws/terminal.rs` (+17 -1) 📝 `bin/core/src/api/ws/update.rs` (+11 -1) </details> ### 📄 Description Cloudflare closes TCP sockets that go quiet, and our two user-facing sockets `/ws/update` and `/ws/terminal`, send nothing while idle. The socket sits there until the proxy reaps it and the UI falls back to its reconnect loop. This PR makes the server send a WebSocket Ping every 30s on both endpoints. (Core<->Periphery connections already ping every 5s. This only touches the two browser-facing endpoints.) ## Files - `bin/core/src/api/ws/mod.rs` - shared `WS_KEEP_ALIVE_INTERVAL` (30s) - `bin/core/src/api/ws/update.rs` - ping in the update send loop - `bin/core/src/api/ws/terminal.rs` - ping in the terminal forward loop --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-06-20 14:35:56 -05:00

GiteaMirror closed this issue

2026-06-20 14:35:57 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#24827