mirror of
https://github.com/moghtech/komodo.git
synced 2026-03-09 07:13:36 -05:00
bug: invalid max and used storage when using docker bind mountpoints #16
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Lukas-Heiligenbrunner on GitHub (Aug 13, 2024).
When using docker bind mountpoints every mountpoint shows as device and is added multiple times to the total capacity.
Compose file:
@mbecker20 commented on GitHub (Aug 13, 2024):
Hi, thanks for the report.
I am aware of this happening in other cases with docker mounts, in those cases I saw though the file system was able to report as "overlay". And I filter these disks out: https://github.com/mbecker20/monitor/blob/2d0c1724db77f8b1211dd60436f015ee1000be89/bin/periphery/src/stats.rs#L108 Clearly this isn't working here though.
I see two actions to resolve this:
I think it is reasonable to additionally filter out any disks which appear to be docker volumes: eg. starts with /var/lib/docker/volume/*. I don't see a situation where you would want a volume mounted to a path there to show up in the disk usage report.
There may not be a way for Monitor to reliably infer that a disk report is actually a mount and should be ignored, it just depends on User setup. I can add another configuration field to Server,
ignore_mounts, which will allow the user to hard filter out any of mounts that are able to get through the guards I put to keep them out.@mbecker20 commented on GitHub (Aug 15, 2024):
Hey, should be fixed in this commit: https://github.com/mbecker20/monitor/commit/a2b0981f7632d8ff2ac5419ec2827228500cd6b6.
Additionally, can now avoid any future edge cases here using the new Server config field
ignore_mounts:@mbecker20 commented on GitHub (Aug 15, 2024):
When you get a chance, could you try out
ghcr.io/mbecker20/monitor:latestand confirm the issue is fixed?@Lukas-Heiligenbrunner commented on GitHub (Aug 15, 2024):
Looks good now.
Thanks a lot!