[PR #409] [MERGED] 1.17.2 #13028

New Issue

2026-05-17T19:41:43-05:00

GiteaMirror commented

2026-05-17 19:41:43 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/409
Author: @mbecker20
Created: 4/15/2025
Status: ✅ Merged
Merged: 4/19/2025
Merged by: @mbecker20

Base: main ← Head: 1.17.2

📝 Commits (10+)

e7a9d21 start on cron schedules
cca2e48 rust 1.86.0
301fc8e config periphery directories easier with PERIPHERY_ROOT_DIRECTORY
e70dec2 schedule backend
20d07ec fix config switch toggling through disabled
d2819f9 procedure schedule working
b843c1b implement schedules for actions
ccd1f7f update schedule immediately after last run
cf384e6 improve config update logs using toml diffs backend
37071ad improve the config update logs with TOML diff view

📊 Changes

79 files changed (+2524 additions, -715 deletions)

View changed files

📝 Cargo.lock (+110 -14)
📝 Cargo.toml (+8 -2)
📝 bin/binaries.Dockerfile (+2 -2)
📝 bin/core/Cargo.toml (+5 -1)
📝 bin/core/aio.Dockerfile (+1 -1)
📝 bin/core/src/alert/discord.rs (+18 -0)
📝 bin/core/src/alert/mod.rs (+14 -2)
📝 bin/core/src/alert/ntfy.rs (+18 -0)
➕ bin/core/src/alert/pushover.rs (+270 -0)
📝 bin/core/src/alert/slack.rs (+38 -5)
📝 bin/core/src/api/execute/action.rs (+28 -2)
📝 bin/core/src/api/execute/procedure.rs (+27 -2)
📝 bin/core/src/api/write/build.rs (+1 -3)
📝 bin/core/src/api/write/sync.rs (+3 -1)
📝 bin/core/src/config.rs (+1 -0)
📝 bin/core/src/main.rs (+5 -3)
📝 bin/core/src/resource/action.rs (+20 -4)
📝 bin/core/src/resource/alerter.rs (+5 -1)
📝 bin/core/src/resource/build.rs (+5 -1)
📝 bin/core/src/resource/builder.rs (+5 -1)

...and 59 more files

📄 Description

Changelog

General

Simplify Periphery directory configuration using one single PERIPHERY_ROOT_DIRECTORY.
- The change is backward compatible, and your currently configured eg. PERIPHERY_STACK_DIR will still take precedent.
Resource configuration changes will now show the full TOML diff of the changes made in the Update log

Resources

Procedure / Action: Implement Schedule feature re #47
- Supports using English or CRON expression using english-to-cron and croner libraries
- English Example: Every Sunday at midnight
- Equivalent CRON: 0 0 0 ? * SUN
- RunSchedule alert type can be sent when the scheduled runs occur
- Also add ProcedureFailed and ActionFailed alert types for visibility on failures when running them on schedules.
Alerter: Add Pushover alerter by @alexshore in #421

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/409 **Author:** [@mbecker20](https://github.com/mbecker20) **Created:** 4/15/2025 **Status:** ✅ Merged **Merged:** 4/19/2025 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `main` ← **Head:** `1.17.2` --- ### 📝 Commits (10+) - [`e7a9d21`](https://github.com/moghtech/komodo/commit/e7a9d2192cfcf16280156f656a6e8203ab11ccc0) start on cron schedules - [`cca2e48`](https://github.com/moghtech/komodo/commit/cca2e48a403712db49db35e15dfc116ce14bf3df) rust 1.86.0 - [`301fc8e`](https://github.com/moghtech/komodo/commit/301fc8e5bf35616545367cbef4d01457418401c0) config periphery directories easier with PERIPHERY_ROOT_DIRECTORY - [`e70dec2`](https://github.com/moghtech/komodo/commit/e70dec2ecab38cc783cfbb95c075aa32530a5ca8) schedule backend - [`20d07ec`](https://github.com/moghtech/komodo/commit/20d07ec915a55143497f720b913ea0aaf27aa887) fix config switch toggling through disabled - [`d2819f9`](https://github.com/moghtech/komodo/commit/d2819f95869147e106581021002ab6603d5c80f4) procedure schedule working - [`b843c1b`](https://github.com/moghtech/komodo/commit/b843c1bd329ded8633b90521ae37489658b79e99) implement schedules for actions - [`ccd1f7f`](https://github.com/moghtech/komodo/commit/ccd1f7fa7f49da25193fde52f0fe5e341f3c1f57) update schedule immediately after last run - [`cf384e6`](https://github.com/moghtech/komodo/commit/cf384e6f7dce4b401b2330e4ebeb0bc1196db42f) improve config update logs using toml diffs backend - [`37071ad`](https://github.com/moghtech/komodo/commit/37071adc40b6f31a7f79712a9e1a2f7f2aa7fb1f) improve the config update logs with TOML diff view ### 📊 Changes **79 files changed** (+2524 additions, -715 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+110 -14) 📝 `Cargo.toml` (+8 -2) 📝 `bin/binaries.Dockerfile` (+2 -2) 📝 `bin/core/Cargo.toml` (+5 -1) 📝 `bin/core/aio.Dockerfile` (+1 -1) 📝 `bin/core/src/alert/discord.rs` (+18 -0) 📝 `bin/core/src/alert/mod.rs` (+14 -2) 📝 `bin/core/src/alert/ntfy.rs` (+18 -0) ➕ `bin/core/src/alert/pushover.rs` (+270 -0) 📝 `bin/core/src/alert/slack.rs` (+38 -5) 📝 `bin/core/src/api/execute/action.rs` (+28 -2) 📝 `bin/core/src/api/execute/procedure.rs` (+27 -2) 📝 `bin/core/src/api/write/build.rs` (+1 -3) 📝 `bin/core/src/api/write/sync.rs` (+3 -1) 📝 `bin/core/src/config.rs` (+1 -0) 📝 `bin/core/src/main.rs` (+5 -3) 📝 `bin/core/src/resource/action.rs` (+20 -4) 📝 `bin/core/src/resource/alerter.rs` (+5 -1) 📝 `bin/core/src/resource/build.rs` (+5 -1) 📝 `bin/core/src/resource/builder.rs` (+5 -1) _...and 59 more files_ </details> ### 📄 Description # Changelog ## General - Simplify Periphery directory configuration using one single `PERIPHERY_ROOT_DIRECTORY`. - The change is backward compatible, and your currently configured eg. PERIPHERY_STACK_DIR will still take precedent. - Resource configuration changes will now show the full TOML diff of the changes made in the Update log ## Resources - **Procedure / Action**: Implement **Schedule** feature re #47 - Supports using English or CRON expression using [english-to-cron](https://crates.io/crates/english-to-cron) and [croner](https://docs.rs/croner/latest/croner/) libraries - English Example: `Every Sunday at midnight` - Equivalent CRON: `0 0 0 ? * SUN` - **RunSchedule alert type** can be sent when the scheduled runs occur - Also add **ProcedureFailed** and **ActionFailed** alert types for visibility on failures when running them on schedules. - **Alerter**: Add `Pushover` alerter by @alexshore in #421 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-17 19:41:43 -05:00

GiteaMirror closed this issue

2026-05-17 19:41:44 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#13028