This is something i really need, in order to be able to manage my alerters with a git sync without exposing my secrets.
I have a custom endpoint to which i add a secret token, not perfect security-wise (headers would be better) but i think it can still be an improvement for some users.
⚠️ i didn't attempt to sanitise the trace, that could be beyond my knowledge of rust and this awesome project ^^
Screens
Full URL interpolated
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/moghtech/komodo/pull/289
**Author:** [@unsync](https://github.com/unsync)
**Created:** 2/3/2025
**Status:** ✅ Merged
**Merged:** 2/8/2025
**Merged by:** [@mbecker20](https://github.com/mbecker20)
**Base:** `1.17.0` ← **Head:** `feature/interpolatealerter`
---
### 📝 Commits (4)
- [`098d14b`](https://github.com/moghtech/komodo/commit/098d14ba644c4a94f465e3c68cf3f7c1ea09d3ba) feature: interpolate secrets in custom alerter
- [`cac799e`](https://github.com/moghtech/komodo/commit/cac799e21c2f0c12b8c6ee0ff98f4bef1d9227f7) fix rust warning
- [`8de3e65`](https://github.com/moghtech/komodo/commit/8de3e65321efd03fc57c015e2310e94d1e3dd5d3) review: sanitize errors
- [`0bbb3d7`](https://github.com/moghtech/komodo/commit/0bbb3d7a9b2b75912c43fe72c6cecc133a58f5ee) review: sanitize error message
### 📊 Changes
**1 file changed** (+23 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `bin/core/src/alert/mod.rs` (+23 -1)
</details>
### 📄 Description
This is something i really need, in order to be able to manage my alerters with a git sync without exposing my secrets.
I have a custom endpoint to which i add a secret token, not perfect security-wise (headers would be better) but i think it can still be an improvement for some users.
⚠️ i didn't attempt to sanitise the trace, that could be beyond my knowledge of rust and this awesome project ^^
## Screens
<img width="506" alt="Screenshot 2025-02-03 at 16 55 52" src="https://github.com/user-attachments/assets/cc14c8c1-20c4-4f3f-930d-674174fa66fd" />
<img width="715" alt="Screenshot 2025-02-03 at 16 55 46" src="https://github.com/user-attachments/assets/64a2d6ad-8756-48f5-a0c9-bff771599c5d" />
### Full URL interpolated
<img width="398" alt="Screenshot 2025-02-03 at 17 24 35" src="https://github.com/user-attachments/assets/5dff08a4-9902-43a1-8379-9fc79e2780f2" />
<img width="629" alt="Screenshot 2025-02-03 at 17 24 45" src="https://github.com/user-attachments/assets/e16e4617-74a9-4d01-8f02-41501ece9469" />
<img width="606" alt="Screenshot 2025-02-03 at 17 24 39" src="https://github.com/user-attachments/assets/29cb821e-feab-4628-b2b3-3ef9a62e24f7" />
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/moghtech/komodo/pull/289
Author: @unsync
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/8/2025
Merged by: @mbecker20
Base:
1.17.0← Head:feature/interpolatealerter📝 Commits (4)
098d14bfeature: interpolate secrets in custom alertercac799efix rust warning8de3e65review: sanitize errors0bbb3d7review: sanitize error message📊 Changes
1 file changed (+23 additions, -1 deletions)
View changed files
📝
bin/core/src/alert/mod.rs(+23 -1)📄 Description
This is something i really need, in order to be able to manage my alerters with a git sync without exposing my secrets.
I have a custom endpoint to which i add a secret token, not perfect security-wise (headers would be better) but i think it can still be an improvement for some users.
⚠️ i didn't attempt to sanitise the trace, that could be beyond my knowledge of rust and this awesome project ^^
Screens
Full URL interpolated
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.