mirror of
https://github.com/moghtech/komodo.git
synced 2026-05-07 02:16:06 -05:00
[Feature] The stack/info page should detect *compose.override.yml files and allow us to edit them #1087
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @itsmaxymoo on GitHub (Apr 5, 2025).
When starting a stack in Komodo, the associated docker-compose.override.yml works as expected. If I enter both compose and override.yml files into the Komodo interface, it marks the stack as unhealthy (?). I use override.yml files to apply portable customizations (reverse proxy, bind volumes, etc...) to vendored compose files. Ideally, the compose.yml editor would detect override files, as well.
@mbecker20 commented on GitHub (Apr 5, 2025):
Lets start with editing - did you add both the main compose file and the override compose file in the File Paths configuration? If this is done, it should show both files on the Info page with their associated paths, and allow you to edit both.
@itsmaxymoo commented on GitHub (Apr 7, 2025):
@mbecker20 Yes. It appears that it requires you to full stop and then restart the stack, and then it will no longer show up as "unhealthy". This is good enough for me. I'm unfamiliar with rust, but if you give me a quick rundown of the relevant files I can try and add the custome OIDC username parameter.
@mbecker20 commented on GitHub (Apr 7, 2025):
@itsmaxymoo The OIDC username is handled here: https://github.com/moghtech/komodo/blob/1.17.1/bin/core/src/auth/oidc/mod.rs#L230
If you do PR, base it on 1.17.1, so it can be included in next release.