When serializing procedure stages to TOML, empty string fields (like pattern) were dropped by toml_pretty's skip_empty_string option. This caused params to be empty/missing, failing deserialization with missing field params.
Two fixes:
Disable skip_empty_string when serializing procedure stages so fields like pattern = "" are preserved in TOML output.
Add #[serde(default)] to pattern fields on all Batch* execution structs as defense-in-depth.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/moghtech/komodo/pull/1169
Author: @litlmike
Created: 2/8/2026
Status: ❌ Closed
Base:
main← Head:fix-issue-672📝 Commits (1)
1b3115bfix: always serialize empty params in procedure export📊 Changes
7 files changed (+17 additions, -1 deletions)
View changed files
📝
bin/core/src/sync/toml.rs(+5 -1)📝
client/core/rs/src/api/execute/action.rs(+1 -0)📝
client/core/rs/src/api/execute/build.rs(+1 -0)📝
client/core/rs/src/api/execute/deployment.rs(+2 -0)📝
client/core/rs/src/api/execute/procedure.rs(+1 -0)📝
client/core/rs/src/api/execute/repo.rs(+3 -0)📝
client/core/rs/src/api/execute/stack.rs(+4 -0)📄 Description
When serializing procedure stages to TOML, empty string fields (like
pattern) were dropped by toml_pretty'sskip_empty_stringoption. This caused params to be empty/missing, failing deserialization withmissing field params.Two fixes:
skip_empty_stringwhen serializing procedure stages so fields likepattern = ""are preserved in TOML output.#[serde(default)]topatternfields on all Batch* execution structs as defense-in-depth.Closes #672
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.