From d11ca79b77c771aaea0392eccf9ba02ef02d12a2 Mon Sep 17 00:00:00 2001 From: M M Arif Date: Tue, 26 Apr 2022 21:17:13 +0500 Subject: [PATCH] remove 5.1 support and some ui fixes --- app/build.gradle | 2 +- .../mian/gitnex/fragments/MyRepositoriesFragment.java | 11 ++++++++--- .../mian/gitnex/fragments/OrganizationsFragment.java | 3 +++ .../mian/gitnex/fragments/RepositoriesFragment.java | 3 +++ .../gitnex/fragments/StarredRepositoriesFragment.java | 11 ++++++++--- app/src/main/res/layout/fragment_organizations.xml | 2 -- app/src/main/res/layout/fragment_repositories.xml | 2 -- 7 files changed, 23 insertions(+), 11 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index bb395af1..d682f12c 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -4,7 +4,7 @@ android { compileSdkVersion 31 defaultConfig { applicationId "org.mian.gitnex" - minSdkVersion 22 + minSdkVersion 23 targetSdkVersion 31 versionCode 425 versionName "4.3.0" diff --git a/app/src/main/java/org/mian/gitnex/fragments/MyRepositoriesFragment.java b/app/src/main/java/org/mian/gitnex/fragments/MyRepositoriesFragment.java index 06a628cf..136f13d7 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/MyRepositoriesFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/MyRepositoriesFragment.java @@ -12,10 +12,11 @@ import android.view.View; import android.view.ViewGroup; import android.view.inputmethod.EditorInfo; import androidx.annotation.NonNull; +import androidx.core.content.ContextCompat; import androidx.fragment.app.Fragment; import androidx.lifecycle.ViewModelProvider; -import androidx.recyclerview.widget.DividerItemDecoration; import androidx.recyclerview.widget.LinearLayoutManager; +import androidx.recyclerview.widget.RecyclerView; import org.mian.gitnex.R; import org.mian.gitnex.activities.BaseActivity; import org.mian.gitnex.activities.CreateRepoActivity; @@ -23,6 +24,7 @@ import org.mian.gitnex.activities.MainActivity; import org.mian.gitnex.adapters.ReposListAdapter; import org.mian.gitnex.databinding.FragmentRepositoriesBinding; import org.mian.gitnex.helpers.Constants; +import org.mian.gitnex.helpers.DividerItemDecorator; import org.mian.gitnex.viewmodels.RepositoriesViewModel; /** @@ -56,10 +58,13 @@ public class MyRepositoriesFragment extends Fragment { fragmentRepositoriesBinding.recyclerView.setHasFixedSize(true); fragmentRepositoriesBinding.recyclerView.setLayoutManager(new LinearLayoutManager(getContext())); - DividerItemDecoration dividerItemDecoration = new DividerItemDecoration(fragmentRepositoriesBinding.recyclerView.getContext(), - DividerItemDecoration.VERTICAL); + + RecyclerView.ItemDecoration dividerItemDecoration = new DividerItemDecorator(ContextCompat.getDrawable(requireContext(), R.drawable.shape_list_divider)); fragmentRepositoriesBinding.recyclerView.addItemDecoration(dividerItemDecoration); + fragmentRepositoriesBinding.recyclerView.setPadding(0, 0, 0, 200); + fragmentRepositoriesBinding.recyclerView.setClipToPadding(false); + fragmentRepositoriesBinding.pullToRefresh.setOnRefreshListener(() -> new Handler(Looper.getMainLooper()).postDelayed(() -> { page = 1; diff --git a/app/src/main/java/org/mian/gitnex/fragments/OrganizationsFragment.java b/app/src/main/java/org/mian/gitnex/fragments/OrganizationsFragment.java index 430293df..e1c04f78 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/OrganizationsFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/OrganizationsFragment.java @@ -61,6 +61,9 @@ public class OrganizationsFragment extends Fragment { RecyclerView.ItemDecoration dividerItemDecoration = new DividerItemDecorator(ContextCompat.getDrawable(requireContext(), R.drawable.shape_list_divider)); fragmentOrganizationsBinding.recyclerView.addItemDecoration(dividerItemDecoration); + fragmentOrganizationsBinding.recyclerView.setPadding(0, 0, 0, 200); + fragmentOrganizationsBinding.recyclerView.setClipToPadding(false); + fragmentOrganizationsBinding.pullToRefresh.setOnRefreshListener(() -> new Handler(Looper.getMainLooper()).postDelayed(() -> { page = 1; diff --git a/app/src/main/java/org/mian/gitnex/fragments/RepositoriesFragment.java b/app/src/main/java/org/mian/gitnex/fragments/RepositoriesFragment.java index 30d2f42d..b53df8d9 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/RepositoriesFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/RepositoriesFragment.java @@ -59,6 +59,9 @@ public class RepositoriesFragment extends Fragment { RecyclerView.ItemDecoration dividerItemDecoration = new DividerItemDecorator(ContextCompat.getDrawable(requireContext(), R.drawable.shape_list_divider)); fragmentRepositoriesBinding.recyclerView.addItemDecoration(dividerItemDecoration); + fragmentRepositoriesBinding.recyclerView.setPadding(0, 0, 0, 200); + fragmentRepositoriesBinding.recyclerView.setClipToPadding(false); + fragmentRepositoriesBinding.pullToRefresh.setOnRefreshListener(() -> new Handler(Looper.getMainLooper()).postDelayed(() -> { page = 1; diff --git a/app/src/main/java/org/mian/gitnex/fragments/StarredRepositoriesFragment.java b/app/src/main/java/org/mian/gitnex/fragments/StarredRepositoriesFragment.java index 4d4fc2bf..1458e2da 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/StarredRepositoriesFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/StarredRepositoriesFragment.java @@ -12,16 +12,18 @@ import android.view.View; import android.view.ViewGroup; import android.view.inputmethod.EditorInfo; import androidx.annotation.NonNull; +import androidx.core.content.ContextCompat; import androidx.fragment.app.Fragment; import androidx.lifecycle.ViewModelProvider; -import androidx.recyclerview.widget.DividerItemDecoration; import androidx.recyclerview.widget.LinearLayoutManager; +import androidx.recyclerview.widget.RecyclerView; import org.mian.gitnex.R; import org.mian.gitnex.activities.CreateRepoActivity; import org.mian.gitnex.activities.MainActivity; import org.mian.gitnex.adapters.ReposListAdapter; import org.mian.gitnex.databinding.FragmentRepositoriesBinding; import org.mian.gitnex.helpers.Constants; +import org.mian.gitnex.helpers.DividerItemDecorator; import org.mian.gitnex.viewmodels.RepositoriesViewModel; /** @@ -53,10 +55,13 @@ public class StarredRepositoriesFragment extends Fragment { fragmentRepositoriesBinding.recyclerView.setHasFixedSize(true); fragmentRepositoriesBinding.recyclerView.setLayoutManager(new LinearLayoutManager(getContext())); - DividerItemDecoration dividerItemDecoration = new DividerItemDecoration(fragmentRepositoriesBinding.recyclerView.getContext(), - DividerItemDecoration.VERTICAL); + + RecyclerView.ItemDecoration dividerItemDecoration = new DividerItemDecorator(ContextCompat.getDrawable(requireContext(), R.drawable.shape_list_divider)); fragmentRepositoriesBinding.recyclerView.addItemDecoration(dividerItemDecoration); + fragmentRepositoriesBinding.recyclerView.setPadding(0, 0, 0, 200); + fragmentRepositoriesBinding.recyclerView.setClipToPadding(false); + fragmentRepositoriesBinding.pullToRefresh.setOnRefreshListener(() -> new Handler(Looper.getMainLooper()).postDelayed(() -> { page = 1; diff --git a/app/src/main/res/layout/fragment_organizations.xml b/app/src/main/res/layout/fragment_organizations.xml index 3abc005f..609391b0 100644 --- a/app/src/main/res/layout/fragment_organizations.xml +++ b/app/src/main/res/layout/fragment_organizations.xml @@ -15,8 +15,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:background="?attr/primaryBackgroundColor" - android:paddingBottom="64dp" - android:clipToPadding="false" android:scrollbars="vertical" /> diff --git a/app/src/main/res/layout/fragment_repositories.xml b/app/src/main/res/layout/fragment_repositories.xml index f172846a..7c3ad7de 100644 --- a/app/src/main/res/layout/fragment_repositories.xml +++ b/app/src/main/res/layout/fragment_repositories.xml @@ -17,8 +17,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:background="?attr/primaryBackgroundColor" - android:paddingBottom="64dp" - android:clipToPadding="false" android:scrollbars="vertical" />