From 636117aad9ef79424752fad2b76e0aea363a00bd Mon Sep 17 00:00:00 2001 From: M M Arif Date: Sun, 27 Mar 2022 15:13:04 +0500 Subject: [PATCH] Minor improvements --- .../mian/gitnex/viewmodels/AdminGetUsersViewModel.java | 6 ++---- .../java/org/mian/gitnex/viewmodels/IssuesViewModel.java | 1 + .../mian/gitnex/viewmodels/RepoStargazersViewModel.java | 7 +------ .../mian/gitnex/viewmodels/RepoWatchersViewModel.java | 8 +------- .../org/mian/gitnex/viewmodels/TeamsByOrgViewModel.java | 9 +-------- 5 files changed, 6 insertions(+), 25 deletions(-) diff --git a/app/src/main/java/org/mian/gitnex/viewmodels/AdminGetUsersViewModel.java b/app/src/main/java/org/mian/gitnex/viewmodels/AdminGetUsersViewModel.java index afa970f0..077b4f2f 100644 --- a/app/src/main/java/org/mian/gitnex/viewmodels/AdminGetUsersViewModel.java +++ b/app/src/main/java/org/mian/gitnex/viewmodels/AdminGetUsersViewModel.java @@ -42,9 +42,7 @@ public class AdminGetUsersViewModel extends ViewModel { public void onResponse(@NonNull Call> call, @NonNull Response> response) { if (response.isSuccessful()) { - if(response.code() == 200) { - usersList.postValue(response.body()); - } + usersList.postValue(response.body()); } } @@ -52,7 +50,6 @@ public class AdminGetUsersViewModel extends ViewModel { public void onFailure(@NonNull Call> call, @NonNull Throwable t) { Log.e("onFailure", t.toString()); } - }); } @@ -68,6 +65,7 @@ public class AdminGetUsersViewModel extends ViewModel { public void onResponse(@NonNull Call> call, @NonNull Response> response) { if (response.isSuccessful()) { + List list = usersList.getValue(); assert list != null; assert response.body() != null; diff --git a/app/src/main/java/org/mian/gitnex/viewmodels/IssuesViewModel.java b/app/src/main/java/org/mian/gitnex/viewmodels/IssuesViewModel.java index 6bdcd7df..e6e631f7 100644 --- a/app/src/main/java/org/mian/gitnex/viewmodels/IssuesViewModel.java +++ b/app/src/main/java/org/mian/gitnex/viewmodels/IssuesViewModel.java @@ -77,6 +77,7 @@ public class IssuesViewModel extends ViewModel { public void onResponse(@NonNull Call> call, @NonNull Response> response) { if (response.isSuccessful()) { + List list = issuesList.getValue(); assert list != null; assert response.body() != null; diff --git a/app/src/main/java/org/mian/gitnex/viewmodels/RepoStargazersViewModel.java b/app/src/main/java/org/mian/gitnex/viewmodels/RepoStargazersViewModel.java index ef75b351..2ccc611b 100644 --- a/app/src/main/java/org/mian/gitnex/viewmodels/RepoStargazersViewModel.java +++ b/app/src/main/java/org/mian/gitnex/viewmodels/RepoStargazersViewModel.java @@ -41,12 +41,8 @@ public class RepoStargazersViewModel extends ViewModel { public void onResponse(@NonNull Call> call, @NonNull Response> response) { if(response.isSuccessful()) { - if(response.code() == 200) { - stargazersList.postValue(response.body()); - - } + stargazersList.postValue(response.body()); } - } @Override @@ -55,6 +51,5 @@ public class RepoStargazersViewModel extends ViewModel { } }); - } } diff --git a/app/src/main/java/org/mian/gitnex/viewmodels/RepoWatchersViewModel.java b/app/src/main/java/org/mian/gitnex/viewmodels/RepoWatchersViewModel.java index ce4b7144..b0a548f7 100644 --- a/app/src/main/java/org/mian/gitnex/viewmodels/RepoWatchersViewModel.java +++ b/app/src/main/java/org/mian/gitnex/viewmodels/RepoWatchersViewModel.java @@ -41,20 +41,14 @@ public class RepoWatchersViewModel extends ViewModel { public void onResponse(@NonNull Call> call, @NonNull Response> response) { if(response.isSuccessful()) { - if(response.code() == 200) { - watchersList.postValue(response.body()); - - } + watchersList.postValue(response.body()); } - } @Override public void onFailure(@NonNull Call> call, Throwable t) { Log.i("onFailure", t.toString()); } - }); - } } diff --git a/app/src/main/java/org/mian/gitnex/viewmodels/TeamsByOrgViewModel.java b/app/src/main/java/org/mian/gitnex/viewmodels/TeamsByOrgViewModel.java index b9ea6c81..ead272ec 100644 --- a/app/src/main/java/org/mian/gitnex/viewmodels/TeamsByOrgViewModel.java +++ b/app/src/main/java/org/mian/gitnex/viewmodels/TeamsByOrgViewModel.java @@ -46,10 +46,7 @@ public class TeamsByOrgViewModel extends ViewModel { public void onResponse(@NonNull Call> call, @NonNull Response> response) { if(response.isSuccessful()) { - if(response.code() == 200) { - teamsList.postValue(response.body()); - - } + teamsList.postValue(response.body()); } else if(response.code() == 403) { Toasty.error(ctx, ctx.getString(R.string.authorizeError)); @@ -60,7 +57,6 @@ public class TeamsByOrgViewModel extends ViewModel { mProgressBar.setVisibility(View.GONE); noDataTeams.setText(R.string.genericError); } - } @Override @@ -69,9 +65,6 @@ public class TeamsByOrgViewModel extends ViewModel { mProgressBar.setVisibility(View.GONE); noDataTeams.setText(R.string.genericError); } - }); - } - }