From 0ed9d95b4df153e55bf2c0c22d342f7dae165c6a Mon Sep 17 00:00:00 2001 From: M M Arif Date: Wed, 20 Apr 2022 16:59:41 +0500 Subject: [PATCH] Move issue/pr screen bottomsheet to new UI --- .../BottomSheetOrganizationFragment.java | 2 +- .../BottomSheetSingleIssueFragment.java | 24 +- .../res/layout/bottom_sheet_admin_users.xml | 4 +- .../main/res/layout/bottom_sheet_drafts.xml | 4 +- .../res/layout/bottom_sheet_file_viewer.xml | 4 +- .../layout/bottom_sheet_issue_comments.xml | 10 +- .../res/layout/bottom_sheet_issues_filter.xml | 4 +- .../layout/bottom_sheet_labels_in_list.xml | 4 +- .../layout/bottom_sheet_milestones_filter.xml | 4 +- .../bottom_sheet_milestones_in_list.xml | 4 +- .../layout/bottom_sheet_my_issues_filter.xml | 4 +- .../res/layout/bottom_sheet_notifications.xml | 4 +- .../bottom_sheet_notifications_filter.xml | 4 +- .../res/layout/bottom_sheet_organization.xml | 5 +- .../bottom_sheet_organization_teams.xml | 4 +- .../main/res/layout/bottom_sheet_profile.xml | 4 +- .../bottom_sheet_pull_request_filter.xml | 4 +- .../res/layout/bottom_sheet_releases_tags.xml | 4 +- app/src/main/res/layout/bottom_sheet_repo.xml | 6 +- .../res/layout/bottom_sheet_single_issue.xml | 384 +++++++++--------- .../res/layout/bottom_sheet_tag_in_list.xml | 4 +- .../res/layout/bottom_sheet_user_profile.xml | 4 +- app/src/main/res/values/strings.xml | 8 +- 23 files changed, 254 insertions(+), 249 deletions(-) diff --git a/app/src/main/java/org/mian/gitnex/fragments/BottomSheetOrganizationFragment.java b/app/src/main/java/org/mian/gitnex/fragments/BottomSheetOrganizationFragment.java index fe4e9dd8..baf36901 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/BottomSheetOrganizationFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/BottomSheetOrganizationFragment.java @@ -40,7 +40,7 @@ public class BottomSheetOrganizationFragment extends BottomSheetDialogFragment { bottomSheetOrganizationBinding.createTeam.setVisibility(View.GONE); } if(!permissions.isCanCreateRepository() || !permissions.isIsOwner()) { - bottomSheetOrganizationBinding.orgCreate.setVisibility(View.GONE); + bottomSheetOrganizationBinding.organizationHeadFrame.setVisibility(View.GONE); bottomSheetOrganizationBinding.orgCreateSection.setVisibility(View.GONE); bottomSheetOrganizationBinding.orgDivider.setVisibility(View.GONE); } diff --git a/app/src/main/java/org/mian/gitnex/fragments/BottomSheetSingleIssueFragment.java b/app/src/main/java/org/mian/gitnex/fragments/BottomSheetSingleIssueFragment.java index f2c80ce2..f6431ac9 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/BottomSheetSingleIssueFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/BottomSheetSingleIssueFragment.java @@ -84,9 +84,7 @@ public class BottomSheetSingleIssueFragment extends BottomSheetDialogFragment { if(issue.getIssueType().equalsIgnoreCase("Pull")) { - binding.editIssue.setText(R.string.editPrText); - binding.copyIssueUrl.setText(R.string.copyPrUrlText); - binding.shareIssue.setText(R.string.sharePr); + binding.editIssue.setText(R.string.menuEditText); boolean canPushPullSource = issue.getPullRequest().getHead().getRepo().getPermissions().isPush(); if(issue.getPullRequest().isMerged() || issue.getIssue().getState().equals("closed")) { @@ -198,13 +196,16 @@ public class BottomSheetSingleIssueFragment extends BottomSheetDialogFragment { dismiss(); }); + if(issue.getIssueType().equalsIgnoreCase("pull")) { + binding.bottomSheetHeader.setText(R.string.pullRequest); + } + if(issue.getIssue().getState().equals("open")) { // close issue if(!userIsCreator && !canPush) { binding.closeIssue.setVisibility(View.GONE); - binding.dividerCloseReopenIssue.setVisibility(View.GONE); } else if(issue.getIssueType().equalsIgnoreCase("Pull")) { - binding.closeIssue.setText(R.string.closePr); + binding.closeIssue.setText(R.string.close); } binding.closeIssue.setOnClickListener(closeSingleIssue -> { IssueActions.closeReopenIssue(ctx, "closed", issue); @@ -213,16 +214,10 @@ public class BottomSheetSingleIssueFragment extends BottomSheetDialogFragment { } else if(issue.getIssue().getState().equals("closed")) { if(userIsCreator || canPush) { - if(issue.getIssueType().equalsIgnoreCase("Pull")) { - binding.closeIssue.setText(R.string.reopenPr); - } - else { - binding.closeIssue.setText(R.string.reOpenIssue); - } + binding.closeIssue.setText(R.string.reopen); } else { binding.closeIssue.setVisibility(View.GONE); - binding.dividerCloseReopenIssue.setVisibility(View.GONE); } binding.closeIssue.setOnClickListener(closeSingleIssue -> { IssueActions.closeReopenIssue(ctx, "open", issue); @@ -259,10 +254,11 @@ public class BottomSheetSingleIssueFragment extends BottomSheetDialogFragment { binding.editIssue.setVisibility(View.GONE); binding.editLabels.setVisibility(View.GONE); binding.closeIssue.setVisibility(View.GONE); - binding.dividerCloseReopenIssue.setVisibility(View.GONE); binding.addRemoveAssignees.setVisibility(View.GONE); binding.commentReactionButtons.setVisibility(View.GONE); - binding.shareDivider.setVisibility(View.GONE); + binding.reactionDivider.setVisibility(View.GONE); + binding.bottomSheetHeaderFrame.setVisibility(View.GONE); + binding.issuePrDivider.setVisibility(View.GONE); } return binding.getRoot(); diff --git a/app/src/main/res/layout/bottom_sheet_admin_users.xml b/app/src/main/res/layout/bottom_sheet_admin_users.xml index 0b692d7e..912c5625 100644 --- a/app/src/main/res/layout/bottom_sheet_admin_users.xml +++ b/app/src/main/res/layout/bottom_sheet_admin_users.xml @@ -19,9 +19,9 @@ android:orientation="vertical"> @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -52,9 +52,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -36,9 +36,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ - - - - - - - - - - - - - - - - - - - + android:padding="8dp" + android:orientation="vertical"> - + + + + + android:layout_height="match_parent" + app:flexWrap="wrap" + app:alignItems="stretch" + android:padding="8dp" + app:alignContent="stretch" > + + + + + + + + + + + + + + + + + + + + + + - + android:layout_height="match_parent" + app:flexWrap="wrap" + app:alignItems="stretch" + android:padding="8dp" + app:alignContent="stretch" > + + + + + + diff --git a/app/src/main/res/layout/bottom_sheet_tag_in_list.xml b/app/src/main/res/layout/bottom_sheet_tag_in_list.xml index 005d3012..f0d95994 100644 --- a/app/src/main/res/layout/bottom_sheet_tag_in_list.xml +++ b/app/src/main/res/layout/bottom_sheet_tag_in_list.xml @@ -19,9 +19,9 @@ android:layout_height="wrap_content"> @@ -37,9 +37,9 @@ @@ -37,9 +37,9 @@ Branches Collaborators Pull Requests + Pull Request Size Default Branch @@ -499,6 +500,7 @@ Organization Add / Remove Download + Reopen Explore users @@ -522,8 +524,6 @@ Token is required Deleted Fork - Edit Pull Request - Copy Pull Request URL Edit Pull Request #%1$s Pull Request updated %1$s Files Changed @@ -531,7 +531,6 @@ Update Pull Request Show Changed Files Merge Pull Request - Delete head branch Branch deleted successfully Could not delete branch Branch does not exist @@ -563,7 +562,6 @@ Size Share Issue - Share Pull Request Share Repository Create Repository Commits @@ -739,8 +737,6 @@ Rebase Select Update Strategy - Close Pull Request - Reopen Pull Request Avatar Tags Releases/Tags