github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

CSRF token on login #998

New Issue
Closed
opened 2025-11-02 03:44:39 -06:00 by GiteaMirror · 6 comments
GiteaMirror commented 2025-11-02 03:44:39 -06:00
Owner
Copy Link

Originally created by @daviian on GitHub (Aug 24, 2017).

  • Gitea version (or commit ref): f61a1d21
  • Git version: 2.13.3
  • Operating system: Mac OS X
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

After discussion in https://github.com/go-gitea/gitea/pull/2363#pullrequestreview-58278319 I checked if login is validating CSRF token. And it does not.
As opinions differ I want to start a discussion about the necessity of a token validation for login request.

A research lead me to https://stackoverflow.com/questions/6412813/do-login-forms-need-tokens-against-csrf-attacks/15350123#15350123, the guy describes a scenario in which not validating the csrf token on login page is used for an attack on data privacy.

What's your opinion on this guys? IMO I would add token validation for login.

Originally created by @daviian on GitHub (Aug 24, 2017). - Gitea version (or commit ref): f61a1d21 - Git version: 2.13.3 - Operating system: Mac OS X - Database (use `[x]`): - [x] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant ## Description After discussion in https://github.com/go-gitea/gitea/pull/2363#pullrequestreview-58278319 I checked if login is validating CSRF token. And it does not. As opinions differ I want to start a discussion about the necessity of a token validation for login request. A research lead me to https://stackoverflow.com/questions/6412813/do-login-forms-need-tokens-against-csrf-attacks/15350123#15350123, the guy describes a scenario in which not validating the csrf token on login page is used for an attack on data privacy. What's your opinion on this guys? IMO I would add token validation for login.
GiteaMirror added the type/proposal label 2025-11-02 03:44:39 -06:00
GiteaMirror commented 2025-11-02 03:44:40 -06:00
Author
Owner
Copy Link

@daviian commented on GitHub (Sep 30, 2017):

Anyone against a CSRF token on login?
If not I would create a PR for this,

@daviian commented on GitHub (Sep 30, 2017): Anyone against a CSRF token on login? If not I would create a PR for this,
GiteaMirror commented 2025-11-02 03:44:40 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Oct 7, 2017):

@daviian maybe because drone depends on that?

@lunny commented on GitHub (Oct 7, 2017): @daviian maybe because drone depends on that?
GiteaMirror commented 2025-11-02 03:44:41 -06:00
Author
Owner
Copy Link

@daviian commented on GitHub (Oct 7, 2017):

@lunny Any reason why the drone should depend on that?

@daviian commented on GitHub (Oct 7, 2017): @lunny Any reason why the drone should depend on that?
GiteaMirror commented 2025-11-02 03:44:41 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Oct 7, 2017):

@daviian since Gitea didn't implement OAuth2 provider. But drone need login with gitea user & password.

@lunny commented on GitHub (Oct 7, 2017): @daviian since Gitea didn't implement OAuth2 provider. But drone need login with gitea user & password.
GiteaMirror commented 2025-11-02 03:44:41 -06:00
Author
Owner
Copy Link

@daviian commented on GitHub (Oct 7, 2017):

@lunny When does the drone need direct login to gitea, except when running integration tests? And integration tests already send csrf token on login, although the token is not validated.

@daviian commented on GitHub (Oct 7, 2017): @lunny When does the drone need direct login to gitea, except when running integration tests? And integration tests already send csrf token on login, although the token is not validated.
GiteaMirror commented 2025-11-02 03:44:41 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Sep 7, 2020):

Gitea has implemented OAuth2 provider

@6543 commented on GitHub (Sep 7, 2020): Gitea **has** implemented OAuth2 provider
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#998
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?