Marking pr as manually merged doens't do anything #9878

New Issue

GiteaMirror · 2025-11-02T08:52:06-06:00

GiteaMirror commented

2025-11-02 08:52:06 -06:00

Originally created by @tautf on GitHub (Nov 23, 2022).

Description

I merged a pull request the normal way with clicking "Merge". During the "merge process" i left the page which caused this behaviour.

Branches are merged together
PR still open and unmergeable because branch is already included in target
Clicking "Manual Merge" does nothing
Im not able to close this PR (with this button, of course with the "Close" functionality")

Maybe dont have "Manual Merge" as a button if nothing happens.

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

none, integrated

Operating System

Windows Server 2019

How are you running Gitea?

Windows amd64 executable

Database

PostgreSQL

Originally created by @tautf on GitHub (Nov 23, 2022). ### Description I merged a pull request the normal way with clicking "Merge". During the "merge process" i left the page which caused this behaviour. - Branches are merged together - PR still open and unmergeable because branch is already included in target ![Bildschirmfoto 2022-11-23 um 11 52 43 AM](https://user-images.githubusercontent.com/18403881/203528997-e2f2f963-927d-4d9e-80d7-c32b30907a17.png) - Clicking "Manual Merge" does nothing - Im not able to close this PR (with this button, of course with the "Close" functionality") Maybe dont have "Manual Merge" as a button if nothing happens. ### Gitea Version 1.17.2 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version none, integrated ### Operating System Windows Server 2019 ### How are you running Gitea? Windows amd64 executable ### Database PostgreSQL

GiteaMirror added the type/bug label 2025-11-02 08:52:06 -06:00

GiteaMirror closed this issue

2025-11-02 08:52:06 -06:00

GiteaMirror commented

2025-11-02 08:52:06 -06:00

@a-n-dokuchaev commented on GitHub (Jan 9, 2023):

Help us, please. Last 2 of 50 PRs with this issue.

@a-n-dokuchaev commented on GitHub (Jan 9, 2023): Help us, please. Last 2 of 50 PRs with this issue.

GiteaMirror commented

2025-11-02 08:52:07 -06:00

@ghost commented on GitHub (Jan 22, 2023):

I can reproduce this issue on Gitea 1.19.0+dev-341-geb793c336 logs don't seem to be very interesting, but I can post them if you want to. I was also using the Tor Browser, in case that makes any difference.

@ghost commented on GitHub (Jan 22, 2023): I can reproduce this issue on `Gitea 1.19.0+dev-341-geb793c336` logs don't seem to be very interesting, but I can post them if you want to. I was also using the Tor Browser, in case that makes any difference.

GiteaMirror commented

2025-11-02 08:52:07 -06:00

@wxiaoguang commented on GitHub (Feb 20, 2023):

Sorry I missed this issue.

There are 2 problems here:

When the browser leaves the page, the connection is disconnected and Gitea may not finish its work (especially the necessary database updating), so the PR is left open. This problem should be fixed by other approaches.
The Manually Merged form is broken, it will be fixed by #23015

@wxiaoguang commented on GitHub (Feb 20, 2023): Sorry I missed this issue. There are 2 problems here: 1. When the browser leaves the page, the connection is disconnected and Gitea may not finish its work (especially the necessary database updating), so the PR is left open. This problem should be fixed by other approaches. 2. The Manually Merged form is broken, it will be fixed by #23015

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#9878