github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Jump to Line Fragment Should Ignore Line Numbers < 1 #9804

New Issue
Closed
opened 2025-11-02 08:50:04 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 08:50:04 -06:00
Owner
Copy Link

Originally created by @r10r on GitHub (Nov 8, 2022).

Description

When calling https://codeberg.org/Codeberg/gitea/src/branch/codeberg-1.17/README.md?display=source#L0 it is internally redirected to https://codeberg.org/Codeberg/gitea/src/branch/codeberg-1.17/README.md?display=source#undefined
which leads to the following javascript error:

JavaScript error: Uncaught TypeError: Cannot read properties of undefined (reading 'length') (https://codeberg.org/assets/js/index.js?v=1.17.3~87-ge4b8341 @ 83:11976). Open browser console to see more details.

Maybe line numbers < 1 can simply be ignored as github does:

https://github.com/go-gitea/gitea/blob/main/README.md?plain=1#L0

This would fix issues with links from external systems that don't check the line number properly.

Gitea Version

1.17.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

helm chart

Database

PostgreSQL

Originally created by @r10r on GitHub (Nov 8, 2022). ### Description When calling https://codeberg.org/Codeberg/gitea/src/branch/codeberg-1.17/README.md?display=source#L0 it is internally redirected to https://codeberg.org/Codeberg/gitea/src/branch/codeberg-1.17/README.md?display=source#undefined which leads to the following javascript error: >JavaScript error: Uncaught TypeError: Cannot read properties of undefined (reading 'length') (https://codeberg.org/assets/js/index.js?v=1.17.3~87-ge4b8341 @ 83:11976). Open browser console to see more details. Maybe line numbers < 1 can simply be ignored as github does: https://github.com/go-gitea/gitea/blob/main/README.md?plain=1#L0 This would fix issues with links from external systems that don't check the line number properly. ### Gitea Version 1.17.3 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? helm chart ### Database PostgreSQL
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 08:50:04 -06:00
GiteaMirror commented 2025-11-02 08:50:05 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Nov 8, 2022):

Reproduces on try.gitea.io as well:

https://try.gitea.io/silverwind/symlink-test/src/branch/master/test.txt#L0

Hitting the back button on the page produces more errors.

@silverwind commented on GitHub (Nov 8, 2022): Reproduces on try.gitea.io as well: https://try.gitea.io/silverwind/symlink-test/src/branch/master/test.txt#L0 Hitting the back button on the page produces more errors.
GiteaMirror commented 2025-11-02 08:50:05 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Nov 8, 2022):

https://github.com/go-gitea/gitea/pull/21728

@silverwind commented on GitHub (Nov 8, 2022): https://github.com/go-gitea/gitea/pull/21728
GiteaMirror commented 2025-11-02 08:50:05 -06:00
Author
Owner
Copy Link

@r10r commented on GitHub (Nov 8, 2022):

@silverwind Thanks for addressing this so quickly!

@r10r commented on GitHub (Nov 8, 2022): @silverwind Thanks for addressing this so quickly!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#9804
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?