?go-get=1 not working if REQUIRE_SIGNIN_VIEW = true #979

Closed
opened 2025-11-02 03:44:10 -06:00 by GiteaMirror · 7 comments
Owner

Originally created by @sulliwane on GitHub (Aug 18, 2017).

  • Gitea version (or commit ref): 1.1.3
  • Operating system: Ubuntu server 16.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No, I can't change the app.ini settings
    • Not relevant

Description

?go-get=1 not working on repo url, if REQUIRE_SIGNIN_VIEW = true in app.ini, because redirected to login page

Originally created by @sulliwane on GitHub (Aug 18, 2017). - Gitea version (or commit ref): 1.1.3 - Operating system: Ubuntu server 16.04 - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [x] No, I can't change the app.ini settings - [ ] Not relevant ## Description ?go-get=1 not working on repo url, if ```REQUIRE_SIGNIN_VIEW = true``` in ```app.ini```, because redirected to login page
GiteaMirror added the type/question label 2025-11-02 03:44:10 -06:00
Author
Owner

@strk commented on GitHub (Aug 18, 2017):

What would you expect to happen ?
Doesn't the ?go-get=1 response count as view ?

@strk commented on GitHub (Aug 18, 2017): What would you expect to happen ? Doesn't the `?go-get=1` response count as `view` ?
Author
Owner

@sulliwane commented on GitHub (Aug 18, 2017):

I have my login/password stored in a ~/.netrc, which let me go get my.gitea.com/private/repo <- PRIVATE REPO.

The problem is that, if REQUIRE_SIGNIN_VIEW = true is enabled, the behavior described above doesn't work anymore.

I'm not 100% sure about the meaning of the REQUIRE_SIGNIN_VIEW option, but I think it should not make go get private/repo stop working...

Is it the same issue as this one : https://github.com/gogits/gogs/issues/1878 ?

@sulliwane commented on GitHub (Aug 18, 2017): I have my **login/password** stored in a ```~/.netrc```, which let me ```go get my.gitea.com/private/repo``` <- PRIVATE REPO. The problem is that, if ```REQUIRE_SIGNIN_VIEW = true``` is enabled, the behavior described above doesn't work anymore. I'm not 100% sure about the meaning of the ```REQUIRE_SIGNIN_VIEW``` option, but I think it should not make ```go get private/repo``` stop working... Is it the same issue as this one : https://github.com/gogits/gogs/issues/1878 ?
Author
Owner

@strk commented on GitHub (Aug 18, 2017):

It looks like this was fixed in Gogs with this commit:
e33c714073

Do you feel like opening a pull-requests porting it here ?
Best if it includes an automated test

@strk commented on GitHub (Aug 18, 2017): It looks like this was fixed in Gogs with this commit: https://github.com/gogits/gogs/commit/e33c714073cc65f814bacf604a84cd2741951afa Do you feel like opening a pull-requests porting it here ? Best if it includes an automated test
Author
Owner

@lafriks commented on GitHub (Aug 18, 2017):

I think @bkcsoft fixed this in gitea master also

@lafriks commented on GitHub (Aug 18, 2017): I think @bkcsoft fixed this in gitea master also
Author
Owner

@lafriks commented on GitHub (Aug 18, 2017):

I think this is fixed with #2010

@lafriks commented on GitHub (Aug 18, 2017): I think this is fixed with #2010
Author
Owner

@bkcsoft commented on GitHub (Aug 19, 2017):

Yeah it's fixed in #2010, though hasn't been backported to 1.1.x

@bkcsoft commented on GitHub (Aug 19, 2017): Yeah it's fixed in #2010, though hasn't been backported to 1.1.x
Author
Owner

@lafriks commented on GitHub (Aug 19, 2017):

I'm closing issue than. It will be fixed with 1.2.0 release

@lafriks commented on GitHub (Aug 19, 2017): I'm closing issue than. It will be fixed with 1.2.0 release
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#979