Include NOREPLY address when parsing SSH signature #9787

New Issue

GiteaMirror · 2025-11-02T08:49:38-06:00

GiteaMirror commented

2025-11-02 08:49:38 -06:00

Originally created by @markdascher on GitHub (Nov 5, 2022).

Feature Description

SSH signatures are only recognized on commits with real email addresses:

6fe756dc93/models/asymkey/ssh_key_commit_verification.go (L39-L45)

For comparison, GPG signatures include NOREPLY logic already:

0ebb45cfe7/models/asymkey/gpg_key.go (L272-L274)

Should there be similar logic for SSH signatures? Otherwise I'd need to reveal my real email address in order to use SSH signatures.

Screenshots

No response

Originally created by @markdascher on GitHub (Nov 5, 2022). ### Feature Description SSH signatures are only recognized on commits with real email addresses: https://github.com/go-gitea/gitea/blob/6fe756dc93f3704079d942f0a29966b61aed8aec/models/asymkey/ssh_key_commit_verification.go#L39-L45 For comparison, GPG signatures include NOREPLY logic already: https://github.com/go-gitea/gitea/blob/0ebb45cfe7606adf021ad359d6fbfcefc54360a5/models/asymkey/gpg_key.go#L272-L274 Should there be similar logic for SSH signatures? Otherwise I'd need to reveal my real email address in order to use SSH signatures. ### Screenshots _No response_

GiteaMirror added the type/enhancement type/proposal labels 2025-11-02 08:49:38 -06:00

GiteaMirror closed this issue

2025-11-02 08:49:38 -06:00

GiteaMirror commented

2025-11-02 08:49:39 -06:00

@brian6932 commented on GitHub (May 9, 2025):

This behavior doesn't match the default behavior of platforms like GitHub, GitLab, and Codeberg, it adds a lot of undocumented confusion, and forces you to expose email addresses. Forgejo, and by extension Codeberg have already patched this behavior. The whole UI for email addresses on Gitea, is a complete mess. Having to swap between the /user/settings and /user/settings/account pages, just to simply manage your emails is absurd. GitHub (/settings/emails) and GitLab (/-/profile/emails) have dedicated tabs for email management. GitLab's one isn't very good, as a few email specific settings are still under /-/user_settings/profile, but it's still miles better than Gitea in this regard.

Should there be similar logic for SSH signatures? Otherwise I'd need to reveal my real email address in order to use SSH signatures.

Yes.

@brian6932 commented on GitHub (May 9, 2025): This behavior doesn't match the default behavior of platforms like GitHub, GitLab, and Codeberg, it adds a lot of undocumented confusion, and forces you to expose email addresses. Forgejo, and by extension Codeberg have already [patched this behavior](https://codeberg.org/forgejo/forgejo/pulls/1754). The whole UI for email addresses on Gitea, is a complete mess. Having to swap between the `/user/settings` and `/user/settings/account` pages, just to simply manage your emails is absurd. GitHub (`/settings/emails`) and GitLab (`/-/profile/emails`) have dedicated tabs for email management. GitLab's one isn't very good, as a few email specific settings are still under `/-/user_settings/profile`, but it's still miles better than Gitea in this regard. > Should there be similar logic for SSH signatures? Otherwise I'd need to reveal my real email address in order to use SSH signatures. Yes.

GiteaMirror commented

2025-11-02 08:49:39 -06:00

@lunny commented on GitHub (Jul 11, 2025):

I sent #35043 to allow noreply email address can be used when signing with ssh key.

@lunny commented on GitHub (Jul 11, 2025): I sent #35043 to allow noreply email address can be used when signing with ssh key.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#9787