draft releases: update & delete events being sent while creation dont #9688

New Issue

GiteaMirror · 2025-11-02T08:46:39-06:00

GiteaMirror commented

2025-11-02 08:46:39 -06:00

Originally created by @Mai-Lapyst on GitHub (Oct 13, 2022).

Description

Pretty much what the title says: while creation events are not being sent when creating an release marked as draft, update and deletion events are, which seems counter intuitive; it should either be all sent or non of them for draft releases.

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

linux

How are you running Gitea?

Official binary release

Database

MySQL

Originally created by @Mai-Lapyst on GitHub (Oct 13, 2022). ### Description Pretty much what the title says: while creation events are not being sent when creating an release marked as draft, update and deletion events are, which seems counter intuitive; it should either be all sent or non of them for draft releases. ### Gitea Version 1.17.2 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System linux ### How are you running Gitea? Official binary release ### Database MySQL

GiteaMirror added the type/bug label 2025-11-02 08:46:39 -06:00

GiteaMirror closed this issue

2025-11-02 08:46:39 -06:00

GiteaMirror commented

2025-11-02 08:46:39 -06:00

@delvh commented on GitHub (Oct 25, 2022):

Fix has been reverted for further discussion.

@delvh commented on GitHub (Oct 25, 2022): Fix has been reverted for further discussion.

GiteaMirror commented

2025-11-02 08:46:40 -06:00

@lunny commented on GitHub (Jul 27, 2023):

~~I lost the information about why the PR has been reverted.~~ OK. Got from #21451

We can have clarify about the logic, my proposal is

1 Creating a non-draft release -> trigger CreateRelease event
2 Creating a draft release -> no event
3 Convert a draft to a non-draft -> trigger CreateRelease event
4 Convert a non-draft to a draft -> trigger DeleteRelease event
5 Edit a non-draft release -> trigger EditRelease event
6 Edit a draft release -> no event
7 DELETE a non-draft release -> trigger DeleteRelease event
8 DELETE a draft release -> no event

@lunny commented on GitHub (Jul 27, 2023): ~I lost the information about why the PR has been reverted.~ OK. Got from #21451 We can have clarify about the logic, my proposal is 1 Creating a non-draft release -> trigger `CreateRelease` event 2 Creating a draft release -> no event 3 Convert a draft to a non-draft -> trigger `CreateRelease` event 4 Convert a non-draft to a draft -> trigger `DeleteRelease` event 5 Edit a non-draft release -> trigger `EditRelease` event 6 Edit a draft release -> no event 7 DELETE a non-draft release -> trigger `DeleteRelease` event 8 DELETE a draft release -> no event

GiteaMirror commented

2025-11-02 08:46:40 -06:00

@wxiaoguang commented on GitHub (Jul 27, 2023):

Everything in #21451

@wxiaoguang commented on GitHub (Jul 27, 2023): Everything in #21451

GiteaMirror commented

2025-11-02 08:46:40 -06:00

@lunny commented on GitHub (Mar 25, 2024):

I think this has been resolveded by #29008

@lunny commented on GitHub (Mar 25, 2024): I think this has been resolveded by #29008

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#9688