github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-11 17:46:29 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

OAuth refresh handler should require client authentication #9676

New Issue
Closed
opened 2025-11-02 08:46:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 08:46:20 -06:00
Owner
Copy Link

Originally created by @hickford on GitHub (Oct 12, 2022).

The OAuth authorization_code handler authenticates the client by validating the client secret 9862936ed3/routers/web/auth/oauth.go (L703-L713)

According to the OAuth spec https://datatracker.ietf.org/doc/html/rfc6749#section-6 , this should also happen when "Refreshing an Access Token"

The authorization server MUST ... require client authentication for confidential clients

but handleRefreshToken doesn't do this 9862936ed3/routers/web/auth/oauth.go (L658)

Originally created by @hickford on GitHub (Oct 12, 2022). The OAuth authorization_code handler authenticates the client by validating the client secret https://github.com/go-gitea/gitea/blob/9862936ed3f488896adb6ddc29eb25ef15185c41/routers/web/auth/oauth.go#L703-L713 According to the OAuth spec https://datatracker.ietf.org/doc/html/rfc6749#section-6 , this should also happen when "Refreshing an Access Token" > The authorization server MUST ... require client authentication for confidential clients but handleRefreshToken doesn't do this https://github.com/go-gitea/gitea/blob/9862936ed3f488896adb6ddc29eb25ef15185c41/routers/web/auth/oauth.go#L658
GiteaMirror added the type/bug label 2025-11-02 08:46:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#9676
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?