github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 12:46:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

OAuth module missing special handling for loopback redirect URI #9626

New Issue
Closed
opened 2025-11-02 08:44:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 08:44:50 -06:00
Owner
Copy Link

Originally created by @hickford on GitHub (Sep 28, 2022).

OAuth RFC https://datatracker.ietf.org/doc/html/rfc8252#section-7.3 describes special handling for loopback redirect URIs, in particular that the port need not match.

The authorization server MUST allow any port to be specified at the
time of the request for loopback IP redirect URIs, to accommodate
clients that obtain an available ephemeral port from the operating
system at the time of the request.

This is vital for local apps, but the behaviour is missing in Gitea.
Relevant code 5a3b9ac875/models/auth/oauth2.go (L58-L60)

GitHub implements this behaviour https://docs.github.com/en/developers/apps/building-oauth-apps/authorizing-oauth-apps#localhost-redirect-urls

The redirect_uri does not need to match the port specified in the callback url for the app.

Originally created by @hickford on GitHub (Sep 28, 2022). OAuth RFC https://datatracker.ietf.org/doc/html/rfc8252#section-7.3 describes special handling for loopback redirect URIs, in particular that **the port need not match**. > **The authorization server MUST allow any port to be specified at the time of the request for loopback IP redirect URIs**, to accommodate clients that obtain an available ephemeral port from the operating system at the time of the request. This is vital for local apps, but the behaviour is missing in Gitea. Relevant code https://github.com/go-gitea/gitea/blob/5a3b9ac875b06e0810aa2100ee0caae4efe0b4ce/models/auth/oauth2.go#L58-L60 GitHub implements this behaviour https://docs.github.com/en/developers/apps/building-oauth-apps/authorizing-oauth-apps#localhost-redirect-urls > The redirect_uri does not need to match the port specified in the callback url for the app.
GiteaMirror added the type/bug label 2025-11-02 08:44:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#9626
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?