github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 12:46:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Package tests (as run by make test-sqlite) do not clean up after themselves #9498

New Issue
Closed
opened 2025-11-02 08:40:46 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 08:40:46 -06:00
Owner
Copy Link

Originally created by @zeripath on GitHub (Sep 1, 2022).

Description

The package tests are not correctly cleaning up after running leading to incorrect reports of errors if make test-sqlite is run again.

--- FAIL: TestPackagePub (0.15s)
    testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-36] router: completed GET /user/settings/applications for , 200 OK in 1.8ms @ setting/applications.go:24(setting.Applications)
    testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-37] router: completed POST /user/settings/applications for , 303 See Other in 18.9ms @ setting/applications.go:34(setting.ApplicationsPost)
    testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-38] router: completed GET /user/settings/applications for , 200 OK in 1.9ms @ setting/applications.go:24(setting.Applications)
    --- FAIL: TestPackagePub/Upload (0.06s)
        testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-39] router: completed GET /api/packages/user2/pub/api/packages/versions/new for , 401 Unauthorized in 0.2ms @ packages/api.go:34(packages.reqPackageAccess)
        testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-40] router: completed GET /api/packages/user2/pub/api/packages/versions/new for , 200 OK in 16.7ms @ pub/pub.go:147(pub.RequestUpload)
        testlogger.go:78: 2022/09/01 17:50:40 ...packages/packages.go:161:createPackageAndVersion() [E] [6310e2e0-41] Error inserting package: Package version already exists
        testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-41] router: completed POST http://localhost:3003/api/packages/user2/pub/api/packages/versions/new/upload for , 400 Bad Request in 16.0ms @ pub/pub.go:160(pub.UploadPackageFile)
        api_packages_pub_test.go:92: 
            	Error Trace:	/home/andrew/src/go/gitea/integration_test.go:506
            	            				/home/andrew/src/go/gitea/api_packages_pub_test.go:92
            	            				/home/andrew/src/go/gitea/api_packages_pub_test.go:95
            	Error:      	Not equal: 
            	            	expected: 204
            	            	actual  : 400
            	Test:       	TestPackagePub/Upload
            	Messages:   	Request: POST http://localhost:3003/api/packages/user2/pub/api/packages/versions/new/upload
        api_packages_pub_test.go:92: Response: {"error":{"code":"Bad Request","message":"Package version already exists"}}

Gitea Version

d74390ee39 (if not earlier)

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

make test-sqlite

Database

No response

Originally created by @zeripath on GitHub (Sep 1, 2022). ### Description The package tests are not correctly cleaning up after running leading to incorrect reports of errors if `make test-sqlite` is run again. ``` --- FAIL: TestPackagePub (0.15s) testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-36] router: completed GET /user/settings/applications for , 200 OK in 1.8ms @ setting/applications.go:24(setting.Applications) testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-37] router: completed POST /user/settings/applications for , 303 See Other in 18.9ms @ setting/applications.go:34(setting.ApplicationsPost) testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-38] router: completed GET /user/settings/applications for , 200 OK in 1.9ms @ setting/applications.go:24(setting.Applications) --- FAIL: TestPackagePub/Upload (0.06s) testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-39] router: completed GET /api/packages/user2/pub/api/packages/versions/new for , 401 Unauthorized in 0.2ms @ packages/api.go:34(packages.reqPackageAccess) testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-40] router: completed GET /api/packages/user2/pub/api/packages/versions/new for , 200 OK in 16.7ms @ pub/pub.go:147(pub.RequestUpload) testlogger.go:78: 2022/09/01 17:50:40 ...packages/packages.go:161:createPackageAndVersion() [E] [6310e2e0-41] Error inserting package: Package version already exists testlogger.go:78: 2022/09/01 17:50:40 ...eb/routing/logger.go:99:func1() [I] [6310e2e0-41] router: completed POST http://localhost:3003/api/packages/user2/pub/api/packages/versions/new/upload for , 400 Bad Request in 16.0ms @ pub/pub.go:160(pub.UploadPackageFile) api_packages_pub_test.go:92: Error Trace: /home/andrew/src/go/gitea/integration_test.go:506 /home/andrew/src/go/gitea/api_packages_pub_test.go:92 /home/andrew/src/go/gitea/api_packages_pub_test.go:95 Error: Not equal: expected: 204 actual : 400 Test: TestPackagePub/Upload Messages: Request: POST http://localhost:3003/api/packages/user2/pub/api/packages/versions/new/upload api_packages_pub_test.go:92: Response: {"error":{"code":"Bad Request","message":"Package version already exists"}} ``` ### Gitea Version d74390ee39d84b24e103a049217817e22dc391d4 (if not earlier) ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? make test-sqlite ### Database _No response_
GiteaMirror added the topic/packagestype/testingtype/bug labels 2025-11-02 08:40:46 -06:00
GiteaMirror commented 2025-11-02 08:40:47 -06:00
Author
Owner
Copy Link

@KN4CK3R commented on GitHub (Sep 6, 2022):

Are the integration tests intended to run multiple times without cleaning the used directory? I use rm -R -f integrations/gitea-integration-sqlite/ && make test-sqlite to run the tests.

@KN4CK3R commented on GitHub (Sep 6, 2022): Are the integration tests intended to run multiple times without cleaning the used directory? I use `rm -R -f integrations/gitea-integration-sqlite/ && make test-sqlite` to run the tests.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/packages type/bug type/testing
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#9498
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?