Too many menus on settings page #944

@bkcsoft commented on GitHub (Aug 8, 2017):

OpenID/External seems like we could merge them. 2FA should go under Pasword. Avatar under Profile.

@bkcsoft commented on GitHub (Aug 8, 2017): OpenID/External seems like we could merge them. 2FA should go under Pasword. Avatar under Profile.

GiteaMirror commented

@lafriks commented on GitHub (Aug 8, 2017):

We could also merge SSH / GPG Keys and Applications into "Keys / Tokens"

@lafriks commented on GitHub (Aug 8, 2017): We could also merge SSH / GPG Keys and Applications into "Keys / Tokens"

GiteaMirror commented

@pgaskin commented on GitHub (Aug 8, 2017):

Merge Profile and Avatar into Profile

@pgaskin commented on GitHub (Aug 8, 2017): Merge Profile and Avatar into Profile

GiteaMirror commented

@lunny commented on GitHub (Sep 14, 2017):

should be a part of #1346

@lunny commented on GitHub (Sep 14, 2017): should be a part of #1346

GiteaMirror commented

@daviian commented on GitHub (Oct 16, 2017):

Unfortunately I was to late to review #2695
Would like to rename "Security" to "Account" and add "Delete Account" as well.

@daviian commented on GitHub (Oct 16, 2017): Unfortunately I was to late to review #2695 Would like to rename "Security" to "Account" and add "Delete Account" as well.

GiteaMirror commented

@lafriks commented on GitHub (Oct 16, 2017):

@daviian Delete account could be moved into Profile tab

@lafriks commented on GitHub (Oct 16, 2017): @daviian Delete account could be moved into `Profile` tab

GiteaMirror commented

@daviian commented on GitHub (Oct 16, 2017):

@lafriks Profile is more like the publicly visible part of your account. Whereas Account holds the technical parts of it.

@daviian commented on GitHub (Oct 16, 2017): @lafriks Profile is more like the publicly visible part of your account. Whereas `Account` holds the technical parts of it.

GiteaMirror commented

@lunny commented on GitHub (Oct 16, 2017):

Rename Email Addresses to Emails ?

@lunny commented on GitHub (Oct 16, 2017): Rename `Email Addresses` to `Emails` ?

GiteaMirror commented

@daviian commented on GitHub (Oct 16, 2017):

@lunny I think this would be great to put under my proposed "Account" tab

@daviian commented on GitHub (Oct 16, 2017): @lunny I think this would be great to put under my proposed "Account" tab

GiteaMirror commented

@lunny commented on GitHub (Oct 16, 2017):

@daviian Yes, your idea is better.

@lunny commented on GitHub (Oct 16, 2017): @daviian Yes, your idea is better.

GiteaMirror commented

@renothing commented on GitHub (Dec 3, 2017):

I think left sidebar is better as original. top menu is tooo crowded

@renothing commented on GitHub (Dec 3, 2017): I think left sidebar is better as original. top menu is tooo crowded

GiteaMirror commented

@pgaskin commented on GitHub (Dec 3, 2017):

@renothing left menu does not work well on narrow screens. Also, as this issue says, there are too many menus (many can be combined).

@pgaskin commented on GitHub (Dec 3, 2017): @renothing left menu does not work well on narrow screens. Also, as this issue says, there are too many menus (many can be combined).

GiteaMirror commented

@renothing commented on GitHub (Dec 3, 2017):

flexible.js maybe usefull
top menu also works worse on mobile screen

@renothing commented on GitHub (Dec 3, 2017): flexible.js maybe usefull top menu also works worse on mobile screen

GiteaMirror commented

@daviian commented on GitHub (May 2, 2018):

I'll give it a shot and prepare an alternative menu / subpage structure for the settings page before actually implementing it.

@daviian commented on GitHub (May 2, 2018): I'll give it a shot and prepare an alternative menu / subpage structure for the settings page before actually implementing it.

GiteaMirror commented

@daviian commented on GitHub (May 2, 2018):

So I came up with following structure:

Profile
- Avatar
- Public Profile
Account
- Email Addresses
- Password
- Delete Account
Security
- TOTP
- OpenID
- Access Tokens
- Linked Accounts
SSH / GPG Keys
Organizations
Repositories

First level represents the menu items. Second level refers to items that are moved onto that page.

@daviian commented on GitHub (May 2, 2018): So I came up with following structure: - Profile - Avatar - Public Profile - Account - Email Addresses - Password - Delete Account - Security - TOTP - OpenID - Access Tokens - Linked Accounts - SSH / GPG Keys - Organizations - Repositories First level represents the menu items. Second level refers to items that are moved onto that page. ![settings-menu](https://user-images.githubusercontent.com/5477981/39547718-af983c18-4e58-11e8-898f-48ce57a4b0a3.png)

GiteaMirror commented

@daviian commented on GitHub (May 4, 2018):

Any objection against above proposed menu readjustments?
Otherwise I'd love to create a PR.

@daviian commented on GitHub (May 4, 2018): Any objection against above proposed menu readjustments? Otherwise I'd love to create a PR.

GiteaMirror commented

@lafriks commented on GitHub (May 4, 2018):

LGTM :)

@lafriks commented on GitHub (May 4, 2018): LGTM :)

GiteaMirror commented

@TangentFoxy commented on GitHub (May 5, 2018):

@daviian Why have SSH / GPG separate from Security settings?

@TangentFoxy commented on GitHub (May 5, 2018): @daviian Why have SSH / GPG separate from Security settings?

GiteaMirror commented

@daviian commented on GitHub (May 5, 2018):

@Guard13007 At first I thought I move SSH / GPG Keys to Security as well, but hesitated because of the GPG Keys part as they don't have something todo with Security/Authentication.
But furthermore they have something in common with SSH Keys.
So I decided to keep them as they are. But I am open for discussion ;-)

@daviian commented on GitHub (May 5, 2018): @Guard13007 At first I thought I move SSH / GPG Keys to Security as well, but hesitated because of the GPG Keys part as they don't have something todo with Security/Authentication. But furthermore they have something in common with SSH Keys. So I decided to keep them as they are. But I am open for discussion ;-)

GiteaMirror commented

@renothing commented on GitHub (May 6, 2018):

I don't think current layout good enough still. Do not change for change, submenu need two steps for users, and horizontal layout crowded. if next a new option added, so will you add new subgroup again ??why don't change it back to sidebar menu like github or gitlab? it's simple and rational more than current.

@renothing commented on GitHub (May 6, 2018): I don't think current layout good enough still. Do not change for change, submenu need two steps for users, and horizontal layout crowded. if next a new option added, so will you add new subgroup again ??why don't change it back to sidebar menu like github or gitlab? it's simple and rational more than current.

GiteaMirror commented

@daviian commented on GitHub (May 6, 2018):

Oh I don't change for a change, I really think that some menu items should be bundled together no matter if the submenu is horizontal or vertical.
Also a vertical submenu doesn't minimize the steps for a user compared to the horizontal one.
For clarity, there won't be any dropdowns. Just that the sections move to that page.

@daviian commented on GitHub (May 6, 2018): Oh I don't change for a change, I really think that some menu items should be bundled together no matter if the submenu is horizontal or vertical. Also a vertical submenu doesn't minimize the steps for a user compared to the horizontal one. For clarity, there won't be any dropdowns. Just that the sections move to that page.

GiteaMirror commented

@TangentFoxy commented on GitHub (May 7, 2018):

@renothing Having a vertical menu is a big disadvantage for those who need to work with smaller screens.

@TangentFoxy commented on GitHub (May 7, 2018): @renothing Having a vertical menu is a big disadvantage for those who need to work with smaller screens.

GiteaMirror commented

@renothing commented on GitHub (May 8, 2018):

@Guard13007 I don't think these users are most common, will you use a mobile phone to work with github in most case? horizontal menu waste too much layout spaces

@renothing commented on GitHub (May 8, 2018): @Guard13007 I don't think these users are most common, will you use a mobile phone to work with github in most case? horizontal menu waste too much layout spaces

GiteaMirror commented

@TangentFoxy commented on GitHub (May 9, 2018):

So screw the minority because you don't like the look of something? The horizontal layout isn't that overcrowded, and the suggested re-arrangement would solve that problem easily without having to resort to sacrificing usability on smaller screens.

Also, I said nothing about mobile phones, I said smaller screens. That said, I do often need to check things on my phone as well, so yes, on a mobile phone is useful too.

@TangentFoxy commented on GitHub (May 9, 2018): So screw the minority because you don't like the look of something? The horizontal layout isn't that overcrowded, and the suggested re-arrangement would solve that problem easily without having to resort to sacrificing usability on smaller screens. Also, I said nothing about mobile phones, I said smaller screens. That said, I do often need to check things on my phone as well, so yes, on a mobile phone is useful too.

GiteaMirror commented