github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[1.17.0-rc1] LDAP Group Sync for organization teams issue with escaped characters in LDAP #9154

New Issue
Closed
opened 2025-11-02 08:30:53 -06:00 by GiteaMirror · 9 comments
GiteaMirror commented 2025-11-02 08:30:53 -06:00
Owner
Copy Link

Originally created by @gd197 on GitHub (Jun 30, 2022).

Description

in our company AD (LDAP) , members of a group object are described according to their DN in the form:
member=CN=NAME\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp
that is the exact extract from ldapsearch command on linux.
Unfortunately, the escaped coma (",") in the DN is not correctly managed by the synchronization task, all our users are managed that way
This lead to the following error log :
2022/06/30 15:43:12 ...dap/source_search.go:215:listLdapGroupMemberships() [E] [62bda870] Failed group search using filter[(member=CN=NAME\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp)]: LDAP Result Code 201 "Filter Compile Error": ldap: invalid characters for escape in filter: encoding/hex: invalid byte: U+002C ','

Gitea Version

1.17-RC1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

RHEL 7

How are you running Gitea?

Using package from release tab on github

Database

MySQL

Originally created by @gd197 on GitHub (Jun 30, 2022). ### Description in our company AD (LDAP) , members of a group object are described according to their DN in the form: `member=CN=NAME\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp` that is the exact extract from ldapsearch command on linux. Unfortunately, the escaped coma ("\,") in the DN is not correctly managed by the synchronization task, all our users are managed that way This lead to the following error log : `2022/06/30 15:43:12 ...dap/source_search.go:215:listLdapGroupMemberships() [E] [62bda870] Failed group search using filter[(member=CN=NAME\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp)]: LDAP Result Code 201 "Filter Compile Error": ldap: invalid characters for escape in filter: encoding/hex: invalid byte: U+002C ','` ### Gitea Version 1.17-RC1 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System RHEL 7 ### How are you running Gitea? Using package from release tab on github ### Database MySQL
GiteaMirror added the type/bug label 2025-11-02 08:30:53 -06:00
GiteaMirror commented 2025-11-02 08:30:54 -06:00
Author
Owner
Copy Link

@gd197 commented on GitHub (Jul 1, 2022):

most probably related to #9169 ?

@gd197 commented on GitHub (Jul 1, 2022): most probably related to #9169 ?
GiteaMirror commented 2025-11-02 08:30:54 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jul 1, 2022):

Are you able to tell us how they should be escaped?

@zeripath commented on GitHub (Jul 1, 2022): Are you able to tell us how they should be escaped?
GiteaMirror commented 2025-11-02 08:30:55 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jul 1, 2022):

Should this be:

member=CN=NAME\\\, SURNAME\,OU=SITE\,OU=Internal\,OU=People\,DC=my\,DC=company\,DC=corp
@zeripath commented on GitHub (Jul 1, 2022): Should this be: ``` member=CN=NAME\\\, SURNAME\,OU=SITE\,OU=Internal\,OU=People\,DC=my\,DC=company\,DC=corp ```
GiteaMirror commented 2025-11-02 08:30:55 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jul 1, 2022):

Or is it actually:

member=CN=NAME\\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp
@zeripath commented on GitHub (Jul 1, 2022): Or is it actually: ``` member=CN=NAME\\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp ```
GiteaMirror commented 2025-11-02 08:30:55 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jul 1, 2022):

It would be helpful if you could check the associated PR to ensure it fixes your issue.

@zeripath commented on GitHub (Jul 1, 2022): It would be helpful if you could check the associated PR to ensure it fixes your issue.
GiteaMirror commented 2025-11-02 08:30:55 -06:00
Author
Owner
Copy Link

@gd197 commented on GitHub (Jul 4, 2022):

Sry for my late reply, can you tell me how can I get the associated build amd64 ? I do not have the capability to build gitea in my env.
Thx for your fast answer
The correct escaping in my case is
member=CN=NAME\\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp

@gd197 commented on GitHub (Jul 4, 2022): Sry for my late reply, can you tell me how can I get the associated build amd64 ? I do not have the capability to build gitea in my env. Thx for your fast answer The correct escaping in my case is `member=CN=NAME\\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp`
GiteaMirror commented 2025-11-02 08:30:55 -06:00
Author
Owner
Copy Link

@rmie commented on GitHub (Jul 4, 2022):

@zeripath: https://github.com/go-gitea/gitea/issues/9169#issuecomment-558738712

The recommendation there was to use \5c; but it involved strings entered via UI, likely that this caused additional escaping requirements.

Should this be:
member=CN=NAME\\\, SURNAME\,OU=SITE\,OU=Internal\,OU=People\,DC=my\,DC=company\,DC=corp

no

Or is it actually:
member=CN=NAME\\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp

yes, sans \\, it might be \5c, as well

I can't build and test from source, is the PR built as docker image?

@rmie commented on GitHub (Jul 4, 2022): @zeripath: https://github.com/go-gitea/gitea/issues/9169#issuecomment-558738712 The recommendation there was to use \5c; but it involved strings entered via UI, likely that this caused additional escaping requirements. > Should this be: > `member=CN=NAME\\\, SURNAME\,OU=SITE\,OU=Internal\,OU=People\,DC=my\,DC=company\,DC=corp` no > Or is it actually: > `member=CN=NAME\\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp` yes, sans \\\\, it might be \5c, as well I can't build and test from source, is the PR built as docker image?
GiteaMirror commented 2025-11-02 08:30:56 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jul 4, 2022):

Sry for my late reply, can you tell me how can I get the associated build amd64 ? I do not have the capability to build gitea in my env.

Honestly building Gitea is very very simple especially for amd64. I've previously built PRs for people but it's really something that I save for those personally sponsoring me.

The correct escaping in my case is
member=CN=NAME\\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp

Ok so my PR will do the right thing.

@zeripath commented on GitHub (Jul 4, 2022): > Sry for my late reply, can you tell me how can I get the associated build amd64 ? I do not have the capability to build gitea in my env. Honestly building Gitea is very very simple especially for amd64. I've previously built PRs for people but it's really something that I save for those personally sponsoring me. > The correct escaping in my case is > `member=CN=NAME\\, SURNAME,OU=SITE,OU=Internal,OU=People,DC=my,DC=company,DC=corp` Ok so my PR will do the right thing.
GiteaMirror commented 2025-11-02 08:30:56 -06:00
Author
Owner
Copy Link

@rmie commented on GitHub (Jul 4, 2022):

@zeripath just built and tested your PR, it solves the issue for me

@rmie commented on GitHub (Jul 4, 2022): @zeripath just built and tested your PR, it solves the issue for me
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#9154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?