Within a pull request page, resolved comment links should lead us to the diff or the file instead of the now absent comment #8969

New Issue

GiteaMirror · 2025-11-02T08:24:21-06:00

GiteaMirror commented

2025-11-02 08:24:21 -06:00

Originally created by @bchhun on GitHub (May 17, 2022).

Feature Description

Hi there,

Once a comment has been resolved within a pull request, its status would be shown like in the following screenshot:

The link under my cursor would still have a link leading us to the now absent comment anchor.

It's current URL format is https://my.gitea.domain/my-org/my-repo/pulls/{pull-request-id}/files#{issuecomment-id}.

So when a comment has been resolved, I would propose to change that specific link to either:

the diff in the pull request Files Changed tab: https://my.gitea.domain/my-org/my-repo/pulls/{pull-request-id}/files#{diff-id}
the file (the same link as the View File button): https://my.gitea.domain/my-org/my-repo/src/commit/af6bd42591d0af5eca05304464e36154c3bc13b6/{path/to/filename.ext}

Thanks for reading and considering this proposal.

Screenshots

No response

Originally created by @bchhun on GitHub (May 17, 2022). ### Feature Description Hi there, Once a comment has been resolved within a pull request, its status would be shown like in the following screenshot: ![image](https://user-images.githubusercontent.com/433913/168884716-741ff40f-4c67-47c2-82c1-b25146ed0c8a.png) The link under my cursor would still have a link leading us to the now absent comment anchor. It's current URL format is `https://my.gitea.domain/my-org/my-repo/pulls/{pull-request-id}/files#{issuecomment-id}`. So when a comment has been resolved, I would propose to change that specific link to either: * the diff in the pull request _Files Changed_ tab: `https://my.gitea.domain/my-org/my-repo/pulls/{pull-request-id}/files#{diff-id}` * the file (the same link as the _View File_ button): `https://my.gitea.domain/my-org/my-repo/src/commit/af6bd42591d0af5eca05304464e36154c3bc13b6/{path/to/filename.ext}` Thanks for reading and considering this proposal. ### Screenshots _No response_

GiteaMirror added the type/enhancement type/proposal labels 2025-11-02 08:24:21 -06:00

GiteaMirror commented

2025-11-02 08:24:22 -06:00

@zeripath commented on GitHub (May 19, 2022):

I think you mean when the comment has been outdated

@zeripath commented on GitHub (May 19, 2022): I think you mean when the comment has been outdated

GiteaMirror commented

2025-11-02 08:24:22 -06:00

@zeripath commented on GitHub (May 19, 2022):

In reality we can't even say that the file will still be listed in the /pulls/:PRID/files page because it's possible that the current state of the PR no longer even changes that file.

I suspect we may have to just drop the link.

@zeripath commented on GitHub (May 19, 2022): In reality we can't even say that the file will still be listed in the /pulls/:PRID/files page because it's possible that the current state of the PR no longer even changes that file. I suspect we may have to just drop the link.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#8969