github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-11 17:46:29 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Panic when requesting team members API #8806

New Issue
Closed
opened 2025-11-02 08:19:16 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 08:19:16 -06:00
Owner
Copy Link

Originally created by @qwerty287 on GitHub (Apr 9, 2022).

Originally assigned to: @delvh on GitHub.

Description

I tried to find the commit resposible for this, but I couldn't find it. I tried commit after April 2 and it always panics. Maybe it is database-related or something like this?

[625188bc-3] router: failed    GET /api/v1/teams/4/members for 10.42.0.72:47414, panic in 40.2ms @ org/team.go:347(org.GetTeamMembers), err=runtime error: index out of range [0] with length 0
...common/middleware.go:71:1() [E] [625188bc-4] PANIC: runtime error: index out of range [0] with length 0
        /usr/lib/go-1.17/src/runtime/panic.go:90 (0x43c474)
                goPanicIndex: panic(boundsError{x: int64(x), signed: true, y: y, code: boundsIndex})
        /home/nathan/projects/Go/gitea/gitea/routers/api/v1/org/team.go:392 (0x1f9186e)
                GetTeamMembers: members[i] = convert.ToUser(member, ctx.Doer)
        /home/nathan/projects/Go/gitea/gitea/modules/web/wrap_convert.go:60 (0x1e354d6)
                convertHandler.func5: t(ctx)
        /home/nathan/projects/Go/gitea/gitea/modules/web/wrap.go:41 (0x1e33a89)
                wrapInternal.func1: done, deferrable := handler(resp, req, others...)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x163b075)
                (*Mux).routeHTTP: h.ServeHTTP(w, r)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/projects/Go/gitea/gitea/modules/web/wrap.go:98 (0x1e3460b)
                MiddleAPI.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/projects/Go/gitea/gitea/modules/web/wrap.go:98 (0x1e3460b)
                MiddleAPI.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/projects/Go/gitea/gitea/modules/context/api.go:272 (0x1a29766)
                APIContexter.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/projects/Go/gitea/gitea/routers/api/v1/api.go:1158 (0x1facaf3)
                securityHeaders.func1.1: next.ServeHTTP(resp, req)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x1638eac)
                (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
        /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x163a85b)
                (*Mux).Mount.func1: handler.ServeHTTP(w, r)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x163b075)
                (*Mux).routeHTTP: h.ServeHTTP(w, r)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/projects/Go/gitea/gitea/routers/common/middleware.go:79 (0x1e9dc22)
                Middlewares.func2.1: next.ServeHTTP(resp, req)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/projects/Go/gitea/gitea/modules/web/routing/logger_manager.go:123 (0x1e2f7af)
                (*requestRecordsManager).handler.func1: next.ServeHTTP(w, req)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/strip.go:30 (0x1e99098)
                StripSlashes.func1: next.ServeHTTP(w, r)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x1e95956)
                ForwardedHeaders.func1.1: h.ServeHTTP(w, r)
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/projects/Go/gitea/gitea/routers/common/middleware.go:32 (0x1e9da72)
                Middlewares.func1.1: next.ServeHTTP(context.NewResponse(resp), req.WithContext(ctx))
        /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae)
                HandlerFunc.ServeHTTP: f(w, r)
        /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:88 (0x1638e61)
                (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
        /home/nathan/projects/Go/gitea/gitea/modules/web/route.go:200 (0x1e32ecd)
                (*Route).ServeHTTP: r.R.ServeHTTP(w, req)
        /usr/lib/go-1.17/src/net/http/server.go:2878 (0x8d9e1a)
                serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)
        /usr/lib/go-1.17/src/net/http/server.go:1929 (0x8d5987)
                (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)
        /usr/lib/go-1.17/src/runtime/asm_amd64.s:1581 (0x473b80)
                goexit: BYTE    $0x90   // NOP

(Can't reproduce on try.gitea.io because I can't use orgs there)

Gitea Version

almost latest main

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

compiled from source, from command line

Database

MySQL

Originally created by @qwerty287 on GitHub (Apr 9, 2022). Originally assigned to: @delvh on GitHub. ### Description I tried to find the commit resposible for this, but I couldn't find it. I tried commit after April 2 and it always panics. Maybe it is database-related or something like this? ```log [625188bc-3] router: failed GET /api/v1/teams/4/members for 10.42.0.72:47414, panic in 40.2ms @ org/team.go:347(org.GetTeamMembers), err=runtime error: index out of range [0] with length 0 ...common/middleware.go:71:1() [E] [625188bc-4] PANIC: runtime error: index out of range [0] with length 0 /usr/lib/go-1.17/src/runtime/panic.go:90 (0x43c474) goPanicIndex: panic(boundsError{x: int64(x), signed: true, y: y, code: boundsIndex}) /home/nathan/projects/Go/gitea/gitea/routers/api/v1/org/team.go:392 (0x1f9186e) GetTeamMembers: members[i] = convert.ToUser(member, ctx.Doer) /home/nathan/projects/Go/gitea/gitea/modules/web/wrap_convert.go:60 (0x1e354d6) convertHandler.func5: t(ctx) /home/nathan/projects/Go/gitea/gitea/modules/web/wrap.go:41 (0x1e33a89) wrapInternal.func1: done, deferrable := handler(resp, req, others...) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x163b075) (*Mux).routeHTTP: h.ServeHTTP(w, r) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/projects/Go/gitea/gitea/modules/web/wrap.go:98 (0x1e3460b) MiddleAPI.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/projects/Go/gitea/gitea/modules/web/wrap.go:98 (0x1e3460b) MiddleAPI.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/projects/Go/gitea/gitea/modules/context/api.go:272 (0x1a29766) APIContexter.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/projects/Go/gitea/gitea/routers/api/v1/api.go:1158 (0x1facaf3) securityHeaders.func1.1: next.ServeHTTP(resp, req) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x1638eac) (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r) /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x163a85b) (*Mux).Mount.func1: handler.ServeHTTP(w, r) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x163b075) (*Mux).routeHTTP: h.ServeHTTP(w, r) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/projects/Go/gitea/gitea/routers/common/middleware.go:79 (0x1e9dc22) Middlewares.func2.1: next.ServeHTTP(resp, req) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/projects/Go/gitea/gitea/modules/web/routing/logger_manager.go:123 (0x1e2f7af) (*requestRecordsManager).handler.func1: next.ServeHTTP(w, req) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/strip.go:30 (0x1e99098) StripSlashes.func1: next.ServeHTTP(w, r) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x1e95956) ForwardedHeaders.func1.1: h.ServeHTTP(w, r) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/projects/Go/gitea/gitea/routers/common/middleware.go:32 (0x1e9da72) Middlewares.func1.1: next.ServeHTTP(context.NewResponse(resp), req.WithContext(ctx)) /usr/lib/go-1.17/src/net/http/server.go:2046 (0x8d68ae) HandlerFunc.ServeHTTP: f(w, r) /home/nathan/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:88 (0x1638e61) (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r) /home/nathan/projects/Go/gitea/gitea/modules/web/route.go:200 (0x1e32ecd) (*Route).ServeHTTP: r.R.ServeHTTP(w, req) /usr/lib/go-1.17/src/net/http/server.go:2878 (0x8d9e1a) serverHandler.ServeHTTP: handler.ServeHTTP(rw, req) /usr/lib/go-1.17/src/net/http/server.go:1929 (0x8d5987) (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req) /usr/lib/go-1.17/src/runtime/asm_amd64.s:1581 (0x473b80) goexit: BYTE $0x90 // NOP ``` (Can't reproduce on try.gitea.io because I can't use orgs there) ### Gitea Version almost latest `main` ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? compiled from source, from command line ### Database MySQL
GiteaMirror added the type/bugmodifies/api labels 2025-11-02 08:19:16 -06:00
GiteaMirror commented 2025-11-02 08:19:18 -06:00
Author
Owner
Copy Link

@delvh commented on GitHub (Apr 9, 2022):

On first glance, I think the responsible line for that is (as the stacktrace implies) d906858847/routers/api/v1/org/team.go (L392)

I think this line should rather be

members = append(members, convert.ToUser(member, ctx.Doer))
@delvh commented on GitHub (Apr 9, 2022): On first glance, I think the responsible line for that is (as the stacktrace implies) https://github.com/go-gitea/gitea/blob/d906858847e0d345bc02f04b4037dfa80650889e/routers/api/v1/org/team.go#L392 I think this line should rather be ```go members = append(members, convert.ToUser(member, ctx.Doer)) ```
GiteaMirror commented 2025-11-02 08:19:18 -06:00
Author
Owner
Copy Link

@delvh commented on GitHub (Apr 9, 2022):

Either that, or d906858847/routers/api/v1/org/team.go (L390)
should rather be

	members := make([]*api.User, len(teamMembers))
@delvh commented on GitHub (Apr 9, 2022): Either that, or https://github.com/go-gitea/gitea/blob/d906858847e0d345bc02f04b4037dfa80650889e/routers/api/v1/org/team.go#L390 should rather be ```go members := make([]*api.User, len(teamMembers)) ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label modifies/api type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8806
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?