github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-10 15:39:40 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Html comments are shown in PR and issue descriptions #8742

New Issue
Closed
opened 2025-11-02 08:16:10 -06:00 by GiteaMirror · 10 comments
GiteaMirror commented 2025-11-02 08:16:10 -06:00
Owner
Copy Link

Originally created by @viceice on GitHub (Mar 24, 2022).

Description

Since v1.16.5 Html comments are shown in PR and issue descriptions, they should be hidden as before.

Reproducer: https://try.gitea.io/viceice/test/issues/1

Gitea Version

1.16.5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

Official helm chart with slim image

Database

PostgreSQL

Originally created by @viceice on GitHub (Mar 24, 2022). ### Description Since v1.16.5 Html comments are shown in PR and issue descriptions, they should be hidden as before. Reproducer: https://try.gitea.io/viceice/test/issues/1 ### Gitea Version 1.16.5 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots ![image](https://user-images.githubusercontent.com/1798109/159889314-87fa78bd-368e-4743-83e6-ea13455642cd.png) ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Official helm chart with slim image ### Database PostgreSQL
GiteaMirror added the type/bugtype/upstream labels 2025-11-02 08:16:10 -06:00
GiteaMirror commented 2025-11-02 08:16:11 -06:00
Author
Owner
Copy Link

@viceice commented on GitHub (Mar 24, 2022):

It seems < is encoded as \x3C 🤔

@viceice commented on GitHub (Mar 24, 2022): It seems `<` is encoded as `\x3C` 🤔
GiteaMirror commented 2025-11-02 08:16:11 -06:00
Author
Owner
Copy Link

@xoxys commented on GitHub (Mar 24, 2022):

As discussed in the chat:

gitea on  HEAD (e6d46ee) (BISECTING) [$] via 🐹 v1.16.15 via  v16.14.0 took 8s 
❯ git bisect good
f9ea4ab69ae397be4791c2e2ebf59f6cd9e5a6f8 is the first bad commit
commit f9ea4ab69ae397be4791c2e2ebf59f6cd9e5a6f8
Author: techknowlogick <techknowlogick@gitea.io>
Date:   Sat Mar 19 13:46:47 2022 -0400
@xoxys commented on GitHub (Mar 24, 2022): As discussed in the chat: ``` gitea on  HEAD (e6d46ee) (BISECTING) [$] via 🐹 v1.16.15 via  v16.14.0 took 8s ❯ git bisect good f9ea4ab69ae397be4791c2e2ebf59f6cd9e5a6f8 is the first bad commit commit f9ea4ab69ae397be4791c2e2ebf59f6cd9e5a6f8 Author: techknowlogick <techknowlogick@gitea.io> Date: Sat Mar 19 13:46:47 2022 -0400 ```
GiteaMirror commented 2025-11-02 08:16:12 -06:00
Author
Owner
Copy Link

@viceice commented on GitHub (Mar 24, 2022):

maybe the github.com/yuin/goldmark v1.4.0 to v1.4.8 update?

@viceice commented on GitHub (Mar 24, 2022): maybe the `github.com/yuin/goldmark` v1.4.0 to v1.4.8 update?
GiteaMirror commented 2025-11-02 08:16:12 -06:00
Author
Owner
Copy Link

@viceice commented on GitHub (Mar 24, 2022):

I think this is fixed in a later version

@viceice commented on GitHub (Mar 24, 2022): I think this is fixed in a later version - https://github.com/yuin/goldmark/issues/285 - https://github.com/yuin/goldmark/commit/e64a68fc130e0c74dd2cbec59e6737a2e2bb7398 - https://github.com/yuin/goldmark/releases/tag/v1.4.9
GiteaMirror commented 2025-11-02 08:16:12 -06:00
Author
Owner
Copy Link

@xoxys commented on GitHub (Mar 24, 2022):

Should be a quick fix in this case.

@xoxys commented on GitHub (Mar 24, 2022): Should be a quick fix in this case.
GiteaMirror commented 2025-11-02 08:16:12 -06:00
Author
Owner
Copy Link

@viceice commented on GitHub (Mar 24, 2022):

When can i expect a fixed gitea version? If it needs some days i would create a small jquery script on page load to fix it temporary

@viceice commented on GitHub (Mar 24, 2022): When can i expect a fixed gitea version? If it needs some days i would create a small jquery script on page load to fix it temporary
GiteaMirror commented 2025-11-02 08:16:12 -06:00
Author
Owner
Copy Link

@xoxys commented on GitHub (Mar 24, 2022):

Don't know, one of the maintainers could give us a rough timeline.

@xoxys commented on GitHub (Mar 24, 2022): Don't know, one of the maintainers could give us a rough timeline.
GiteaMirror commented 2025-11-02 08:16:12 -06:00
Author
Owner
Copy Link

@viceice commented on GitHub (Mar 24, 2022):

Just ask if it's worth to create the quickfix 🙃

@viceice commented on GitHub (Mar 24, 2022): Just ask if it's worth to create the quickfix 🙃
GiteaMirror commented 2025-11-02 08:16:13 -06:00
Author
Owner
Copy Link

@xoxys commented on GitHub (Mar 24, 2022):

Can confirm that updating goldmark fixes the issue:

❯ docker run -v $(pwd):/drone/src --workdir /drone/src -it golang:1.18 bash
root@c5219c2fabbe:/drone/src# go get -u github.com/yuin/goldmark
go: downloading github.com/yuin/goldmark v1.4.11
go: upgraded github.com/yuin/goldmark v1.4.8 => v1.4.11
root@c5219c2fabbe:/drone/src# TAGS="bindata sqlite sqlite_unlock_notify" make build

So you could build it with the fixed version from the release/v1.16 branch on your own.

@xoxys commented on GitHub (Mar 24, 2022): Can confirm that updating goldmark fixes the issue: ``` ❯ docker run -v $(pwd):/drone/src --workdir /drone/src -it golang:1.18 bash root@c5219c2fabbe:/drone/src# go get -u github.com/yuin/goldmark go: downloading github.com/yuin/goldmark v1.4.11 go: upgraded github.com/yuin/goldmark v1.4.8 => v1.4.11 root@c5219c2fabbe:/drone/src# TAGS="bindata sqlite sqlite_unlock_notify" make build ``` So you could build it with the fixed version from the `release/v1.16` branch on your own.
GiteaMirror commented 2025-11-02 08:16:13 -06:00
Author
Owner
Copy Link

@viceice commented on GitHub (Mar 24, 2022):

OK, thanks. Will do a jQuery quickfix for now. It's easier, as i already have a custom js file embedded. 😉

$('.task-list-item').contents().each((i, e) => {
  if (e.nodeName === '#text') {
    e.textContent = e.textContent.replaceAll(/\x3C!--.*?-->/g, '')
  }
})
@viceice commented on GitHub (Mar 24, 2022): OK, thanks. Will do a jQuery quickfix for now. It's easier, as i already have a custom js file embedded. 😉 ```js $('.task-list-item').contents().each((i, e) => { if (e.nodeName === '#text') { e.textContent = e.textContent.replaceAll(/\x3C!--.*?-->/g, '') } }) ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug type/upstream
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8742
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?