github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-15 12:42:02 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Markdown rendering of links with titles #851

New Issue
Closed
opened 2025-11-02 03:38:59 -06:00 by GiteaMirror · 12 comments
GiteaMirror commented 2025-11-02 03:38:59 -06:00
Owner
Copy Link

Originally created by @IzzySoft on GitHub (Jun 27, 2017).

  • Gitea version (or commit ref): 1.1.2
  • Git version: 2.1.4
  • Operating system: Bananian (Debian Jessie, ARM)
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
    • could not try, server timed out
  • Log gist:

Description

Markdown rendering of links with titles is incomplete and sometimes even fails, which I just noticed in the README.md file of one of my repos (a mirror of Adebar):

  • [Adb](http://en.wikipedia.org/wiki/Android_Debug_Bridge "Wikipedia: Android Debug Bridge"): Title is missing (usually shown on mouse-over):

      <a href="http://en.wikipedia.org/wiki/Android_Debug_Bridge" rel="nofollow">Adb</a>

  • [Bash](http://en.wikipedia.org/wiki/Bash_%28Unix_shell%29 "Wikipedia: Bash (Unix shell)"): fails and renders as Bash"):

      It is mainly based on Bash")

So the title attribute is at best omitted or, if containing parenthesis, the entire link breaks.

Screenshots

Screenshot
Screenshot (click for larger image)

Originally created by @IzzySoft on GitHub (Jun 27, 2017). - Gitea version (or commit ref): 1.1.2 - Git version: 2.1.4 - Operating system: Bananian (Debian Jessie, ARM) - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [ ] Not relevant - [x] could not try, server timed out - Log gist: ## Description Markdown rendering of links with titles is incomplete and sometimes even fails, which I just noticed in the `README.md` file of one of my repos (a mirror of [Adebar](https://github.com/IzzySoft/Adebar)): * `[Adb](http://en.wikipedia.org/wiki/Android_Debug_Bridge "Wikipedia: Android Debug Bridge")`: Title is missing (usually shown on mouse-over): <a href="http://en.wikipedia.org/wiki/Android_Debug_Bridge" rel="nofollow">Adb</a> * `[Bash](http://en.wikipedia.org/wiki/Bash_%28Unix_shell%29 "Wikipedia: Bash (Unix shell)")`: fails and renders as `Bash")`: It is mainly based on Bash") So the `title` attribute is at best omitted or, if containing parenthesis, the entire link breaks. ## Screenshots [![Screenshot](https://i.imgur.com/XdQYiWsm.png)](https://i.imgur.com/XdQYiWs.png) <sup>Screenshot (click for larger image)</sup>
GiteaMirror added the issue/confirmedtype/testingtype/bug labels 2025-11-02 03:38:59 -06:00
GiteaMirror commented 2025-11-02 03:39:00 -06:00
Author
Owner
Copy Link

@bkcsoft commented on GitHub (Jun 28, 2017):

Added kind/testing since we also not testing for this

@bkcsoft commented on GitHub (Jun 28, 2017): Added `kind/testing` since we also not testing for this
GiteaMirror commented 2025-11-02 03:39:00 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Feb 11, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Feb 11, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 03:39:00 -06:00
Author
Owner
Copy Link

@IzzySoft commented on GitHub (Feb 11, 2019):

This one was somehow forgotten it seems. I'll have to check if the problem itself was solved and just this issue forgotten to close (cannot access my Gitea instance from where I currently am).

@IzzySoft commented on GitHub (Feb 11, 2019): This one was somehow forgotten it seems. I'll have to check if the problem itself was solved and just this issue forgotten to close (cannot access my Gitea instance from where I currently am).
GiteaMirror commented 2025-11-02 03:39:00 -06:00
Author
Owner
Copy Link

@IzzySoft commented on GitHub (Feb 11, 2019):

Issue still exists with Gitea 1.7. Any chance to see it fixed before its 2nd birthday? 😃

@IzzySoft commented on GitHub (Feb 11, 2019): Issue still exists with Gitea 1.7. Any chance to see it fixed before its 2nd birthday? :smiley:
GiteaMirror commented 2025-11-02 03:39:00 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Feb 11, 2019):

Nobody is working on this so any help would be greatly appreciated

@lafriks commented on GitHub (Feb 11, 2019): Nobody is working on this so any help would be greatly appreciated
GiteaMirror commented 2025-11-02 03:39:00 -06:00
Author
Owner
Copy Link

@techknowlogick commented on GitHub (Feb 11, 2019):

I think this issue may be caused by the upstream markdown library and would need to be fixed there.

@techknowlogick commented on GitHub (Feb 11, 2019): I think this issue may be caused by the upstream markdown library and would need to be fixed there.
GiteaMirror commented 2025-11-02 03:39:01 -06:00
Author
Owner
Copy Link

@IzzySoft commented on GitHub (Feb 11, 2019):

I'd help out if I could – but I'm completely lost with Go, sorry…

@IzzySoft commented on GitHub (Feb 11, 2019): I'd help out if I could – but I'm completely lost with Go, sorry…
GiteaMirror commented 2025-11-02 03:39:01 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Apr 12, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Apr 12, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 03:39:01 -06:00
Author
Owner
Copy Link

@IzzySoft commented on GitHub (Apr 13, 2019):

Thanks, @lunny – I just checked, the issue still exists with v1.7.5 (the latest release with binaries attached).

@IzzySoft commented on GitHub (Apr 13, 2019): Thanks, @lunny – I just checked, the issue still exists with v1.7.5 (the latest release with binaries attached).
GiteaMirror commented 2025-11-02 03:39:01 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Sep 6, 2020):

@IzzySoft can you check again?

the markdown rendering lib has changed

@6543 commented on GitHub (Sep 6, 2020): @IzzySoft can you check again? the markdown rendering lib has changed
GiteaMirror commented 2025-11-02 03:39:01 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Sep 6, 2020):

This is also fixed.

See https://try.gitea.io/arandomer/Adebar

@zeripath commented on GitHub (Sep 6, 2020): This is also fixed. See https://try.gitea.io/arandomer/Adebar
GiteaMirror commented 2025-11-02 03:39:01 -06:00
Author
Owner
Copy Link

@IzzySoft commented on GitHub (Sep 6, 2020):

I can confirm what @zeripath mentioned on try.gitea for the original place at Codeberg: https://codeberg.org/izzy/Adebar/ – so thanks, this indeed seems to be fixed!

@IzzySoft commented on GitHub (Sep 6, 2020): I can confirm what @zeripath mentioned on try.gitea for the original place at Codeberg: https://codeberg.org/izzy/Adebar/ – so thanks, this indeed seems to be fixed!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed type/bug type/testing
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#851
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?