[Feature Request] Add Approve button to the main PR page #8506

New Issue

GiteaMirror · 2025-11-02T08:09:08-06:00

GiteaMirror commented

2025-11-02 08:09:08 -06:00

Originally created by @schorsch13 on GitHub (Feb 5, 2022).

Introduction

Currently when you want to approve a PR you have to navigate to PR > Files Changed > Review > Approve. It is not only confusing for beginners but also a unnecessary handicap. Of course you should review the changes before approving but still a unnecessary amount of "work"

Proposal

Add a Approve button right next to the Merge button

Originally created by @schorsch13 on GitHub (Feb 5, 2022). # Introduction Currently when you want to approve a PR you have to navigate to `PR > Files Changed > Review > Approve`. It is not only confusing for beginners but also a unnecessary handicap. Of course you should review the changes before approving but still a unnecessary amount of "work" # Proposal Add a `Approve` button right next to the `Merge` button

GiteaMirror closed this issue

2025-11-02 08:09:09 -06:00

GiteaMirror commented

2025-11-02 08:09:09 -06:00

@lunny commented on GitHub (Feb 6, 2022):

Why you want to approve before you have reviewed the code?

@lunny commented on GitHub (Feb 6, 2022): Why you want to approve before you have reviewed the code?

GiteaMirror commented

2025-11-02 08:09:09 -06:00

@schorsch13 commented on GitHub (Feb 6, 2022):

Why you want to approve before you have reviewed the code?

I did not say that I want to approve before reviewing

Of course you should review the changes before approving

@schorsch13 commented on GitHub (Feb 6, 2022): > Why you want to approve before you have reviewed the code? I did not say that I want to approve before reviewing > Of course you should review the changes before approving

GiteaMirror commented

2025-11-02 08:09:09 -06:00

@lunny commented on GitHub (Feb 6, 2022):

Why you want to approve before you have reviewed the code?

I did not say that I want to approve before reviewing

Of course you should review the changes before approving

So I think it's suitable only put the button on review page but not conversation page.

@lunny commented on GitHub (Feb 6, 2022): > > Why you want to approve before you have reviewed the code? > > I did not say that I want to approve before reviewing > > > Of course you should review the changes before approving So I think it's suitable only put the button on review page but not conversation page.

GiteaMirror commented

2025-11-02 08:09:10 -06:00

@yardenshoham commented on GitHub (Nov 15, 2022):

I agree, it doesn't make sense to have the approval button outside the Files Changed tab

@yardenshoham commented on GitHub (Nov 15, 2022): I agree, it doesn't make sense to have the approval button outside the Files Changed tab

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#8506

[Feature Request] Add Approve button to the main PR page #8506

Introduction

Proposal

[Feature Request] Add `Approve` button to the main PR page #8506