github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-13 19:37:47 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Inconsistent e-mail address sync from LDAP #8496

New Issue
Closed
opened 2025-11-02 08:08:41 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 08:08:41 -06:00
Owner
Copy Link

Originally created by @pboguslawski on GitHub (Feb 4, 2022).

Gitea Version

1.16-rc1

Git Version

No response

Operating System

No response

How are you running Gitea?

Compiled from source.

Database

No response

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

According to

https://github.com/go-gitea/gitea/issues/4497#issuecomment-459057141

LDAP sync cron task synchronizes only primary user mail; current sync code

https://github.com/go-gitea/gitea/blob/main/services/auth/source/ldap/source_sync.go#L157

updates only email column in user table and does not update extra e-mails nor is_primary state in this table.

There should be separate new method called there for consistent updating user primary e-mail (i.e. in users table and extra emails table with is_primary updating). LDAP should not add changed e-mail as new e-mail (like manual changing user email in admin panel does after https://github.com/go-gitea/gitea/pull/17549) but should update current primary e-mail only like it was working in gitea 1.13.

Same solution should be applied to LDAP sync code on user login if https://github.com/go-gitea/gitea/pull/18452#issuecomment-1029806729 is merged.

To be considered: separate storing user primary e-mail in two separate tables is error prone. It should be kept in only one place problably to avoid such bugs.

Screenshots

No response

Originally created by @pboguslawski on GitHub (Feb 4, 2022). ### Gitea Version 1.16-rc1 ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Compiled from source. ### Database _No response_ ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Description According to https://github.com/go-gitea/gitea/issues/4497#issuecomment-459057141 LDAP sync cron task synchronizes only primary user mail; current sync code https://github.com/go-gitea/gitea/blob/main/services/auth/source/ldap/source_sync.go#L157 updates only email column in user table and does not update extra e-mails nor is_primary state in this table. There should be separate new method called there for consistent updating user primary e-mail (i.e. in users table and extra emails table with is_primary updating). LDAP should not add changed e-mail as new e-mail (like manual changing user email in admin panel does after https://github.com/go-gitea/gitea/pull/17549) but should update current primary e-mail only like it was working in gitea 1.13. Same solution should be applied to LDAP sync code on user login if https://github.com/go-gitea/gitea/pull/18452#issuecomment-1029806729 is merged. To be considered: separate storing user primary e-mail in two separate tables is error prone. It should be kept in only one place problably to avoid such bugs. ### Screenshots _No response_
GiteaMirror added the type/bug label 2025-11-02 08:08:41 -06:00
GiteaMirror commented 2025-11-02 08:08:42 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Feb 16, 2022):

The email in the user table should be deleted in future PRs.

@lunny commented on GitHub (Feb 16, 2022): The email in the user table should be deleted in future PRs.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8496
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?