github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Hash (#) in branch name not properly escaped in all contexts #8420

New Issue
Closed
opened 2025-11-02 08:05:23 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 08:05:23 -06:00
Owner
Copy Link

Originally created by @manuelmohr on GitHub (Jan 28, 2022).

Gitea Version

1.15.9

Git Version

No response

Operating System

No response

How are you running Gitea?

Downloaded build from official site.

Database

PostgreSQL

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

  • Create a branch with a hash symbol (#) in the name
  • View the branch
  • Click "Commits"
  • Get a 404 page because the hash is not escaped
  • If escaped manually to "%23", page displays properly

image
image

Not reproducible on test server, which runs 1.17.0-dev.

Screenshots

No response

Originally created by @manuelmohr on GitHub (Jan 28, 2022). ### Gitea Version 1.15.9 ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Downloaded build from official site. ### Database PostgreSQL ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Description - Create a branch with a hash symbol (#) in the name - View the branch - Click "Commits" - Get a 404 page because the hash is not escaped - If escaped manually to "%23", page displays properly ![image](https://user-images.githubusercontent.com/3143777/151512254-ffc8247e-57ac-4f68-9917-b9574fbce187.png) ![image](https://user-images.githubusercontent.com/3143777/151512385-f3b6ab82-23d0-45e3-8f89-5a8c28ec766c.png) Not reproducible on test server, which runs 1.17.0-dev. ### Screenshots _No response_
GiteaMirror added the issue/needs-feedback label 2025-11-02 08:05:23 -06:00
GiteaMirror commented 2025-11-02 08:05:24 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jan 28, 2022):

Not reproducible on test server, which runs 1.17.0-dev.

Yes, there is a big refactor in 1.16, so could you try it first? Such refactor won't be in 1.15.

@wxiaoguang commented on GitHub (Jan 28, 2022): > Not reproducible on test server, which runs 1.17.0-dev. Yes, there is a big refactor in 1.16, so could you try it first? Such refactor won't be in 1.15.
GiteaMirror commented 2025-11-02 08:05:24 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jan 29, 2022):

Yup I didn't fix the escaping in 1.15 because the escaping pr touched way too many files.

I agree there is a problem but the answer is that we need to get 1.16 out as soon as possible because of this and other things.

@zeripath commented on GitHub (Jan 29, 2022): Yup I didn't fix the escaping in 1.15 because the escaping pr touched way too many files. I agree there is a problem but the answer is that we need to get 1.16 out as soon as possible because of this and other things.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/needs-feedback
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?