Allow cascade PRs #8409

New Issue

GiteaMirror · 2025-11-02T08:05:08-06:00

GiteaMirror commented

2025-11-02 08:05:08 -06:00

Originally created by @kvaster on GitHub (Jan 25, 2022).

Feature Description

Sometime you need to have 'cascade' PRs. i.e.

first you're working on feature A (derived from main branch) and you create PR feature A -> main
next you need to work on feature B, but this feature depends on changes of feature A and it's corresponding PR is not yet approved. The best way to work on such feature is derive from feature A and later you need to create PR feature B -> feature A.

Currently second PR will be automatically closed on feature A merge and branch delete. It would be helpfull to rebase second PR. i.e. change 'feature B -> feature A' to 'feature B -> main' when first 'feature A -> main' is merged and 'feature A' branch is deleted.

Screenshots

No response

Originally created by @kvaster on GitHub (Jan 25, 2022). ### Feature Description Sometime you need to have 'cascade' PRs. i.e. * first you're working on feature A (derived from main branch) and you create PR feature A -> main * next you need to work on feature B, but this feature depends on changes of feature A and it's corresponding PR is not yet approved. The best way to work on such feature is derive from feature A and later you need to create PR feature B -> feature A. Currently second PR will be automatically closed on feature A merge and branch delete. It would be helpfull to rebase second PR. i.e. change 'feature B -> feature A' to 'feature B -> main' when first 'feature A -> main' is merged and 'feature A' branch is deleted. ### Screenshots _No response_

GiteaMirror added the type/proposal label 2025-11-02 08:05:08 -06:00

GiteaMirror closed this issue

2025-11-02 08:05:08 -06:00

GiteaMirror commented

2025-11-02 08:05:08 -06:00

@lunny commented on GitHub (Jan 26, 2022):

Could you reopen it and rebase to main?

@lunny commented on GitHub (Jan 26, 2022): Could you reopen it and rebase to main?

GiteaMirror commented

2025-11-02 08:05:08 -06:00

@kvaster commented on GitHub (Jan 27, 2022):

It's not possible to reopen and rebase PR: This pull request cannot be reopened because the branch was deleted.

@kvaster commented on GitHub (Jan 27, 2022): It's not possible to reopen and rebase PR: This pull request cannot be reopened because the branch was deleted.

GiteaMirror commented

2025-11-02 08:05:09 -06:00

@lunny commented on GitHub (Jan 29, 2022):

Then you can check out the pull request and create a new one.

@lunny commented on GitHub (Jan 29, 2022): Then you can check out the pull request and create a new one.

GiteaMirror commented

2025-11-02 08:05:09 -06:00

@kvaster commented on GitHub (Jan 31, 2022):

Then you can check out the pull request and create a new one.

You may, but review in-progress will be lost in this case.

@kvaster commented on GitHub (Jan 31, 2022): > Then you can check out the pull request and create a new one. You may, but review in-progress will be lost in this case.

GiteaMirror commented

2025-11-02 08:05:09 -06:00

@LeafyLappa commented on GitHub (Jun 6, 2023):

Then you can check out the pull request and create a new one.

You may, but review in-progress will be lost in this case.

came across this exact problem, very frustrating.

@LeafyLappa commented on GitHub (Jun 6, 2023): > > Then you can check out the pull request and create a new one. > > You may, but review in-progress will be lost in this case. came across this exact problem, very frustrating.

GiteaMirror commented

2025-11-02 08:05:09 -06:00

@xav-ie commented on GitHub (Nov 14, 2023):

Re-opening is not an option because my team will spend time reviewing that PR and all the comments and discussion dissappear on re-open.

@xav-ie commented on GitHub (Nov 14, 2023): Re-opening is not an option because my team will spend time reviewing that PR and all the comments and discussion dissappear on re-open.

GiteaMirror commented

2025-11-02 08:05:09 -06:00

@xav-ie commented on GitHub (Nov 14, 2023):

gh pr merge has same issue https://github.com/cli/cli/issues/8331 ... maybe they are connected?

@xav-ie commented on GitHub (Nov 14, 2023): `gh pr merge` has same issue https://github.com/cli/cli/issues/8331 ... maybe they are connected?

GiteaMirror commented

2025-11-02 08:05:10 -06:00

@denyskon commented on GitHub (Jan 3, 2024):

Closing in favor of #27062 which will soon be fixed by #28539

@denyskon commented on GitHub (Jan 3, 2024): Closing in favor of #27062 which will soon be fixed by #28539

GiteaMirror commented

2025-11-02 08:05:10 -06:00

@kvaster commented on GitHub (Jan 3, 2024):

@denyskon , see my comments in #28539.

@kvaster commented on GitHub (Jan 3, 2024): @denyskon , see my comments in #28539.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#8409