github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-21 11:55:31 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Prevent double close comments #8380

New Issue
Open
opened 2025-11-02 08:04:18 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 08:04:18 -06:00
Owner
Copy Link

Originally created by @qwerty287 on GitHub (Jan 19, 2022).

Feature Description

Gitea should prevent close comments if the issue is already closed (just don't add another comment). This happens while merging a PR with squash merge - one close comment comes from the PR desc (close #...) and one from the merge commit if the PR desc is also the commit message.

Screenshots

This example comes from https://codeberg.org/gitnex/GitNex/issues/985#event-291274

Originally created by @qwerty287 on GitHub (Jan 19, 2022). ### Feature Description Gitea should prevent close comments if the issue is already closed (just don't add another comment). This happens while merging a PR with squash merge - one close comment comes from the PR desc (`close #...`) and one from the merge commit if the PR desc is also the commit message. ### Screenshots ![](https://user-images.githubusercontent.com/80460567/150170740-d533ec00-6007-461e-a195-ba823906ea6a.png) This example comes from https://codeberg.org/gitnex/GitNex/issues/985#event-291274
GiteaMirror commented 2025-11-02 08:04:18 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jan 19, 2022):

That's a long story and duplicated of #17111
We could close this one

update: this seems a new problem.

@wxiaoguang commented on GitHub (Jan 19, 2022): ~~That's a long story and duplicated of #17111~~ ~~We could close this one~~ update: this seems a new problem.
GiteaMirror commented 2025-11-02 08:04:18 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jan 19, 2022):

Hmm ... maybe we could do some backend work for the Close action only.

@wxiaoguang commented on GitHub (Jan 19, 2022): Hmm ... maybe we could do some backend work for the `Close` action only.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8380
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?