github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-18 14:12:40 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

500 error when default banch doesn't exist on owner/repo/branches page #8351

New Issue
Closed
opened 2025-11-02 08:03:21 -06:00 by GiteaMirror · 14 comments
GiteaMirror commented 2025-11-02 08:03:21 -06:00
Owner
Copy Link

Originally created by @wxiaoguang on GitHub (Jan 14, 2022).

Gitea version: 1.15.9

Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 Started GET /testuser/pandas/branches for 127.0.0.1:48032
Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 ...s/web/repo/branch.go:168:loadBranches() [E] loadBranches: get default branch: branch does not exist [name: master]
Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 ...s/web/repo/branch.go:169:loadBranches() [E] GetDefaultBranch: branch does not exist [name: master]
Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 Completed GET /testuser/pandas/branches 500 Internal Server Error in 110.488967ms
Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 Started GET /assets/img/500.png for 127.0.0.1:48034
Originally created by @wxiaoguang on GitHub (Jan 14, 2022). Gitea version: 1.15.9 ``` Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 Started GET /testuser/pandas/branches for 127.0.0.1:48032 Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 ...s/web/repo/branch.go:168:loadBranches() [E] loadBranches: get default branch: branch does not exist [name: master] Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 ...s/web/repo/branch.go:169:loadBranches() [E] GetDefaultBranch: branch does not exist [name: master] Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 Completed GET /testuser/pandas/branches 500 Internal Server Error in 110.488967ms Jan 13 05:25:12 my-host gitea[10979]: 2022/01/13 05:25:12 Started GET /assets/img/500.png for 127.0.0.1:48034 ```
GiteaMirror added the type/bug label 2025-11-02 08:03:21 -06:00
GiteaMirror commented 2025-11-02 08:03:22 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Jan 14, 2022):

Is there any branch in this repository?

@lunny commented on GitHub (Jan 14, 2022): Is there any branch in this repository?
GiteaMirror commented 2025-11-02 08:03:22 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 14, 2022):

Yes, but the original repository does not contain a 'master' branch ( e.g., https://github.com/pandas-dev/pandas )

@ghost commented on GitHub (Jan 14, 2022): > Yes, but the original repository does not contain a 'master' branch ( e.g., https://github.com/pandas-dev/pandas )
GiteaMirror commented 2025-11-02 08:03:22 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jan 14, 2022):

this is I presume related to an adopted repository?

@zeripath commented on GitHub (Jan 14, 2022): this is I presume related to an adopted repository?
GiteaMirror commented 2025-11-02 08:03:22 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jan 15, 2022):

@tim-kong Can you help to confirm the problem? How the /testuser/pandas comes, was it adopted (imported from Gitea repository directory directly) before?

@wxiaoguang commented on GitHub (Jan 15, 2022): @tim-kong Can you help to confirm the problem? How the `/testuser/pandas` comes, was it adopted (imported from Gitea repository directory directly) before?
GiteaMirror commented 2025-11-02 08:03:23 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 15, 2022):

OK. Login as testuser , and just mirror the Pandas repository ('https://github.com/pandas-dev/pandas') using Gitea web page (http://example.com/repo/migrate). Don't need to do anything. And when accessing http://example.com/testuser/pandas/branches you well see 500 error.

Thanks.

@ghost commented on GitHub (Jan 15, 2022): > OK. Login as _testuser_ , and just mirror the Pandas repository ('https://github.com/pandas-dev/pandas') using Gitea web page (http://example.com/repo/migrate). Don't need to do anything. And when accessing http://example.com/testuser/pandas/branches you well see 500 error. Thanks.
GiteaMirror commented 2025-11-02 08:03:23 -06:00
Author
Owner
Copy Link

@somera commented on GitHub (Jan 15, 2022):

OK. Login as testuser , and just mirror the Pandas repository ('https://github.com/pandas-dev/pandas') using Gitea web page (http://example.com/repo/migrate). Don't need to do anything. And when accessing http://example.com/testuser/pandas/branches you well see 500 error.

Thanks.

Works for me in Gitea 1.15.10. It need some seconds, but it works.

My URL: http://nuc-mini-celeron:3000/pandas-dev/pandas/branches

Powered by Gitea Version: 1.15.10 Seite: 4904ms Template: 26ms

image

@somera commented on GitHub (Jan 15, 2022): > > > > OK. Login as _testuser_ , and just mirror the Pandas repository ('https://github.com/pandas-dev/pandas') using Gitea web page (http://example.com/repo/migrate). Don't need to do anything. And when accessing http://example.com/testuser/pandas/branches you well see 500 error. > > Thanks. Works for me in Gitea 1.15.10. It need some seconds, but it works. My URL: http://nuc-mini-celeron:3000/pandas-dev/pandas/branches `Powered by Gitea Version: 1.15.10 Seite: 4904ms Template: 26ms` ![image](https://user-images.githubusercontent.com/8334250/149620061-2319c521-f453-45bc-ae6c-0265e563ac69.png)
GiteaMirror commented 2025-11-02 08:03:23 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jan 15, 2022):

I can't reproduce this on main/1.16.0.

(I had this right I can't reproduce this on main)

@zeripath commented on GitHub (Jan 15, 2022): I can't reproduce this on main/1.16.0. (I had this right I can't reproduce this on main)
GiteaMirror commented 2025-11-02 08:03:23 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jan 15, 2022):

Can anyone reproduce this on 1.16?

@zeripath commented on GitHub (Jan 15, 2022): Can anyone reproduce this on 1.16?
GiteaMirror commented 2025-11-02 08:03:24 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jan 15, 2022):

I can trigger the bug manually in 1.16:

  1. Prepare a normal git repository
  2. Go to database, change the repository.default_branch to a non-existing one
  3. Visit /owner/repo/branches
  4. Then we get the 500 error

I can imagine a real case: if a user changes a git repository with a different default branch name (eg: changes the git repository on the server), they would also trigger this bug. I am not sure whether force-push would also trigger such bug.

Maybe the better behavior is getting rid of the 500 page (internal error should be something serious, but not this case)

@wxiaoguang commented on GitHub (Jan 15, 2022): I can trigger the bug manually in 1.16: 1. Prepare a normal git repository 2. Go to database, change the `repository`.`default_branch` to a non-existing one 3. Visit `/owner/repo/branches` 4. Then we get the 500 error I can imagine a real case: if a user changes a git repository with a different default branch name (eg: changes the git repository on the server), they would also trigger this bug. I am not sure whether force-push would also trigger such bug. Maybe the better behavior is getting rid of the 500 page (internal error should be something serious, but not this case)
GiteaMirror commented 2025-11-02 08:03:24 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 15, 2022):

I update my gitea version to 1.15.10, and cannot trigger the bug.

@ghost commented on GitHub (Jan 15, 2022): I update my gitea version to 1.15.10, and cannot trigger the bug.
GiteaMirror commented 2025-11-02 08:03:24 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Jan 15, 2022):

I update my gitea version to 1.15.10, and cannot trigger the bug.

Actually, 1.15.10 only contains some small fixes, and should not be related to this bug (https://github.com/go-gitea/gitea/releases/tag/v1.15.10) . I suspect you did something or Gitea did something, then the default_branch gets a correct value.

@wxiaoguang commented on GitHub (Jan 15, 2022): > I update my gitea version to 1.15.10, and cannot trigger the bug. Actually, 1.15.10 only contains some small fixes, and should not be related to this bug (https://github.com/go-gitea/gitea/releases/tag/v1.15.10) . I suspect you did something or Gitea did something, then the `default_branch` gets a correct value.
GiteaMirror commented 2025-11-02 08:03:24 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jan 15, 2022):

I can trigger the bug manually in 1.16:

  1. Prepare a normal git repository
  2. Go to database, change the repository.default_branch to a non-existing one
  3. Visit /owner/repo/branches
  4. Then we get the 500 error

I can imagine a real case: if a user changes a git repository with a different default branch name (eg: changes the git repository on the server), they would also trigger this bug. I am not sure whether force-push would also trigger such bug.

Maybe the better behavior is getting rid of the 500 page (internal error should be something serious, but not this case)

Weirdly I wasn't able to do this on pandas.

AHA The /owner/repo/branches bit was the thing I was missing.

@zeripath commented on GitHub (Jan 15, 2022): > I can trigger the bug manually in 1.16: > > 1. Prepare a normal git repository > 2. Go to database, change the `repository`.`default_branch` to a non-existing one > 3. Visit `/owner/repo/branches` > 4. Then we get the 500 error > > I can imagine a real case: if a user changes a git repository with a different default branch name (eg: changes the git repository on the server), they would also trigger this bug. I am not sure whether force-push would also trigger such bug. > > Maybe the better behavior is getting rid of the 500 page (internal error should be something serious, but not this case) Weirdly I wasn't able to do this on pandas. --- AHA The /owner/repo/branches bit was the thing I was missing.
GiteaMirror commented 2025-11-02 08:03:24 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 15, 2022):

50ac4981e0

It is probably the root cause.... Pandas has recently replace 'master' with 'main', just several days ago.

@ghost commented on GitHub (Jan 15, 2022): https://github.com/pandas-dev/pandas/commit/50ac4981e0b2dca5fc0c353ddcf3b900925bce9b It is probably the root cause.... Pandas has recently replace 'master' with 'main', just several days ago.
GiteaMirror commented 2025-11-02 08:03:25 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jan 15, 2022):

I've put a PR in to handle this but we might not necessarily backport it.

@zeripath commented on GitHub (Jan 15, 2022): I've put a PR in to handle this but we might not necessarily backport it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8351
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?