github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Internal Server Error 500 when browsing the front page of a particular repository #835

New Issue
Closed
opened 2025-11-02 03:38:12 -06:00 by GiteaMirror · 14 comments
GiteaMirror commented 2025-11-02 03:38:12 -06:00
Owner
Copy Link

Originally created by @typeless on GitHub (Jun 22, 2017).

  • Gitea version (or commit ref):
    Gitea Version: 1.1.0+351-g7051e60

  • Git version:
    2.7.4

  • Operating system:
    Ubuntu 16.04 64bit

  • Database (use [x]):

    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite

  • Can you reproduce the bug at https://try.gitea.io:

    • Yes (provide example URL)
    • No
    • Not relevant

  • Log gist:

2017/06/22 17:12:13 [I] Log Mode: File(Info)
2017/06/22 17:12:13 [I] XORM Log Mode: File(Info)
2017/06/22 17:12:13 [I] Cache Service Enabled
2017/06/22 17:12:13 [I] Session Service Enabled
2017/06/22 17:12:13 [I] Git Version: 2.7.4
2017/06/22 17:12:13 [I] SQLite3 Supported
2017/06/22 17:12:13 [I] Run Mode: Production
2017/06/22 17:12:13 [I] Listen: http://0.0.0.0:3000
2017/06/22 17:12:17 [...routers/repo/view.go:53 renderDirectory()] [E] GetCommitsInfo: exit status 128 - fatal: bad revision '128ef2198170e51ab90601592f2ddc3be15ee170^'

Description

Looks like the added '^' in 474d636794 (diff-c689e587c4a9ef800a342d225b8ff732R271) will cause the problem.

The following is the git command that causes the error

git log --pretty=format:%H --name-only -1 128ef2198170e51ab90601592f2ddc3be15ee170^ -- .gitignore

Note that the commit in question is the initial commit of the repository.

Originally created by @typeless on GitHub (Jun 22, 2017). - Gitea version (or commit ref): Gitea Version: 1.1.0+351-g7051e60 - Git version: 2.7.4 - Operating system: Ubuntu 16.04 64bit - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [ ] Not relevant - Log gist: ``` 2017/06/22 17:12:13 [I] Log Mode: File(Info) 2017/06/22 17:12:13 [I] XORM Log Mode: File(Info) 2017/06/22 17:12:13 [I] Cache Service Enabled 2017/06/22 17:12:13 [I] Session Service Enabled 2017/06/22 17:12:13 [I] Git Version: 2.7.4 2017/06/22 17:12:13 [I] SQLite3 Supported 2017/06/22 17:12:13 [I] Run Mode: Production 2017/06/22 17:12:13 [I] Listen: http://0.0.0.0:3000 2017/06/22 17:12:17 [...routers/repo/view.go:53 renderDirectory()] [E] GetCommitsInfo: exit status 128 - fatal: bad revision '128ef2198170e51ab90601592f2ddc3be15ee170^' ``` ## Description Looks like the added '^' in https://github.com/go-gitea/gitea/commit/474d6367946c661ea4b8a6b8b25fab1b5bec15d2#diff-c689e587c4a9ef800a342d225b8ff732R271 will cause the problem. The following is the git command that causes the error ``` git log --pretty=format:%H --name-only -1 128ef2198170e51ab90601592f2ddc3be15ee170^ -- .gitignore ``` Note that the commit in question is the initial commit of the repository.
GiteaMirror added the type/bug label 2025-11-02 03:38:12 -06:00
GiteaMirror commented 2025-11-02 03:38:13 -06:00
Author
Owner
Copy Link

@typeless commented on GitHub (Jun 22, 2017):

Removing the trailing '^' seems to fix the problem. I haven't figured out the root cause though.

@typeless commented on GitHub (Jun 22, 2017): Removing the trailing '^' seems to fix the problem. I haven't figured out the root cause though.
GiteaMirror commented 2025-11-02 03:38:13 -06:00
Author
Owner
Copy Link

@ethantkoenig commented on GitHub (Jun 22, 2017):

@typeless I believe this will be fixed by https://github.com/go-gitea/git/pull/66. Can you pull the latest changes from code.gitea.io/git, and see if that fixes the problem?

@ethantkoenig commented on GitHub (Jun 22, 2017): @typeless I believe this will be fixed by https://github.com/go-gitea/git/pull/66. Can you pull the latest changes from code.gitea.io/git, and see if that fixes the problem?
GiteaMirror commented 2025-11-02 03:38:13 -06:00
Author
Owner
Copy Link

@typeless commented on GitHub (Jun 23, 2017):

@ethantkoenig You are correct. The problem is fixed. 👍

@typeless commented on GitHub (Jun 23, 2017): @ethantkoenig You are correct. The problem is fixed. 👍
GiteaMirror commented 2025-11-02 03:38:14 -06:00
Author
Owner
Copy Link

@typeless commented on GitHub (Jun 23, 2017):

Sorry but this problem is probably not fixed yet.

Currently I made a workaround which might be the correct fix or not:

diff --git a/vendor/code.gitea.io/git/tree_entry.go b/vendor/code.gitea.io/git/tree_entry.go
index 7ea4d21..110f93c 100644
--- a/vendor/code.gitea.io/git/tree_entry.go
+++ b/vendor/code.gitea.io/git/tree_entry.go
@@ -278,13 +278,19 @@ func getNextCommitInfos(state *getCommitInfoState) error {

 func logCommand(exclusiveStartHash string, state *getCommitInfoState) *Command {
        var commitHash string
+
+       numRemainingEntries := len(state.entries) - len(state.commits)
+
        if len(exclusiveStartHash) == 0 {
                commitHash = state.headCommit.ID.String()
        } else {
-               commitHash = exclusiveStartHash + "^"
+               commitHash = exclusiveStartHash
+               if numRemainingEntries > 1 {
+                       commitHash += "^"
+               }
        }
+
        var command *Command
-       numRemainingEntries := len(state.entries) - len(state.commits)
        if numRemainingEntries < 32 {
                searchSize := (numRemainingEntries + 1) / 2
                command = NewCommand("log", prettyLogFormat, "--name-only",
@typeless commented on GitHub (Jun 23, 2017): Sorry but this problem is probably not fixed yet. Currently I made a workaround which might be the correct fix or not: ```diff diff --git a/vendor/code.gitea.io/git/tree_entry.go b/vendor/code.gitea.io/git/tree_entry.go index 7ea4d21..110f93c 100644 --- a/vendor/code.gitea.io/git/tree_entry.go +++ b/vendor/code.gitea.io/git/tree_entry.go @@ -278,13 +278,19 @@ func getNextCommitInfos(state *getCommitInfoState) error { func logCommand(exclusiveStartHash string, state *getCommitInfoState) *Command { var commitHash string + + numRemainingEntries := len(state.entries) - len(state.commits) + if len(exclusiveStartHash) == 0 { commitHash = state.headCommit.ID.String() } else { - commitHash = exclusiveStartHash + "^" + commitHash = exclusiveStartHash + if numRemainingEntries > 1 { + commitHash += "^" + } } + var command *Command - numRemainingEntries := len(state.entries) - len(state.commits) if numRemainingEntries < 32 { searchSize := (numRemainingEntries + 1) / 2 command = NewCommand("log", prettyLogFormat, "--name-only", ```
GiteaMirror commented 2025-11-02 03:38:14 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Jun 23, 2017):

@typeless could you send a PR?

@lunny commented on GitHub (Jun 23, 2017): @typeless could you send a PR?
GiteaMirror commented 2025-11-02 03:38:14 -06:00
Author
Owner
Copy Link

@typeless commented on GitHub (Jun 23, 2017):

@lunny No problem.

@typeless commented on GitHub (Jun 23, 2017): @lunny No problem.
GiteaMirror commented 2025-11-02 03:38:14 -06:00
Author
Owner
Copy Link

@ethantkoenig commented on GitHub (Jun 23, 2017):

@typeless Omitting the caret does not fix the root of the problem (and introduces a potential infinite loop). Could you share the repo where the error still occurs, so that we can diagnose what the underlying cause is?

@ethantkoenig commented on GitHub (Jun 23, 2017): @typeless Omitting the caret does not fix the root of the problem (and introduces a potential infinite loop). Could you share the repo where the error still occurs, so that we can diagnose what the underlying cause is?
GiteaMirror commented 2025-11-02 03:38:15 -06:00
Author
Owner
Copy Link

@typeless commented on GitHub (Jun 23, 2017):

@ethantkoenig I am afraid it's not possible because the repo is very large. The only thing I found suspicious is the file which causes the problem is a .gitignore which happens to have only one commit history. And based on the log I collected, the actual git command which led to the error can make the same error if I try to enter the command via CLI. A file with only one commit is actually not possible to get its parent commit using the caret.

@typeless commented on GitHub (Jun 23, 2017): @ethantkoenig I am afraid it's not possible because the repo is very large. The only thing I found suspicious is the file which causes the problem is a `.gitignore` which happens to have only one commit history. And based on the log I collected, the actual git command which led to the error can make the same error if I try to enter the command via CLI. A file with only one commit is actually not possible to get its parent commit using the caret.
GiteaMirror commented 2025-11-02 03:38:15 -06:00
Author
Owner
Copy Link

@ethantkoenig commented on GitHub (Jun 24, 2017):

@typeless Could you checkout https://github.com/ethantkoenig/gitea/tree/debug_get_commits_info (latest gitea master plus some print statements for debugging), try to view the problematic repo, and show me what gets printed?

@ethantkoenig commented on GitHub (Jun 24, 2017): @typeless Could you checkout https://github.com/ethantkoenig/gitea/tree/debug_get_commits_info (latest gitea master plus some print statements for debugging), try to view the problematic repo, and show me what gets printed?
GiteaMirror commented 2025-11-02 03:38:15 -06:00
Author
Owner
Copy Link

@typeless commented on GitHub (Jun 26, 2017):

@ethantkoenig I have to cut the rest the filenames listing otherwise it would exceed the maximum limit of the comment. Those are not interesting though, just list of the paths/filenames. (Actually, the files are too many. The server was hanging so I had to stop it manually.)

Jun 26 11:04:40 DIR-101 gitea[1039]: logCommand:
Jun 26 11:04:40 DIR-101 gitea[1039]:   state=&{entries:map[abi:0xc421f2bc80 developers:0xc421f2bf80 system:0xc421ffa5a0 build:0xc421f2be60 development:0xc421ffa000 bootable:0xc421f2bda0 device:0xc421ffa060 hardware:0xc421ffa1e0 platform_testing:0xc421ffa480 sdk:0xc421ffa540 CastDrivers:0xc421f2bb60 cts:0xc421f2bec0 external:0xc421ffa120 libcore:0xc421ffa2a0 build.sh:0xc421f2be00 dalvik:0xc421f2bf20 docs:0xc421ffa0c0 kernel:0xc421ffa240 README.md:0xc421f2bc20 libnativehelper:0xc421ffa300 frameworks:0xc421ffa180 ndk:0xc421ffa360 prebuilts:0xc421ffa4e0 vendor:0xc421ffa600 Makefile:0xc421f2bbc0 art:0xc421f2bce0 bionic:0xc421f2bd40 packages:0xc421ffa3c0 pdk:0xc421ffa420] commits:map[] lastCommitHash: lastCommit:<nil> treePath: headCommit:0xc42127d8c0 nextSearchSize:16}
Jun 26 11:04:40 DIR-101 gitea[1039]:   command=git log --pretty=format:%H --name-only -15 3fbef28b2275349d1f249a9300ef390c469c8d32 -- libnativehelper frameworks ndk art bionic packages pdk prebuilts vendor Makefile abi developers system build development bootable device hardware platform_testing CastDrivers cts external libcore sdk dalvik docs kernel README.md build.sh
Jun 26 11:04:41 DIR-101 gitea[1039]: getNextCommitInfos:
Jun 26 11:04:41 DIR-101 gitea[1039]:   stdout=
Jun 26 11:04:41 DIR-101 gitea[1039]: [[3fbef28b2275349d1f249a9300ef390c469c8d32
Jun 26 11:04:41 DIR-101 gitea[1039]: external/sepolicy/domain.te
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/AutoRebootFlag
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/NTP_Flag
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/ULDPasswordHash
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/c_library/libcaredirect/CommandLevel.c
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cast_binder_list.mk
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cpp_server/system/BnSystemService.cpp
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cpp_server/system/BnSystemService.h
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cpp_server/system/BpSystemService.cpp
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cpp_server/system/ISystemService.h
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/java_client/src/CTOS/CtSystem.java
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/java_client/src/android/binder/aidl/ISystemAPI.aidl
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/java_client/src/com/android/test.java
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/selinux/ctos_binder.te
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/selinux/system_app.te
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/system/Launcher/src/com/ctos/CastlesStart/Launcher.java
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/system/SystemPanel/Android.mk
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/system/SystemPanel/AndroidManifest.xml
Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/system/SystemPanel/res/drawable-hdpi/ic_launcher.png
@typeless commented on GitHub (Jun 26, 2017): @ethantkoenig I have to cut the rest the filenames listing otherwise it would exceed the maximum limit of the comment. Those are not interesting though, just list of the paths/filenames. (Actually, the files are too many. The server was hanging so I had to stop it manually.) ``` Jun 26 11:04:40 DIR-101 gitea[1039]: logCommand: Jun 26 11:04:40 DIR-101 gitea[1039]: state=&{entries:map[abi:0xc421f2bc80 developers:0xc421f2bf80 system:0xc421ffa5a0 build:0xc421f2be60 development:0xc421ffa000 bootable:0xc421f2bda0 device:0xc421ffa060 hardware:0xc421ffa1e0 platform_testing:0xc421ffa480 sdk:0xc421ffa540 CastDrivers:0xc421f2bb60 cts:0xc421f2bec0 external:0xc421ffa120 libcore:0xc421ffa2a0 build.sh:0xc421f2be00 dalvik:0xc421f2bf20 docs:0xc421ffa0c0 kernel:0xc421ffa240 README.md:0xc421f2bc20 libnativehelper:0xc421ffa300 frameworks:0xc421ffa180 ndk:0xc421ffa360 prebuilts:0xc421ffa4e0 vendor:0xc421ffa600 Makefile:0xc421f2bbc0 art:0xc421f2bce0 bionic:0xc421f2bd40 packages:0xc421ffa3c0 pdk:0xc421ffa420] commits:map[] lastCommitHash: lastCommit:<nil> treePath: headCommit:0xc42127d8c0 nextSearchSize:16} Jun 26 11:04:40 DIR-101 gitea[1039]: command=git log --pretty=format:%H --name-only -15 3fbef28b2275349d1f249a9300ef390c469c8d32 -- libnativehelper frameworks ndk art bionic packages pdk prebuilts vendor Makefile abi developers system build development bootable device hardware platform_testing CastDrivers cts external libcore sdk dalvik docs kernel README.md build.sh Jun 26 11:04:41 DIR-101 gitea[1039]: getNextCommitInfos: Jun 26 11:04:41 DIR-101 gitea[1039]: stdout= Jun 26 11:04:41 DIR-101 gitea[1039]: [[3fbef28b2275349d1f249a9300ef390c469c8d32 Jun 26 11:04:41 DIR-101 gitea[1039]: external/sepolicy/domain.te Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/AutoRebootFlag Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/NTP_Flag Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/ULDPasswordHash Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/c_library/libcaredirect/CommandLevel.c Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cast_binder_list.mk Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cpp_server/system/BnSystemService.cpp Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cpp_server/system/BnSystemService.h Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cpp_server/system/BpSystemService.cpp Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/cpp_server/system/ISystemService.h Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/java_client/src/CTOS/CtSystem.java Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/java_client/src/android/binder/aidl/ISystemAPI.aidl Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/cast_binder/java_client/src/com/android/test.java Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/selinux/ctos_binder.te Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/selinux/system_app.te Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/system/Launcher/src/com/ctos/CastlesStart/Launcher.java Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/system/SystemPanel/Android.mk Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/system/SystemPanel/AndroidManifest.xml Jun 26 11:04:41 DIR-101 gitea[1039]: vendor/castles/system/SystemPanel/res/drawable-hdpi/ic_launcher.png ```
GiteaMirror commented 2025-11-02 03:38:15 -06:00
Author
Owner
Copy Link

@ethantkoenig commented on GitHub (Jun 26, 2017):

@typeless Sorry, this isn't enough to debug the problem. Is the repo you're using publicly hosted somewhere? It would be helpful if I could run the problematic commands on my own machine.

@ethantkoenig commented on GitHub (Jun 26, 2017): @typeless Sorry, this isn't enough to debug the problem. Is the repo you're using publicly hosted somewhere? It would be helpful if I could run the problematic commands on my own machine.
GiteaMirror commented 2025-11-02 03:38:16 -06:00
Author
Owner
Copy Link

@typeless commented on GitHub (Jun 26, 2017):

@ethantkoenig No, it's not public hosted.

I can try to shrink it or git-filter-branch it if that can preserve the problem.

@typeless commented on GitHub (Jun 26, 2017): @ethantkoenig No, it's not public hosted. I can try to shrink it or git-filter-branch it if that can preserve the problem.
GiteaMirror commented 2025-11-02 03:38:16 -06:00
Author
Owner
Copy Link

@ethantkoenig commented on GitHub (Jun 26, 2017):

@typeless Are the repo's contents sensitive?

If the repo's contents are not sensitive, could you upload the repo to try.gitea.io?

If the repo's contents are sensitive, could you share the full log of what I had you run earlier (not here, but maybe in a Github Gist)?

@ethantkoenig commented on GitHub (Jun 26, 2017): @typeless Are the repo's contents sensitive? If the repo's contents are not sensitive, could you upload the repo to try.gitea.io? If the repo's contents are sensitive, could you share the full log of what I had you run earlier (not here, but maybe in a Github Gist)?
GiteaMirror commented 2025-11-02 03:38:16 -06:00
Author
Owner
Copy Link

@typeless commented on GitHub (Jun 27, 2017):

@ethantkoenig The repo belongs to the company I work for. So theoretically any publishment requires to go through certain managerial/bureaucratic process to get the legal permission, which I am reluctant to bother with. 😆

The good news (or bad news?) is that the problem can no longer be reproduced now. It's probably due to the changes happening to the repo. So I will close this for now.

@typeless commented on GitHub (Jun 27, 2017): @ethantkoenig The repo belongs to the company I work for. So theoretically any publishment requires to go through certain managerial/bureaucratic process to get the legal permission, which I am reluctant to bother with. 😆 The good news (or bad news?) is that the problem can no longer be reproduced now. It's probably due to the changes happening to the repo. So I will close this for now.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#835
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?