github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 18:48:08 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Can not edit/delete a file when its name starts with spaces #8316

New Issue
Closed
opened 2025-11-02 08:02:03 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 08:02:03 -06:00
Owner
Copy Link

Originally created by @wxiaoguang on GitHub (Jan 4, 2022).

  1. There are two cleanUploadFileName functions
  2. The spaces in filenames are trimmed
  3. If a file name starts with space eg: decode(%20a.txt), then it can not be edited/deleted from the web UI

@zeripath do you have any idea about why the spaces are trimmed? this change was introduced by #5702

ff2fd08228/routers/web/repo/editor.go (L733-L743)

719bddcd76/services/repository/files/file.go (L129-L140)

image

Originally created by @wxiaoguang on GitHub (Jan 4, 2022). 1. There are two `cleanUploadFileName` functions 2. The spaces in filenames are trimmed 3. If a file name starts with space eg: decode(`%20a.txt`), then it can not be edited/deleted from the web UI @zeripath do you have any idea about why the spaces are trimmed? this change was introduced by #5702 https://github.com/go-gitea/gitea/blob/ff2fd08228dd6323ac4a1cbd2f37f8ae15733eab/routers/web/repo/editor.go#L733-L743 https://github.com/go-gitea/gitea/blob/719bddcd76610a63dadc8555760072957a11cf30/services/repository/files/file.go#L129-L140 ![image](https://user-images.githubusercontent.com/2114189/148034326-78379988-6106-4011-bd4a-6e9c74583b8e.png)
GiteaMirror added the type/bug label 2025-11-02 08:02:03 -06:00
GiteaMirror commented 2025-11-02 08:02:04 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jan 17, 2022):

I think the trim can safely be dropped

@zeripath commented on GitHub (Jan 17, 2022): I think the trim can safely be dropped
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8316
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?