github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-11 17:46:29 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Add pagination to list API endpoints that do not have it yet #8281

New Issue
Open
opened 2025-11-02 08:00:50 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-02 08:00:50 -06:00
Owner
Copy Link

Originally created by @qwerty287 on GitHub (Dec 23, 2021).

  • /repos/{owner}/{repo}/issues/{index}/labels
  • /repos/{owner}/{repo}/issues/comments/{id}/reactions
  • /repos/{owner}/{repo}/branch_protections
  • /repos/{owner}/{repo}/contents
  • /repos/{owner}/{repo}/git/refs
  • /repos/{owner}/{repo}/git/refs/{ref}
  • /repos/{owner}/{repo}/hooks/git
  • /repos/{owner}/{repo}/issue_templates
  • /repos/{owner}/{repo}/releases/{id}/assets
  • /repos/{owner}/{repo}/reviewers
  • /repos/{owner}/{repo}/teams
  • /user/emails
  • /users/{username}/heatmap
  • https://codeberg.org/api/swagger#/issue/issueGetComments (add page and limit params)
  • /repos/{owner}/{repo}/git/trees/{sha} (use limit param instead of per_page)
Originally created by @qwerty287 on GitHub (Dec 23, 2021). - [ ] /repos/{owner}/{repo}/issues/{index}/labels - [ ] /repos/{owner}/{repo}/issues/comments/{id}/reactions - [ ] /repos/{owner}/{repo}/branch_protections - [ ] /repos/{owner}/{repo}/contents - [ ] /repos/{owner}/{repo}/git/refs - [ ] /repos/{owner}/{repo}/git/refs/{ref} - [ ] /repos/{owner}/{repo}/hooks/git - [ ] /repos/{owner}/{repo}/issue_templates - [ ] /repos/{owner}/{repo}/releases/{id}/assets - [ ] /repos/{owner}/{repo}/reviewers - [ ] /repos/{owner}/{repo}/teams - [ ] /user/emails - [ ] /users/{username}/heatmap - [ ] https://codeberg.org/api/swagger#/issue/issueGetComments (add `page` and `limit` params) - [ ] /repos/{owner}/{repo}/git/trees/{sha} (use `limit` param instead of `per_page`)
GiteaMirror added the type/summarymodifies/api labels 2025-11-02 08:00:50 -06:00
GiteaMirror commented 2025-11-02 08:00:51 -06:00
Author
Owner
Copy Link

@qwerty287 commented on GitHub (Dec 31, 2021):

There is also one endpoints that only support since/before params, but not page/limit`:

https://codeberg.org/api/swagger#/issue/issueGetComments

@qwerty287 commented on GitHub (Dec 31, 2021): There is also one endpoints that only support `since`/`before` params, but not `page`/limit`: https://codeberg.org/api/swagger#/issue/issueGetComments
GiteaMirror commented 2025-11-02 08:00:51 -06:00
Author
Owner
Copy Link

@qwerty287 commented on GitHub (Dec 31, 2021):

And /repos/{owner}/{repo}/git/trees/{sha} uses per_page instead oft limit, should be deprecated.

@qwerty287 commented on GitHub (Dec 31, 2021): And `/repos/{owner}/{repo}/git/trees/{sha}` uses `per_page` instead oft limit, should be deprecated.
GiteaMirror commented 2025-11-02 08:00:51 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Dec 31, 2021):

And /repos/{owner}/{repo}/git/trees/{sha} uses per_page instead oft limit, should be deprecated.

I updated your issue so that we can follow them easier. :)

@lunny commented on GitHub (Dec 31, 2021): > And `/repos/{owner}/{repo}/git/trees/{sha}` uses `per_page` instead oft limit, should be deprecated. I updated your issue so that we can follow them easier. :)
GiteaMirror commented 2025-11-02 08:00:52 -06:00
Author
Owner
Copy Link

@ChristopherHX commented on GitHub (May 4, 2025):

...3 Years later, I found this enhancement by searching for per_page after seeing an inconsistency about per_page and limit in the code

I would prefer that all gitea rest apis hide their acceptance of per_page, but do consistently accept it if no limit is in the query just for GitHub Rest Compatibility.

And /repos/{owner}/{repo}/git/trees/{sha} uses per_page instead oft limit, should be deprecated.

This still seems to be the case to not accept limit, if allowing per_page as fallback is acceptable for all paging apis I would try to fix this inconsistency.

e.g. I am implementing/testing this api of Gitea Actions 9b954d4430/pkg/scalers/github_runner_scaler.go (L681)

Uses per_page=100, which is the only accepted query parameter for pagesize on GitHub Rest api, ignoring per_page means running action runs in the past run 31 and for it's jobs are not noticed by the metric. Seems like this is to avoid rate limits of GitHub Rest by using the max pagesize and never requesting the second page (not relevant for Gitea itself). Cloning the GitHub implementation for Gitea to use limit as query parameter and allow more scopes would be possible, if I would write an integration test for keda, I guess

@ChristopherHX commented on GitHub (May 4, 2025): ...3 Years later, _I found this enhancement by searching for `per_page` after seeing an inconsistency about `per_page` and `limit` in the code_ I would prefer that all gitea rest apis hide their acceptance of `per_page`, but do consistently accept it if no `limit` is in the query just for GitHub Rest Compatibility. > And `/repos/{owner}/{repo}/git/trees/{sha}` uses `per_page` instead oft limit, should be deprecated. This still seems to be the case to not accept limit, if allowing per_page as fallback is acceptable for all paging apis I would try to fix this inconsistency. e.g. I am implementing/testing this api of Gitea Actions https://github.com/kedacore/keda/blob/9b954d4430e2530cc4bb700528e148b6baac2de7/pkg/scalers/github_runner_scaler.go#L681 Uses per_page=100, which is the only accepted query parameter for pagesize on GitHub Rest api, ignoring per_page means running action runs in the past run 31 and for it's jobs are not noticed by the metric. _Seems like this is to avoid rate limits of GitHub Rest by using the max pagesize and never requesting the second page (not relevant for Gitea itself). Cloning the GitHub implementation for Gitea to use limit as query parameter and allow more scopes would be possible, if I would write an integration test for keda, I guess_
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label modifies/api type/summary
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8281
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?