github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-10 13:56:06 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

u2f-api script should be moved to npm/webpack #8129

New Issue
Closed
opened 2025-11-02 07:54:39 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 07:54:39 -06:00
Owner
Copy Link

Originally created by @silverwind on GitHub (Nov 18, 2021).

Feature Description

There is a unversioned copy of what I think is a minified version of u2f-api that came in https://github.com/go-gitea/gitea/pull/3971. It should be moved to npm/webpack to become maintainable.

Maybe @jonasfranz can point out the source/version of this script.

Originally created by @silverwind on GitHub (Nov 18, 2021). ### Feature Description There is a [unversioned copy](https://github.com/go-gitea/gitea/blob/main/public/vendor/plugins/u2f/index.js) of what I think is a minified version of [`u2f-api`](https://github.com/grantila/u2f-api) that came in https://github.com/go-gitea/gitea/pull/3971. It should be moved to npm/webpack to become maintainable. Maybe @jonasfranz can point out the source/version of this script.
GiteaMirror commented 2025-11-02 07:54:40 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Nov 18, 2021):

I believe the code comes from https://github.com/github/u2f-api/blob/master/u2f-api-polyfill.js and its fork like https://github.com/grantila/u2f-api

Some fingerprints:

"U2F isn't supported over http, only https"
"U2F not supported"
ensureSupport
isSupported
formatRegisterRequest_

And most u2f-api we can find in npm they are all copied and modified from the same origin, they share same API interfaces, like:

@wxiaoguang commented on GitHub (Nov 18, 2021): I believe the code comes from https://github.com/github/u2f-api/blob/master/u2f-api-polyfill.js and its fork like https://github.com/grantila/u2f-api Some fingerprints: ``` "U2F isn't supported over http, only https" "U2F not supported" ensureSupport isSupported formatRegisterRequest_ ``` And most u2f-api we can find in npm they are all copied and modified from the same origin, they share same API interfaces, like: * https://www.npmjs.com/package/u2f * https://www.npmjs.com/package/u2f-api
GiteaMirror commented 2025-11-02 07:54:40 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Nov 22, 2021):

As reported in

Maybe we should refactor this module too.

@wxiaoguang commented on GitHub (Nov 22, 2021): As reported in * https://github.com/go-gitea/gitea/issues/17754 Maybe we should refactor this module too.
GiteaMirror commented 2025-11-02 07:54:40 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Nov 22, 2021):

I think it needs to be changed to use webauthn, see https://github.com/go-gitea/gitea/issues/6892.

@silverwind commented on GitHub (Nov 22, 2021): I think it needs to be changed to use webauthn, see https://github.com/go-gitea/gitea/issues/6892.
GiteaMirror commented 2025-11-02 07:54:40 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Nov 22, 2021):

@silverwind So maybe we could close this one and just continue in #6892, we could remove u2f-api and introduce webauthn in the same PR.

@lunny commented on GitHub (Nov 22, 2021): @silverwind So maybe we could close this one and just continue in #6892, we could remove u2f-api and introduce webauthn in the same PR.
GiteaMirror commented 2025-11-02 07:54:40 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Nov 22, 2021):

Yes, u2f removal can come with the webauthn addition.

@silverwind commented on GitHub (Nov 22, 2021): Yes, u2f removal can come with the webauthn addition.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8129
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?