Tracking issue: Updating golangci-lint #8088

New Issue

GiteaMirror · 2025-11-02T07:53:34-06:00

GiteaMirror commented

2025-11-02 07:53:34 -06:00

Originally created by @Gusted on GitHub (Nov 9, 2021).

This is a tracking-issue to update golangci-lint to a newer version - this is just to track which errors has to be fixed that comes up with the newer version of golangci-lint, v1.43.0.
The new update seems to catch more errors, which is always nice to have.

Somehow update the existing installs of golangci-lint with e.g. gitea CI, otherwise it will be continue using v1.37.0 (#17647)
Fix the errors that present with the newer version of golangci-lint.
- SA4023 errors from staticcheck (#17598)
- offBy1 errors from gocritic (#17606)
- badCall errors from gocritic (#17608)
Update Makefile to download the newer version by default (#17647)
Remove golint as linter, as it's been deprecated (#17609)
Check if we can add new added linters (#17610)

Originally created by @Gusted on GitHub (Nov 9, 2021). This is a tracking-issue to update golangci-lint to a newer version - this is just to track which errors has to be fixed that comes up with the newer version of golangci-lint, v1.43.0. The new update seems to catch more errors, which is always nice to have. - [x] Somehow update the existing installs of golangci-lint with e.g. gitea CI, otherwise it will be continue using v1.37.0 (#17647) - [x] Fix the errors that present with the newer version of golangci-lint. - [x] SA4023 errors from staticcheck (#17598) - [x] offBy1 errors from gocritic (#17606) - [x] badCall errors from gocritic (#17608) - [x] Update Makefile to download the newer version by default (#17647) - [x] Remove `golint` as linter, as it's been [deprecated](https://github.com/golangci/golangci-lint/pull/1965) (#17609) - [x] Check if we can add new added linters (#17610)

GiteaMirror added the topic/code-linting type/testing labels 2025-11-02 07:53:34 -06:00

GiteaMirror closed this issue

2025-11-02 07:53:35 -06:00

GiteaMirror commented

2025-11-02 07:53:35 -06:00

@wxiaoguang commented on GitHub (Nov 14, 2021):

(The issue was closed by PR merging automatically, reopen it. How to prevent the issue from being closed automatically?)

@wxiaoguang commented on GitHub (Nov 14, 2021): (The issue was closed by PR merging automatically, reopen it. How to prevent the issue from being closed automatically?)

GiteaMirror commented

2025-11-02 07:53:36 -06:00

@Gusted commented on GitHub (Nov 14, 2021):

(The issue was closed by PR merging automatically, reopen it. How to prevent the issue from being closed automatically?)

Not really, when using closing keywords on github, they will just happen. On the PRs I've on purpose add a little spelling mistake so it wont be recognized as closing keyword, this one got slipped trough.

@Gusted commented on GitHub (Nov 14, 2021): > (The issue was closed by PR merging automatically, reopen it. How to prevent the issue from being closed automatically?) Not really, when using closing keywords on github, they will just happen. On the PRs I've on purpose add a little spelling mistake so it wont be recognized as closing keyword, this one got slipped trough.

GiteaMirror commented

2025-11-02 07:53:36 -06:00

@Gusted commented on GitHub (Nov 19, 2021):

Closing

@Gusted commented on GitHub (Nov 19, 2021): Closing

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#8088