Copy button (clipboard-btn) not working in my instance #8087

@duchenpaul commented on GitHub (Nov 9, 2021):

ok, how to enable it? I tries this on two devices, no lucks
and it works for Gitea demo site

@duchenpaul commented on GitHub (Nov 9, 2021): ok, how to enable it? I tries this on two devices, no lucks and it works for Gitea demo site

GiteaMirror commented

@wxiaoguang commented on GitHub (Nov 9, 2021):

TBH, I have no idea, the code for 1.16.0+dev-474-g021df2962 is exactly the same as try.gitea.io

The copy code is pretty simple: https://github.com/go-gitea/gitea/blob/main/web_src/js/features/clipboard.js

Can you try the code in your browser?

@wxiaoguang commented on GitHub (Nov 9, 2021): TBH, I have no idea, the code for 1.16.0+dev-474-g021df2962 is exactly the same as try.gitea.io The copy code is pretty simple: https://github.com/go-gitea/gitea/blob/main/web_src/js/features/clipboard.js Can you try the code in your browser?

GiteaMirror commented

@duchenpaul commented on GitHub (Nov 9, 2021):

I enabled debug level logging in chrome, saw this error when I click copy button

[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
add @ index.js?v=66b87c123c0ab767e55d95c43d170494:62
(anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:62
each @ index.js?v=66b87c123c0ab767e55d95c43d170494:62
each @ index.js?v=66b87c123c0ab767e55d95c43d170494:62
sn @ index.js?v=66b87c123c0ab767e55d95c43d170494:62
on @ index.js?v=66b87c123c0ab767e55d95c43d170494:62
events @ index.js?v=66b87c123c0ab767e55d95c43d170494:1
initialize @ index.js?v=66b87c123c0ab767e55d95c43d170494:1
(anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:1
each @ index.js?v=66b87c123c0ab767e55d95c43d170494:62
each @ index.js?v=66b87c123c0ab767e55d95c43d170494:62
l.fn.popup @ index.js?v=66b87c123c0ab767e55d95c43d170494:1
jh @ index.js?v=66b87c123c0ab767e55d95c43d170494:25
(anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:25
(anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:25
Dc @ index.js?v=66b87c123c0ab767e55d95c43d170494:25
(anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:25

@duchenpaul commented on GitHub (Nov 9, 2021): I enabled debug level logging in chrome, saw this error when I click copy button ``` [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952 add @ index.js?v=66b87c123c0ab767e55d95c43d170494:62 (anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:62 each @ index.js?v=66b87c123c0ab767e55d95c43d170494:62 each @ index.js?v=66b87c123c0ab767e55d95c43d170494:62 sn @ index.js?v=66b87c123c0ab767e55d95c43d170494:62 on @ index.js?v=66b87c123c0ab767e55d95c43d170494:62 events @ index.js?v=66b87c123c0ab767e55d95c43d170494:1 initialize @ index.js?v=66b87c123c0ab767e55d95c43d170494:1 (anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:1 each @ index.js?v=66b87c123c0ab767e55d95c43d170494:62 each @ index.js?v=66b87c123c0ab767e55d95c43d170494:62 l.fn.popup @ index.js?v=66b87c123c0ab767e55d95c43d170494:1 jh @ index.js?v=66b87c123c0ab767e55d95c43d170494:25 (anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:25 (anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:25 Dc @ index.js?v=66b87c123c0ab767e55d95c43d170494:25 (anonymous) @ index.js?v=66b87c123c0ab767e55d95c43d170494:25 ```

GiteaMirror commented

@duchenpaul commented on GitHub (Nov 9, 2021):

Will this help? if you can read chinese
https://www.coder.work/article/943540

@duchenpaul commented on GitHub (Nov 9, 2021): Will this help? if you can read chinese https://www.coder.work/article/943540

GiteaMirror commented

@wxiaoguang commented on GitHub (Nov 9, 2021):

Not related. If you can not find some methods to reproduce this problem, it would be difficult to continue to debug, since it works on try.gitea.io, the same code.

@wxiaoguang commented on GitHub (Nov 9, 2021): Not related. If you can not find some methods to reproduce this problem, it would be difficult to continue to debug, since it works on try.gitea.io, the same code.

GiteaMirror commented

43bbc54783/web_src/js/features/clipboard.js (L25-L46)

@silverwind commented on GitHub (Nov 10, 2021):

Might be an issue with the clipboard fallback code that was recently added. I see the instance is running on http, so the code will definitely branch to the fallback because navigator.clipboard.writeText is not enabled on non-https origins:

cc: @tech-meppem

@silverwind commented on GitHub (Nov 10, 2021): Might be an issue with the clipboard fallback code that was recently added. I see the instance is running on `http`, so the code will definitely branch to the fallback because `navigator.clipboard.writeText` is not enabled on non-https origins: https://github.com/go-gitea/gitea/blob/43bbc5478370cbfe3ab1eed730ea002ccec74708/web_src/js/features/clipboard.js#L25-L46 cc: @tech-meppem

GiteaMirror commented

@silverwind commented on GitHub (Nov 10, 2021):

Can't reproduce. Fallback works fine for me on all major browsers. What version of Chrome is this observed on and does it work in other browsers?

@silverwind commented on GitHub (Nov 10, 2021): Can't reproduce. Fallback works fine for me on all major browsers. What version of Chrome is this observed on and does it work in other browsers?

GiteaMirror commented

@tech-meppem commented on GitHub (Nov 10, 2021):

This is what I attempted for my fix, because this is what happens on non-https sites.
Are you using your site via Https?
If not, then the copy to clipboard won't work for anything.

or at least, unless you have the fix stated above merged in, which I don't know which version it's actually going to be included in.

@tech-meppem commented on GitHub (Nov 10, 2021): This is what I attempted for my fix, because this is what happens on non-https sites. Are you using your site via Https? If not, then the copy to clipboard won't work for anything. or at least, unless you have the fix stated above merged in, which I don't know which version it's actually going to be included in.

GiteaMirror commented

@silverwind commented on GitHub (Nov 10, 2021):

OPs version above indicates they have a version with the fix included. Might be worth a try to clear browser cache and try again.

@silverwind commented on GitHub (Nov 10, 2021): OPs version above indicates they have a version with the fix included. Might be worth a try to clear browser cache and try again.

GiteaMirror commented

@duchenpaul commented on GitHub (Nov 11, 2021):

Yes, that was my thought as well, I am using http instead of https

@duchenpaul commented on GitHub (Nov 11, 2021): Yes, that was my thought as well, I am using http instead of https

GiteaMirror commented

@duchenpaul commented on GitHub (Nov 11, 2021):

Using incognico mode not helping as well, and I cannot find anywhere to see the error, including chrome console

@duchenpaul commented on GitHub (Nov 11, 2021): Using incognico mode not helping as well, and I cannot find anywhere to see the error, including chrome console

GiteaMirror commented

@duchenpaul commented on GitHub (Nov 11, 2021):

Correction:
My gitea version is Gitea Version: 1.15.6

@duchenpaul commented on GitHub (Nov 11, 2021): Correction: My gitea version is `Gitea Version: 1.15.6`

GiteaMirror commented

@wxiaoguang commented on GitHub (Nov 11, 2021):

Please make sure you are using the correct version. The clipboard for non-https was fixed in 1.16

@wxiaoguang commented on GitHub (Nov 11, 2021): Please make sure you are using the correct version. The clipboard for non-https was fixed in 1.16

GiteaMirror commented