github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Batch calling of updateIssuesMeta causes database deadlock #8037

New Issue
Closed
opened 2025-11-02 07:51:54 -06:00 by GiteaMirror · 8 comments
GiteaMirror commented 2025-11-02 07:51:54 -06:00
Owner
Copy Link

Originally created by @wxiaoguang on GitHub (Oct 28, 2021).

Gitea Version

dev(main)

Description

Bug:

141d1a2aa5/web_src/js/features/repo-legacy.js (L87-L91)

It causes database deadlock and results in error response (some data can not be updated correctly, and the page can not be reloaded)

2021/10/28 17:51:22 .../repo/issue_label.go:209:UpdateIssueLabel() [E] RemoveLabel: Error 1213: Deadlock found when trying to get lock; try restarting transaction
2021/10/28 17:51:23 Completed POST /root/test/issues/labels 500 Internal Server Error in 421.528354ms
Originally created by @wxiaoguang on GitHub (Oct 28, 2021). ### Gitea Version dev(main) ### Description Bug: https://github.com/go-gitea/gitea/blob/141d1a2aa5ff31267661c1985f52e6c02eafea11/web_src/js/features/repo-legacy.js#L87-L91 It causes database deadlock and results in error response (some data can not be updated correctly, and the page can not be reloaded) ``` 2021/10/28 17:51:22 .../repo/issue_label.go:209:UpdateIssueLabel() [E] RemoveLabel: Error 1213: Deadlock found when trying to get lock; try restarting transaction 2021/10/28 17:51:23 Completed POST /root/test/issues/labels 500 Internal Server Error in 421.528354ms ```
GiteaMirror added the topic/uiissue/confirmedtype/bug labels 2025-11-02 07:51:54 -06:00
GiteaMirror commented 2025-11-02 07:51:55 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 28, 2021):

Blocked by

I do not want to make huge conflicts between PRs.

@wxiaoguang commented on GitHub (Oct 28, 2021): Blocked by * https://github.com/go-gitea/gitea/pull/17386 I do not want to make huge conflicts between PRs.
GiteaMirror commented 2025-11-02 07:51:55 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Oct 28, 2021):

It seems it's also a backend bug.

@lunny commented on GitHub (Oct 28, 2021): It seems it's also a backend bug.
GiteaMirror commented 2025-11-02 07:51:56 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 28, 2021):

The bug is mostly related to frontend, the concurrency API calls are incorrect.

For backend, not that related, the only thing it can do is wrapping the deadlock error and returning a friendly error response. The deadlocks can not be fully avoided in normal cases.

@wxiaoguang commented on GitHub (Oct 28, 2021): The bug is mostly related to frontend, the concurrency API calls are incorrect. For backend, not that related, the only thing it can do is wrapping the deadlock error and returning a friendly error response. The deadlocks can not be fully avoided in normal cases.
GiteaMirror commented 2025-11-02 07:51:56 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Oct 28, 2021):

The db should never deadlock - this is a backend bug.

@zeripath commented on GitHub (Oct 28, 2021): The db should never deadlock - this is a backend bug.
GiteaMirror commented 2025-11-02 07:51:56 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 28, 2021):

The db should never deadlock - this is a backend bug.

If two users update the same records at the same time with transactions, the database may report a dead lock. It is a correct database behavior.

Database deadlock is not the same as code deadlock. If you need more information, I can explain more.

For this problem (deadlock in UpdateIssueLabel), it's difficult to make a lock-safe transaction, because the logic is pretty complicated, many inserts and updates. However, if we can make the frontend send the updated labels in one request, then there will be no dead lock problem for most cases, except two users are updating the same issue at the same time (in such case, reporting an error to end user is also a good choice to prevent they overwrite other's labels).

@wxiaoguang commented on GitHub (Oct 28, 2021): > The db should never deadlock - this is a backend bug. If two users update the same records at the same time with transactions, the database may report a dead lock. It is a correct database behavior. Database deadlock is not the same as code deadlock. If you need more information, I can explain more. For this problem (deadlock in `UpdateIssueLabel`), it's difficult to make a lock-safe transaction, because the logic is pretty complicated, many inserts and updates. However, if we can make the frontend send the updated labels in one request, then there will be no dead lock problem for most cases, except two users are updating the same issue at the same time (in such case, reporting an error to end user is also a good choice to prevent they overwrite other's labels).
GiteaMirror commented 2025-11-02 07:51:57 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Nov 15, 2021):

Is this resolved?

@lunny commented on GitHub (Nov 15, 2021): Is this resolved?
GiteaMirror commented 2025-11-02 07:51:57 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Nov 15, 2021):

Not yet, I haven't got time for this. (If someone can help that's also very welcome)

@wxiaoguang commented on GitHub (Nov 15, 2021): Not yet, I haven't got time for this. (If someone can help that's also very welcome)
GiteaMirror commented 2025-11-02 07:51:58 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Nov 15, 2021):

I proposed a simple fix, please review.

@wxiaoguang commented on GitHub (Nov 15, 2021): I proposed a simple fix, please review.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed topic/ui type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8037
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?