github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Issue comment URLs parsed / emitted incorrectly #8006

New Issue
Closed
opened 2025-11-02 07:47:43 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 07:47:43 -06:00
Owner
Copy Link

Originally created by @noerw on GitHub (Oct 21, 2021).

Gitea Version

a115309f4 (current 1.16), but I observed this since early in the 1.16 dev cycle

Git Version

No response

Operating System

No response

How are you running Gitea?

try.gitea.io

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

https://try.gitea.io/noerw/hochwasser/issues/5

Description

Issue comment references don't get parsed correctly, when it isn't the last thing on the line.
Looks like the HTML emitted is wrong, the word following the link is missing. The href is empty.
See try.gitea.io link above.

Screenshots

No response

Originally created by @noerw on GitHub (Oct 21, 2021). ### Gitea Version a115309f4 (current 1.16), but I observed this since early in the 1.16 dev cycle ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? try.gitea.io ### Database _No response_ ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist https://try.gitea.io/noerw/hochwasser/issues/5 ### Description Issue comment references don't get parsed correctly, when it isn't the last thing on the line. Looks like the HTML emitted is wrong, the word following the link is missing. The href is empty. See try.gitea.io link above. ### Screenshots _No response_
GiteaMirror added the outdated/theme/markdowntype/bug labels 2025-11-02 07:47:43 -06:00
GiteaMirror commented 2025-11-02 07:47:48 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 22, 2021):

Somehow related to https://github.com/go-gitea/gitea/pull/17398 , maybe the code can be improved more.

It is a Markdown rendering problem.

@wxiaoguang commented on GitHub (Oct 22, 2021): ~~Somehow related to https://github.com/go-gitea/gitea/pull/17398 , maybe the code can be improved more.~~ It is a Markdown rendering problem.
GiteaMirror commented 2025-11-02 07:47:50 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 23, 2021):

The problem is caused by the wrong HTML generated.

For example:

http://127.0.0.1:3000/root/test/issues/1#comment test

The genrated HTML is

<p><a href="http://127.0.0.1:3000/root/test/issues/1#comment test" class="ref-issue">#1</a></p>

Then SanitizeReader removes the invalid href.

@wxiaoguang commented on GitHub (Oct 23, 2021): The problem is caused by the wrong HTML generated. For example: ``` http://127.0.0.1:3000/root/test/issues/1#comment test ``` The genrated HTML is ``` <p><a href="http://127.0.0.1:3000/root/test/issues/1#comment test" class="ref-issue">#1</a></p> ``` Then SanitizeReader removes the invalid href.
GiteaMirror commented 2025-11-02 07:47:52 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 23, 2021):

Fixed in https://github.com/go-gitea/gitea/pull/17404

@wxiaoguang commented on GitHub (Oct 23, 2021): Fixed in https://github.com/go-gitea/gitea/pull/17404
GiteaMirror commented 2025-11-02 07:47:53 -06:00
Author
Owner
Copy Link

@noerw commented on GitHub (Oct 23, 2021):

just noted that 1.15.5 is affected too

@noerw commented on GitHub (Oct 23, 2021): just noted that 1.15.5 is affected too
GiteaMirror commented 2025-11-02 07:47:55 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 23, 2021):

Yep, this is a very old bug, we can make a backport then

@wxiaoguang commented on GitHub (Oct 23, 2021): Yep, this is a very old bug, we can make a backport then
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label outdated/theme/markdown type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#8006
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?