Different users with same e-mail causes error on create repositores and user creation from register #8

@strk commented on GitHub (Nov 3, 2016):

I think forbidding multiple users with same email could be a good idea, in general.

@strk commented on GitHub (Nov 3, 2016): I think forbidding multiple users with same email could be a good idea, in general.

GiteaMirror commented

@joubertredrat commented on GitHub (Nov 3, 2016):

@strk If define email as UNIQUE in database and creates validation solves the problem

@joubertredrat commented on GitHub (Nov 3, 2016): @strk If define email as UNIQUE in database and creates validation solves the problem

GiteaMirror commented

@lunny commented on GitHub (Nov 3, 2016):

An unique maybe not a good idea since there are the same email. It will result in the gitea can not start.

@lunny commented on GitHub (Nov 3, 2016): An unique maybe not a good idea since there are the same email. It will result in the gitea can not start.

GiteaMirror commented

@strk commented on GitHub (Nov 3, 2016):

@lunny that's a migration/upgrade problem, yes, but if we think same-email should not be allowed, it would be useful to start preventing that for future accounts at least. Of course it's also important for code to be tolerant to unexpected database states.

@strk commented on GitHub (Nov 3, 2016): @lunny that's a migration/upgrade problem, yes, but if we think same-email should not be allowed, it would be useful to start preventing that for _future_ accounts at least. Of course it's also important for code to be tolerant to unexpected database states.

GiteaMirror commented

@lunny commented on GitHub (Nov 4, 2016):

If user already have same emails on gitea/gogs database, when he upgrade gitea to the new version, it will report a migration error and will not start the service. At this situation, user MUST change the user's email on the database manually. That's not our expected situation. So we have to resolve this before we add an unique tag on email field.

@lunny commented on GitHub (Nov 4, 2016): If user already have same emails on gitea/gogs database, when he upgrade gitea to the new version, it will report a migration error and will not start the service. At this situation, user MUST change the user's email on the database manually. That's not our expected situation. So we have to resolve this before we add an unique tag on email field.

GiteaMirror commented

@bkcsoft commented on GitHub (Nov 4, 2016):

If define email as UNIQUE in database and creates validation solves the problem

Like @lunny says, I've seen people (and bugs related to) use the same email for several accounts so a migration would be necessary.

Proposed migration flow:

No Collisions

Currently at v0.9
Upgrade to v1.1.0 (current milestone for this issue)
Migration runs on start
No duplicate emails found, Gogs starts as usual

Collisions

Currently at v0.9
Upgrade to v1.1.0 (current milestone for this issue)
Migration runs on start
Duplicate emails found, Gogs fails migration and throws an Error

PREFERED No Collisions

Currently at v0.9
Upgrade to v1.1.0 (current milestone for this issue)
Migration runs on start
No duplicate emails found, Gogs starts in Maintenance-mode, requiring Admins for login. Everything locked down except for settings.

Preferred way required Maintenance-mode (which hasn't been requested but would be nice :trollface: )

@bkcsoft commented on GitHub (Nov 4, 2016): > If define email as UNIQUE in database and creates validation solves the problem Like @lunny says, I've seen people (and bugs related to) use the same email for several accounts so a migration would be necessary. ### Proposed migration flow: #### No Collisions - Currently at v0.9 - Upgrade to v1.1.0 (current milestone for this issue) - Migration runs on start - No duplicate emails found, Gogs starts as usual #### Collisions - Currently at v0.9 - Upgrade to v1.1.0 (current milestone for this issue) - Migration runs on start - Duplicate emails found, Gogs fails migration and throws an Error #### **PREFERED** No Collisions - Currently at v0.9 - Upgrade to v1.1.0 (current milestone for this issue) - Migration runs on start - ~No~ duplicate emails found, **Gogs starts in `Maintenance`-mode**, requiring Admins for login. Everything locked down _except_ for settings. Preferred way required Maintenance-mode (which hasn't been requested but would be nice :trollface: )

GiteaMirror commented

@strk commented on GitHub (Nov 7, 2016):

@bkcsoft you mean Duplicate emails found in the last bullet, right ?

I think we should go there incrementally, and the first step is preventing the registration of users with the same email as other users. From the original report in this ticket there is an attempt in code to prevent that (see how second user could not register with same email) but evidently not all code paths do check for that occurrence.

@strk commented on GitHub (Nov 7, 2016): @bkcsoft you mean `Duplicate emails found` in the last bullet, right ? I think we should go there incrementally, and the first step is preventing the registration of users with the same email as other users. From the original report in this ticket there is an attempt in code to prevent that (see how second user could not register with same email) but evidently not all code paths do check for that occurrence.

GiteaMirror commented

@bkcsoft commented on GitHub (Dec 12, 2016):

@strk Correct. Changed the text now 😆

Indeed it should be done incrementally, could you have a look at that? 🙂

@bkcsoft commented on GitHub (Dec 12, 2016): @strk Correct. Changed the text now 😆 Indeed it should be done incrementally, could you have a look at that? 🙂

GiteaMirror commented

@richmahn commented on GitHub (Dec 14, 2016):

Any work been done on this? We are needing to fix the problem as we have many people signing up through the API and they sometimes use the same email address, forgetting they are already in our system but with a different username.

@richmahn commented on GitHub (Dec 14, 2016): Any work been done on this? We are needing to fix the problem as we have many people signing up through the API and they sometimes use the same email address, forgetting they are already in our system but with a different username.

GiteaMirror commented

@lunny commented on GitHub (Dec 15, 2016):

We maybe fix this on 1.1. We would like to limit email should be uniqued. So that every user have to use different email. Maybe you can ask your guys to change their email address?

@lunny commented on GitHub (Dec 15, 2016): We maybe fix this on 1.1. We would like to limit email should be uniqued. So that every user have to use different email. Maybe you can ask your guys to change their email address?

GiteaMirror commented

@strk commented on GitHub (Dec 15, 2016):

Richard, are you able to provide a patch or pay someone to do so ?

@strk commented on GitHub (Dec 15, 2016): Richard, are you able to provide a patch or pay someone to do so ?

GiteaMirror commented

@richmahn commented on GitHub (Dec 15, 2016):

@strk: We work on Gogs as a company, but mainly our own customizations (click on my above issue I made for our developers to see our repo, which is tailored for content editing and content linking/scrubbing/etc. rather than coding), but do try to do what we can for upstream (gitea), so if we tackle the issue I made, we will do it for upstream.

@lunny: Every time the 500 error comes up, we finally (hopefully more quickly now than before) realize it is this bug and have to make a quick email change. I guess we need to somehow search for the email address from the app/api before signing someone up for now.

@richmahn commented on GitHub (Dec 15, 2016): @strk: We work on Gogs as a company, but mainly our own customizations (click on my above issue I made for our developers to see our repo, which is tailored for content editing and content linking/scrubbing/etc. rather than coding), but do try to do what we can for upstream (gitea), so if we tackle the issue I made, we will do it for upstream. @lunny: Every time the 500 error comes up, we finally (hopefully more quickly now than before) realize it is this bug and have to make a quick email change. I guess we need to somehow search for the email address from the app/api before signing someone up for now.

GiteaMirror commented

@simonszu commented on GitHub (Feb 8, 2017):

I have noticed a similar behaviour which is somehow related to the duplicate-email-issue.
I have set up a fresh instance of gitea without migrating from gogits. I have created two users with different email addresses but changed one user's mail address to the other's after that.

The result is an Error 500 every time one of these users try to login. However, the session starts up fine, and if you manually navigate to the logged in user's dashboard, it seems to work - until you go and view the commit history of a repo or single file and try to view an older commit. There you get an Error 500 as well which is not workaroundable.

So i think a unique flag for email addresses and enforcing it at registration or in the user control panel would be the best solution.

@simonszu commented on GitHub (Feb 8, 2017): I have noticed a similar behaviour which is somehow related to the duplicate-email-issue. I have set up a fresh instance of gitea without migrating from gogits. I have created two users with different email addresses but changed one user's mail address to the other's after that. The result is an Error 500 every time one of these users try to login. However, the session starts up fine, and if you manually navigate to the logged in user's dashboard, it seems to work - until you go and view the commit history of a repo or single file and try to view an older commit. There you get an Error 500 as well which is not workaroundable. So i think a unique flag for email addresses and enforcing it at registration or in the user control panel would be the best solution.

GiteaMirror commented

@lunny commented on GitHub (Feb 17, 2017):

@simonszu which version have you installed?

@lunny commented on GitHub (Feb 17, 2017): @simonszu which version have you installed?

GiteaMirror commented

@simonszu commented on GitHub (Feb 20, 2017):

@lunny I am a bit surprised that my installation does not report any version number, but a commit hash. It is Version: 6aacf4d. I installed it around Febrary 6th, 2017.

@simonszu commented on GitHub (Feb 20, 2017): @lunny I am a bit surprised that my installation does not report any version number, but a commit hash. It is Version: 6aacf4d. I installed it around Febrary 6th, 2017.

GiteaMirror commented