github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Apostrophe shows as HTML entity when adding user to organization #7995

New Issue
Closed
opened 2025-11-02 07:45:18 -06:00 by GiteaMirror · 9 comments
GiteaMirror commented 2025-11-02 07:45:18 -06:00
Owner
Copy Link

Originally created by @jhult on GitHub (Oct 19, 2021).

Gitea Version

1.15.3

Git Version

2.30.2

Operating System

alpine

How are you running Gitea?

Docker via gitea/gitea:latest-rootless

Database

SQLite

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

Create a user with an apostrophe in their name. Add them to an organization. Notice that the apostrophe is shown as the HTML entity (').

Cannot test on try.gitea.io since I need permissions (which I don't have) to add the user to an organization.

User is coming from an OpenID registry.

Screenshots

No response

Originally created by @jhult on GitHub (Oct 19, 2021). ### Gitea Version 1.15.3 ### Git Version 2.30.2 ### Operating System alpine ### How are you running Gitea? Docker via `gitea/gitea:latest-rootless` ### Database SQLite ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Description Create a user with an apostrophe in their name. Add them to an organization. Notice that the apostrophe is shown as the HTML entity (`'`). Cannot test on try.gitea.io since I need permissions (which I don't have) to add the user to an organization. User is coming from an OpenID registry. ### Screenshots _No response_
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 07:45:18 -06:00
GiteaMirror commented 2025-11-02 07:45:24 -06:00
Author
Owner
Copy Link

@jhult commented on GitHub (Oct 19, 2021):

Related issue: #2122

@jhult commented on GitHub (Oct 19, 2021): Related issue: #2122
GiteaMirror commented 2025-11-02 07:45:26 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Oct 19, 2021):

Able to duplicate at least partially on try.gitea.io https://try.gitea.io/org/testOrf/teams/testorf-test-team:

Screenshot from 2021-10-19 22-26-36

Screenshot from 2021-10-19 22-27-10

Screenshot from 2021-10-19 22-27-33

@zeripath commented on GitHub (Oct 19, 2021): Able to duplicate at least partially on try.gitea.io https://try.gitea.io/org/testOrf/teams/testorf-test-team: ![Screenshot from 2021-10-19 22-26-36](https://user-images.githubusercontent.com/1824502/137993097-66d1332e-1891-4292-8b18-74ac16643ce1.png) ![Screenshot from 2021-10-19 22-27-10](https://user-images.githubusercontent.com/1824502/137993153-312ae1f4-4b0d-4bce-951e-dea6042e0bab.png) ![Screenshot from 2021-10-19 22-27-33](https://user-images.githubusercontent.com/1824502/137993208-d4f89360-5bd3-4bf9-8e19-2ff51fac81af.png)
GiteaMirror commented 2025-11-02 07:45:28 -06:00
Author
Owner
Copy Link

@jhult commented on GitHub (Oct 19, 2021):

Thanks @zeripath for confirming.

@jhult commented on GitHub (Oct 19, 2021): Thanks @zeripath for confirming.
GiteaMirror commented 2025-11-02 07:45:30 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Oct 19, 2021):

@jhult are the two places I've demonstrated the only places where it happens? I.e. it's just in the drop-downs?

@zeripath commented on GitHub (Oct 19, 2021): @jhult are the two places I've demonstrated the only places where it happens? I.e. it's just in the drop-downs?
GiteaMirror commented 2025-11-02 07:45:31 -06:00
Author
Owner
Copy Link

@jhult commented on GitHub (Oct 20, 2021):

@zeripath, yes the issue appears to only occur in drop-downs.

@jhult commented on GitHub (Oct 20, 2021): @zeripath, yes the issue appears to only occur in drop-downs.
GiteaMirror commented 2025-11-02 07:45:33 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Oct 20, 2021):

Hmm... the problem is:

35b918f574/modules/convert/user.go (L52)

This makes the strange assumption that'd we'd want users Full Names to be renderable...

@zeripath commented on GitHub (Oct 20, 2021): Hmm... the problem is: https://github.com/go-gitea/gitea/blob/35b918f574464eeca89fcf0d5f3a07a58a4b5a38/modules/convert/user.go#L52 This makes the strange assumption that'd we'd want users Full Names to be renderable...
GiteaMirror commented 2025-11-02 07:45:35 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Oct 20, 2021):

I'm not sure that we actually allow this.

@zeripath commented on GitHub (Oct 20, 2021): I'm not sure that we actually allow this.
GiteaMirror commented 2025-11-02 07:45:36 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 23, 2021):

Can this issue be closed? The PR is merged.

@wxiaoguang commented on GitHub (Oct 23, 2021): Can this issue be closed? The PR is merged.
GiteaMirror commented 2025-11-02 07:45:38 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Oct 24, 2021):

I don't think we can backport the fixing PR as it's technically breaking. Therefore I'm removing this from 1.15.6 milestone and moving it to 1.16

@zeripath commented on GitHub (Oct 24, 2021): I don't think we can backport the fixing PR as it's technically breaking. Therefore I'm removing this from 1.15.6 milestone and moving it to 1.16
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#7995
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?