Internal Server Error /pulls runtime error: invalid memory address or nil pointer dereference #7901

Closed
opened 2025-11-02 07:40:55 -06:00 by GiteaMirror · 6 comments
Owner

Originally created by @FalseNegative on GitHub (Sep 27, 2021).

Gitea Version

1.15.3

Git Version

2.26.3

Operating System

Docker

How are you running Gitea?

Docker

Database

PostgreSQL

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

When opening the pull requests section I get an Internal Server Error.
E.g. https://domain/pulls

Logs:

2021/09/27 16:56:30 routers/web/base.go:131:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference
        /usr/local/go/src/runtime/panic.go:212 (0x4ba7b)
        /usr/local/go/src/runtime/signal_unix.go:734 (0x6642b)
        /build/models/pull.go:331 (0x16ba8f8)
        /build/services/pull/pull.go:747 (0x16ba8e4)
        /build/services/pull/pull.go:721 (0x16ba5d3)
        /build/routers/web/user/home.go:568 (0x1949a67)
        /build/routers/web/user/home.go:351 (0x194907f)
        /build/modules/web/route.go:64 (0x17d210f)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x17eeae3)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/context/context.go:776 (0x10349ff)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b)
        /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/web/base.go:186 (0x19abca3)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/gitea.com/go-chi/session/session.go:256 (0xe6d53b)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/public/public.go:42 (0xfaef0b)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b)
        /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/common/middleware.go:72 (0x17f29bb)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/common/logger.go:23 (0x17f1dd7)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x17ef207)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x17eb347)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/common/middleware.go:25 (0x17f25af)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:87 (0x10177f7)
        /build/modules/web/route.go:318 (0x17d18a7)
        /build/vendor/github.com/gorilla/context/context.go:141 (0xbeda17)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /usr/local/go/src/net/http/server.go:2887 (0x343893)
        /usr/local/go/src/net/http/server.go:1952 (0x33fc0b)
        /usr/local/go/src/runtime/asm_arm.s:841 (0x85873)
2021/09/27 16:56:30 ...common/middleware.go:64:1() [E] PANIC: interface conversion: interface {} is nil, not *context.APIContext
        /usr/local/go/src/runtime/iface.go:261 (0x1fb87)
        /build/modules/context/api.go:135 (0x19abbcb)
        /build/routers/web/base.go:151 (0x19ab3bc)
        /usr/local/go/src/runtime/panic.go:965 (0x4d74b)
        /usr/local/go/src/runtime/panic.go:212 (0x4ba7b)
        /usr/local/go/src/runtime/signal_unix.go:734 (0x6642b)
        /build/models/pull.go:331 (0x16ba8f8)
        /build/services/pull/pull.go:747 (0x16ba8e4)
        /build/services/pull/pull.go:721 (0x16ba5d3)
        /build/routers/web/user/home.go:568 (0x1949a67)
        /build/routers/web/user/home.go:351 (0x194907f)
        /build/modules/web/route.go:64 (0x17d210f)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x17eeae3)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/context/context.go:776 (0x10349ff)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b)
        /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/web/base.go:186 (0x19abca3)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/gitea.com/go-chi/session/session.go:256 (0xe6d53b)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/public/public.go:42 (0xfaef0b)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b)
        /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/common/middleware.go:72 (0x17f29bb)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/common/logger.go:23 (0x17f1dd7)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x17ef207)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x17eb347)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/common/middleware.go:25 (0x17f25af)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:87 (0x10177f7)
        /build/modules/web/route.go:318 (0x17d18a7)
        /build/vendor/github.com/gorilla/context/context.go:141 (0xbeda17)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /usr/local/go/src/net/http/server.go:2887 (0x343893)
        /usr/local/go/src/net/http/server.go:1952 (0x33fc0b)
        /usr/local/go/src/runtime/asm_arm.s:841 (0x85873)

Screenshots

No response

Originally created by @FalseNegative on GitHub (Sep 27, 2021). ### Gitea Version 1.15.3 ### Git Version 2.26.3 ### Operating System Docker ### How are you running Gitea? Docker ### Database PostgreSQL ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Description When opening the pull requests section I get an Internal Server Error. E.g. https://domain/pulls Logs: ``` 2021/09/27 16:56:30 routers/web/base.go:131:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference /usr/local/go/src/runtime/panic.go:212 (0x4ba7b) /usr/local/go/src/runtime/signal_unix.go:734 (0x6642b) /build/models/pull.go:331 (0x16ba8f8) /build/services/pull/pull.go:747 (0x16ba8e4) /build/services/pull/pull.go:721 (0x16ba5d3) /build/routers/web/user/home.go:568 (0x1949a67) /build/routers/web/user/home.go:351 (0x194907f) /build/modules/web/route.go:64 (0x17d210f) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x17eeae3) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/context/context.go:776 (0x10349ff) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b) /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/web/base.go:186 (0x19abca3) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/gitea.com/go-chi/session/session.go:256 (0xe6d53b) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/public/public.go:42 (0xfaef0b) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b) /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/common/middleware.go:72 (0x17f29bb) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/common/logger.go:23 (0x17f1dd7) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x17ef207) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x17eb347) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/common/middleware.go:25 (0x17f25af) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:87 (0x10177f7) /build/modules/web/route.go:318 (0x17d18a7) /build/vendor/github.com/gorilla/context/context.go:141 (0xbeda17) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /usr/local/go/src/net/http/server.go:2887 (0x343893) /usr/local/go/src/net/http/server.go:1952 (0x33fc0b) /usr/local/go/src/runtime/asm_arm.s:841 (0x85873) ``` ``` 2021/09/27 16:56:30 ...common/middleware.go:64:1() [E] PANIC: interface conversion: interface {} is nil, not *context.APIContext /usr/local/go/src/runtime/iface.go:261 (0x1fb87) /build/modules/context/api.go:135 (0x19abbcb) /build/routers/web/base.go:151 (0x19ab3bc) /usr/local/go/src/runtime/panic.go:965 (0x4d74b) /usr/local/go/src/runtime/panic.go:212 (0x4ba7b) /usr/local/go/src/runtime/signal_unix.go:734 (0x6642b) /build/models/pull.go:331 (0x16ba8f8) /build/services/pull/pull.go:747 (0x16ba8e4) /build/services/pull/pull.go:721 (0x16ba5d3) /build/routers/web/user/home.go:568 (0x1949a67) /build/routers/web/user/home.go:351 (0x194907f) /build/modules/web/route.go:64 (0x17d210f) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x17eeae3) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/context/context.go:776 (0x10349ff) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b) /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/web/base.go:186 (0x19abca3) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/gitea.com/go-chi/session/session.go:256 (0xe6d53b) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/public/public.go:42 (0xfaef0b) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b) /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/common/middleware.go:72 (0x17f29bb) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/common/logger.go:23 (0x17f1dd7) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x17ef207) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x17eb347) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/common/middleware.go:25 (0x17f25af) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:87 (0x10177f7) /build/modules/web/route.go:318 (0x17d18a7) /build/vendor/github.com/gorilla/context/context.go:141 (0xbeda17) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /usr/local/go/src/net/http/server.go:2887 (0x343893) /usr/local/go/src/net/http/server.go:1952 (0x33fc0b) /usr/local/go/src/runtime/asm_arm.s:841 (0x85873) ``` ### Screenshots _No response_
GiteaMirror added the type/bug label 2025-11-02 07:40:55 -06:00
Author
Owner

@lunny commented on GitHub (Sep 28, 2021):

The first panic is not fixed by #17169. It's wired because https://github.com/go-gitea/gitea/blob/main/services/pull/pull.go#L721 has already loads all pullrequests of issues. It should not panic.

2021/09/27 16:56:30 routers/web/base.go:131:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference
        /usr/local/go/src/runtime/panic.go:212 (0x4ba7b)
        /usr/local/go/src/runtime/signal_unix.go:734 (0x6642b)
        /build/models/pull.go:331 (0x16ba8f8)
        /build/services/pull/pull.go:747 (0x16ba8e4)
        /build/services/pull/pull.go:721 (0x16ba5d3)
        /build/routers/web/user/home.go:568 (0x1949a67)
        /build/routers/web/user/home.go:351 (0x194907f)
        /build/modules/web/route.go:64 (0x17d210f)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x17eeae3)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/web/route.go:103 (0x17d2767)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/context/context.go:776 (0x10349ff)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b)
        /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/web/base.go:186 (0x19abca3)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/gitea.com/go-chi/session/session.go:256 (0xe6d53b)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/modules/public/public.go:42 (0xfaef0b)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b)
        /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/common/middleware.go:72 (0x17f29bb)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/common/logger.go:23 (0x17f1dd7)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x17ef207)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x17eb347)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/routers/common/middleware.go:25 (0x17f25af)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /build/vendor/github.com/go-chi/chi/mux.go:87 (0x10177f7)
        /build/modules/web/route.go:318 (0x17d18a7)
        /build/vendor/github.com/gorilla/context/context.go:141 (0xbeda17)
        /usr/local/go/src/net/http/server.go:2069 (0x340e87)
        /usr/local/go/src/net/http/server.go:2887 (0x343893)
        /usr/local/go/src/net/http/server.go:1952 (0x33fc0b)
        /usr/local/go/src/runtime/asm_arm.s:841 (0x85873)
@lunny commented on GitHub (Sep 28, 2021): The first panic is not fixed by #17169. It's wired because https://github.com/go-gitea/gitea/blob/main/services/pull/pull.go#L721 has already loads all pullrequests of issues. It should not panic. ``` 2021/09/27 16:56:30 routers/web/base.go:131:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference /usr/local/go/src/runtime/panic.go:212 (0x4ba7b) /usr/local/go/src/runtime/signal_unix.go:734 (0x6642b) /build/models/pull.go:331 (0x16ba8f8) /build/services/pull/pull.go:747 (0x16ba8e4) /build/services/pull/pull.go:721 (0x16ba5d3) /build/routers/web/user/home.go:568 (0x1949a67) /build/routers/web/user/home.go:351 (0x194907f) /build/modules/web/route.go:64 (0x17d210f) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x17eeae3) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/web/route.go:103 (0x17d2767) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/context/context.go:776 (0x10349ff) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b) /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/web/base.go:186 (0x19abca3) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/gitea.com/go-chi/session/session.go:256 (0xe6d53b) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/modules/public/public.go:42 (0xfaef0b) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:70 (0x1017a1b) /build/vendor/github.com/go-chi/chi/mux.go:311 (0x101cd27) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:436 (0x10198df) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/common/middleware.go:72 (0x17f29bb) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/common/logger.go:23 (0x17f1dd7) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x17ef207) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x17eb347) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/routers/common/middleware.go:25 (0x17f25af) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /build/vendor/github.com/go-chi/chi/mux.go:87 (0x10177f7) /build/modules/web/route.go:318 (0x17d18a7) /build/vendor/github.com/gorilla/context/context.go:141 (0xbeda17) /usr/local/go/src/net/http/server.go:2069 (0x340e87) /usr/local/go/src/net/http/server.go:2887 (0x343893) /usr/local/go/src/net/http/server.go:1952 (0x33fc0b) /usr/local/go/src/runtime/asm_arm.s:841 (0x85873) ```
Author
Owner

@FalseNegative commented on GitHub (Sep 28, 2021):

The code differs between v1.15.3 and master.

Please have a look at
https://github.com/go-gitea/gitea/blob/v1.15.3/services/pull/pull.go#L721
https://github.com/go-gitea/gitea/blob/v1.15.3/services/pull/pull.go#L747

@FalseNegative commented on GitHub (Sep 28, 2021): The code differs between v1.15.3 and master. Please have a look at https://github.com/go-gitea/gitea/blob/v1.15.3/services/pull/pull.go#L721 https://github.com/go-gitea/gitea/blob/v1.15.3/services/pull/pull.go#L747
Author
Owner

@zeripath commented on GitHub (Sep 28, 2021):

@FalseNegative That would imply that issue.PullRequest() is returning a nil PullRequest.

Meaning that there is an issue in the issues that doesn't get its pull request loaded:

7ce938b6c7/services/pull/pull.go (L690)

@zeripath commented on GitHub (Sep 28, 2021): @FalseNegative That would imply that issue.PullRequest() is returning a nil PullRequest. Meaning that there is an issue in the `issues` that doesn't get its pull request loaded: https://github.com/go-gitea/gitea/blob/7ce938b6c7a7c66eb615cf391e9742a65e3e3f95/services/pull/pull.go#L690
Author
Owner

@zeripath commented on GitHub (Sep 28, 2021):

Suggesting perhaps that there is a bug in:

7ce938b6c7/models/issue_list.go (L274-L316)

Or... that perhaps there is an issue that is marked as a pull request but has either:

  • no PR associated with it
  • or a PRID == 0?
@zeripath commented on GitHub (Sep 28, 2021): Suggesting perhaps that there is a bug in: https://github.com/go-gitea/gitea/blob/7ce938b6c7a7c66eb615cf391e9742a65e3e3f95/models/issue_list.go#L274-L316 Or... that perhaps there is an issue that is marked as a pull request but has either: * no PR associated with it * or a PRID == 0?
Author
Owner

@FalseNegative commented on GitHub (Sep 28, 2021):

@zeripath, your previous post made me thinking.

I must have made a mistake when upgrading the PostgreSQL database.

I restored my backup on PostgreSQL 9.6. This time I also kept the Gitea version to 1.15.3. Status = OK
Afterwards I upgraded again to PostgreSQL 13. This time it looks good.

Gitea is runing again without error.

From my point of view, this ticket can be closed.

@FalseNegative commented on GitHub (Sep 28, 2021): @zeripath, your previous post made me thinking. I must have made a mistake when upgrading the PostgreSQL database. I restored my backup on PostgreSQL 9.6. This time I also kept the Gitea version to 1.15.3. Status = OK Afterwards I upgraded again to PostgreSQL 13. This time it looks good. Gitea is runing again without error. From my point of view, this ticket can be closed.
Author
Owner

@zeripath commented on GitHub (Sep 28, 2021):

OK I'll close it - if it happens again it can be reopened.

@zeripath commented on GitHub (Sep 28, 2021): OK I'll close it - if it happens again it can be reopened.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#7901